From 4621085b7eb2f4cffe16d508988ff9b4a874b4ef Mon Sep 17 00:00:00 2001 From: Jeff King Date: Tue, 9 Jul 2013 20:18:40 -0400 Subject: add missing "format" function attributes For most of our functions that take printf-like formats, we use gcc's __attribute__((format)) to get compiler warnings when the functions are misused. Let's give a few more functions the same protection. In most cases, the annotations do not uncover any actual bugs; the only code change needed is that we passed a size_t to transfer_debug, which expected an int. Since we expect the passed-in value to be a relatively small buffer size (and cast a similar value to int directly below), we can just cast away the problem. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- advice.h | 1 + 1 file changed, 1 insertion(+) (limited to 'advice.h') diff --git a/advice.h b/advice.h index 94caa32f92..d4c1764f2a 100644 --- a/advice.h +++ b/advice.h @@ -19,6 +19,7 @@ extern int advice_detached_head; extern int advice_set_upstream_failure; int git_default_advice_config(const char *var, const char *value); +__attribute__((format (printf, 1, 2))) void advise(const char *advice, ...); int error_resolve_conflict(const char *me); extern void NORETURN die_resolve_conflict(const char *me); -- cgit v1.2.3