From ce6521e44139f12d00b49e1fa89dde096d58b0f1 Mon Sep 17 00:00:00 2001 From: Denton Liu Date: Mon, 23 Mar 2020 21:07:51 -0400 Subject: Lib-ify fmt-merge-msg In builtin.h, there exists the distinctly "lib-ish" function fmt_merge_msg(). This function can currently only be called by built-in commands but, unlike most of the other functions in the header, it does not make sense to impose this restriction as the functionality can be logically reused in libgit. Extract this function into fmt-merge-msg.c so that related definitions can exist clearly in their own header file. While we're at it, clean up #includes that are unused. This patch is best viewed with --color-moved. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- builtin.h | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'builtin.h') diff --git a/builtin.h b/builtin.h index 2b25a80cde..6101d98661 100644 --- a/builtin.h +++ b/builtin.h @@ -94,8 +94,6 @@ * command. */ -#define DEFAULT_MERGE_LOG_LEN 20 - extern const char git_usage_string[]; extern const char git_more_info_string[]; @@ -104,15 +102,6 @@ extern const char git_more_info_string[]; void prune_packed_objects(int); -struct fmt_merge_msg_opts { - unsigned add_title:1, - credit_people:1; - int shortlog_len; -}; - -int fmt_merge_msg(struct strbuf *in, struct strbuf *out, - struct fmt_merge_msg_opts *); - /** * If a built-in has DELAY_PAGER_CONFIG set, the built-in should call this early * when it wishes to respect the `pager.foo`-config. The `cmd` is the name of -- cgit v1.2.3