From 25bccb4b79dce1d5c259228ef3c91eadcd13d8ac Mon Sep 17 00:00:00 2001 From: Derrick Stolee Date: Fri, 31 Mar 2023 15:59:04 +0000 Subject: fetch: download bundles once, even with --all When fetch.bundleURI is set, 'git fetch' downloads bundles from the given bundle URI before fetching from the specified remote. However, when using non-file remotes, 'git fetch --all' will launch 'git fetch' subprocesses which then read fetch.bundleURI and fetch the bundle list again. We do not expect the bundle list to have new information during these multiple runs, so avoid these extra calls by un-setting fetch.bundleURI in the subprocess arguments. Be careful to skip fetching bundles for the empty bundle string. Fetching bundles from the empty list presents some interesting test failures. Signed-off-by: Derrick Stolee Signed-off-by: Junio C Hamano --- bundle-uri.c | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'bundle-uri.c') diff --git a/bundle-uri.c b/bundle-uri.c index 177c181040..56390651b9 100644 --- a/bundle-uri.c +++ b/bundle-uri.c @@ -792,6 +792,15 @@ int fetch_bundle_uri(struct repository *r, const char *uri, init_bundle_list(&list); + /* + * Do not fetch a NULL or empty bundle URI. An empty bundle URI + * could signal that a configured bundle URI has been disabled. + */ + if (!uri || !*uri) { + result = 0; + goto cleanup; + } + /* If a bundle is added to this global list, then it is required. */ list.mode = BUNDLE_MODE_ALL; -- cgit v1.2.3