From 677c70799c70a4e176ff3743c7daafe5193b7b2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?SZEDER=20G=C3=A1bor?= Date: Wed, 27 Dec 2017 17:36:03 +0100 Subject: travis-ci: only print test failures if there are test results available MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a build job running the test suite fails, our 'ci/print-test-failures.sh' script scans all 't/test-results/*.exit' files to find failed tests and prints their verbose output. However, if a build job were to fail before it ever gets to run the test suite, then there will be no files to match the above pattern and the shell will take the pattern literally, resulting in errors like this in the trace log: cat: t/test-results/*.exit: No such file or directory ------------------------------------------------------------------------ t/test-results/*.out... ------------------------------------------------------------------------ cat: t/test-results/*.out: No such file or directory Check upfront and proceed only if there are any such files present. Signed-off-by: SZEDER Gábor Reviewed-by: Lars Schneider Signed-off-by: Junio C Hamano --- ci/print-test-failures.sh | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'ci/print-test-failures.sh') diff --git a/ci/print-test-failures.sh b/ci/print-test-failures.sh index 97cc059019..4f261ddc01 100755 --- a/ci/print-test-failures.sh +++ b/ci/print-test-failures.sh @@ -8,6 +8,12 @@ # Tracing executed commands would produce too much noise in the loop below. set +x +if ! ls t/test-results/*.exit >/dev/null 2>/dev/null +then + echo "Build job failed before the tests could have been run" + exit +fi + for TEST_EXIT in t/test-results/*.exit do if [ "$(cat "$TEST_EXIT")" != "0" ] -- cgit v1.2.3