From f26eef302fc315394d1016eb06360637ac86f62e Mon Sep 17 00:00:00 2001 From: Jeff King Date: Fri, 15 Jul 2016 06:26:29 -0400 Subject: check_everything_connected: always pass --quiet to rev-list The check_everything_connected function takes a "quiet" parameter which does two things if non-zero: 1. redirect rev-list's stderr to /dev/null to avoid showing errors to the user 2. pass "--quiet" to rev-list Item (1) is obviously useful. But item (2) is surprisingly not. For rev-list, "--quiet" does not have anything to do with chattiness on stderr; it tells rev-list not to bother writing the list of traversed objects to stdout, for efficiency. And since we always redirect rev-list's stdout to /dev/null in this function, there is no point in asking it to ever write anything to stdout. The efficiency gains are modest; a best-of-five run of "git rev-list --objects --all" on linux.git dropped from 32.013s to 30.502s when adding "--quiet". That's only about 5%, but given how easy it is, it's worth doing. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- connected.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'connected.c') diff --git a/connected.c b/connected.c index bf1b12e7ec..7560a31628 100644 --- a/connected.c +++ b/connected.c @@ -56,8 +56,7 @@ static int check_everything_connected_real(sha1_iterate_fn fn, argv[ac++] = "--stdin"; argv[ac++] = "--not"; argv[ac++] = "--all"; - if (quiet) - argv[ac++] = "--quiet"; + argv[ac++] = "--quiet"; argv[ac] = NULL; rev_list.argv = argv; -- cgit v1.2.3