From 554544276a604c144df45efcb060c80aa322088c Mon Sep 17 00:00:00 2001 From: Denton Liu Date: Mon, 29 Apr 2019 04:28:14 -0400 Subject: *.[ch]: remove extern from function declarations using spatch There has been a push to remove extern from function declarations. Remove some instances of "extern" for function declarations which are caught by Coccinelle. Note that Coccinelle has some difficulty with processing functions with `__attribute__` or varargs so some `extern` declarations are left behind to be dealt with in a future patch. This was the Coccinelle patch used: @@ type T; identifier f; @@ - extern T f(...); and it was run with: $ git ls-files \*.{c,h} | grep -v ^compat/ | xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place Files under `compat/` are intentionally excluded as some are directly copied from external sources and we should avoid churning them as much as possible. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- exec-cmd.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'exec-cmd.h') diff --git a/exec-cmd.h b/exec-cmd.h index 2522453cda..bddf5cb934 100644 --- a/exec-cmd.h +++ b/exec-cmd.h @@ -3,14 +3,14 @@ struct argv_array; -extern void git_set_exec_path(const char *exec_path); -extern void git_resolve_executable_dir(const char *path); -extern const char *git_exec_path(void); -extern void setup_path(void); -extern const char **prepare_git_cmd(struct argv_array *out, const char **argv); -extern int execv_git_cmd(const char **argv); /* NULL terminated */ +void git_set_exec_path(const char *exec_path); +void git_resolve_executable_dir(const char *path); +const char *git_exec_path(void); +void setup_path(void); +const char **prepare_git_cmd(struct argv_array *out, const char **argv); +int execv_git_cmd(const char **argv); /* NULL terminated */ LAST_ARG_MUST_BE_NULL extern int execl_git_cmd(const char *cmd, ...); -extern char *system_path(const char *path); +char *system_path(const char *path); #endif /* GIT_EXEC_CMD_H */ -- cgit v1.2.3