From eccb614924c9067eeceffa503e4da3683f1c8b6b Mon Sep 17 00:00:00 2001 From: Jeff King Date: Tue, 9 Jul 2013 20:19:12 -0400 Subject: use "sentinel" function attribute for variadic lists This attribute can help gcc notice when callers forget to add a NULL sentinel to the end of the function. This is our first use of the sentinel attribute, but we shouldn't need to #ifdef for other compilers, as __attribute__ is already a no-op on non-gcc-compatible compilers. Suggested-by: Bert Wesarg More-Spots-Found-By: Matt Kraai Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- exec_cmd.h | 1 + 1 file changed, 1 insertion(+) (limited to 'exec_cmd.h') diff --git a/exec_cmd.h b/exec_cmd.h index e2b546b615..307b55cbad 100644 --- a/exec_cmd.h +++ b/exec_cmd.h @@ -7,6 +7,7 @@ extern const char *git_exec_path(void); extern void setup_path(void); extern const char **prepare_git_cmd(const char **argv); extern int execv_git_cmd(const char **argv); /* NULL terminated */ +__attribute__((sentinel)) extern int execl_git_cmd(const char *cmd, ...); extern const char *system_path(const char *path); -- cgit v1.2.3