From dddbad728c93280fe54ef86699b6d70e2aab44d1 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Wed, 26 Apr 2017 21:29:31 +0200 Subject: timestamp_t: a new data type for timestamps Git's source code assumes that unsigned long is at least as precise as time_t. Which is incorrect, and causes a lot of problems, in particular where unsigned long is only 32-bit (notably on Windows, even in 64-bit versions). So let's just use a more appropriate data type instead. In preparation for this, we introduce the new `timestamp_t` data type. By necessity, this is a very, very large patch, as it has to replace all timestamps' data type in one go. As we will use a data type that is not necessarily identical to `time_t`, we need to be very careful to use `time_t` whenever we interact with the system functions, and `timestamp_t` everywhere else. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- git-compat-util.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'git-compat-util.h') diff --git a/git-compat-util.h b/git-compat-util.h index cd522903ed..72c12173a1 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -319,8 +319,10 @@ extern char *gitdirname(char *); #define PRIo32 "o" #endif +typedef unsigned long timestamp_t; #define PRItime "lu" #define parse_timestamp strtoul +#define TIME_MAX ULONG_MAX #ifndef PATH_SEP #define PATH_SEP ':' -- cgit v1.2.3