From b3bb5f76e6193db102b063187be854ef3842d89b Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 30 Apr 2008 00:36:14 -0400 Subject: cvsimport: always pass user data to "system" as a list This avoids invoking the shell. Not only is it faster, but it prevents the possibility of interpreting our arguments in the shell. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- git-cvsimport.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'git-cvsimport.perl') diff --git a/git-cvsimport.perl b/git-cvsimport.perl index 8093996e25..33777e2785 100755 --- a/git-cvsimport.perl +++ b/git-cvsimport.perl @@ -767,7 +767,7 @@ sub commit { waitpid($pid,0); die "Error running git-commit-tree: $?\n" if $?; - system("git-update-ref $remote/$branch $cid") == 0 + system('git-update-ref', "$remote/$branch", $cid) == 0 or die "Cannot write branch $branch for update: $!\n"; if ($tag) { -- cgit v1.2.3