From 13092a916d7b8211fd828a6a7ee0d3cefff995e1 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Wed, 12 Oct 2016 11:20:23 -0700 Subject: cocci: refactor common patterns to use xstrdup_or_null() d64ea0f83b ("git-compat-util: add xstrdup_or_null helper", 2015-01-12) added a handy wrapper that allows us to get a duplicate of a string or NULL if the original is NULL, but a handful of codepath predate its introduction or just weren't aware of it. Signed-off-by: Junio C Hamano --- imap-send.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'imap-send.c') diff --git a/imap-send.c b/imap-send.c index 0f5f4760e9..9514ddc565 100644 --- a/imap-send.c +++ b/imap-send.c @@ -1082,10 +1082,8 @@ static struct imap_store *imap_open_store(struct imap_server_conf *srvc, char *f cred.protocol = xstrdup(srvc->use_ssl ? "imaps" : "imap"); cred.host = xstrdup(srvc->host); - if (srvc->user) - cred.username = xstrdup(srvc->user); - if (srvc->pass) - cred.password = xstrdup(srvc->pass); + cred.username = xstrdup_or_null(srvc->user); + cred.password = xstrdup_or_null(srvc->pass); credential_fill(&cred); -- cgit v1.2.3