From d67609bdded151d78522911629c9e7da7fd06640 Mon Sep 17 00:00:00 2001 From: Taylor Blau Date: Wed, 12 Jul 2023 19:37:49 -0400 Subject: midx.c: prevent overflow in `fill_included_packs_batch()` In a similar spirit as in previous commits, avoid an integer overflow when computing the expected size of a MIDX. (Note that this is also OK as-is, since `p->pack_size` is an `off_t`, so this computation should already be done as 64-bit integers. But again, let's use `st_mult()` to make this fact clear). Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano --- midx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'midx.c') diff --git a/midx.c b/midx.c index 606e3ae79e..067482a98c 100644 --- a/midx.c +++ b/midx.c @@ -1994,8 +1994,8 @@ static int fill_included_packs_batch(struct repository *r, if (open_pack_index(p) || !p->num_objects) continue; - expected_size = (size_t)(p->pack_size - * pack_info[i].referenced_objects); + expected_size = st_mult(p->pack_size, + pack_info[i].referenced_objects); expected_size /= p->num_objects; if (expected_size >= batch_size) -- cgit v1.2.3