From 779ad6641b9a6443eaec75439b3374b1a7b8794c Mon Sep 17 00:00:00 2001 From: Mike Hommey Date: Sun, 25 Aug 2019 14:18:18 +0900 Subject: notes: avoid leaking duplicate entries When add_note is called multiple times with the same key/value pair, the leaf_node it creates is leaked by notes_tree_insert. Signed-off-by: Mike Hommey Signed-off-by: Junio C Hamano --- notes.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'notes.c') diff --git a/notes.c b/notes.c index 532ec37865..3130add618 100644 --- a/notes.c +++ b/notes.c @@ -269,8 +269,10 @@ static int note_tree_insert(struct notes_tree *t, struct int_node *tree, case PTR_TYPE_NOTE: if (oideq(&l->key_oid, &entry->key_oid)) { /* skip concatenation if l == entry */ - if (oideq(&l->val_oid, &entry->val_oid)) + if (oideq(&l->val_oid, &entry->val_oid)) { + free(entry); return 0; + } ret = combine_notes(&l->val_oid, &entry->val_oid); -- cgit v1.2.3