From 5c20398699165a91af2d81ea2d20385bc8dd3627 Mon Sep 17 00:00:00 2001 From: Emily Shaffer Date: Mon, 2 Mar 2020 20:05:06 -0800 Subject: prefix_path: show gitdir if worktree unavailable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If there is no worktree at present, we can still hint the user about Git's current directory by showing them the absolute path to the Git directory. Even though the Git directory doesn't make it as easy to locate the worktree in question, it can still help a user figure out what's going on while developing a script. This fixes a segmentation fault introduced in e0020b2f ("prefix_path: show gitdir when arg is outside repo", 2020-02-14). Signed-off-by: Emily Shaffer [jc: added minimum tests, with help from Szeder Gábor] Signed-off-by: Junio C Hamano --- pathspec.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'pathspec.c') diff --git a/pathspec.c b/pathspec.c index 166d255642..8243e06eab 100644 --- a/pathspec.c +++ b/pathspec.c @@ -438,9 +438,13 @@ static void init_pathspec_item(struct pathspec_item *item, unsigned flags, } else { match = prefix_path_gently(prefix, prefixlen, &prefixlen, copyfrom); - if (!match) + if (!match) { + const char *hint_path = get_git_work_tree(); + if (!hint_path) + hint_path = get_git_dir(); die(_("%s: '%s' is outside repository at '%s'"), elt, - copyfrom, absolute_path(get_git_work_tree())); + copyfrom, absolute_path(hint_path)); + } } item->match = match; -- cgit v1.2.3