From 3bc4181fde899e02aff89f7c0a47f18d37311cb3 Mon Sep 17 00:00:00 2001 From: Clemens Buchacher Date: Wed, 27 Jul 2011 23:32:34 +0200 Subject: error_routine: use parent's stderr if exec fails The new process's error output may be redirected elsewhere, but if the exec fails, output should still go to the parent's stderr. This has already been done for the die_routine. Do the same for error_routine. Signed-off-by: Clemens Buchacher Signed-off-by: Junio C Hamano --- run-command.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) (limited to 'run-command.c') diff --git a/run-command.c b/run-command.c index 70e8a249d0..5c91f37fb8 100644 --- a/run-command.c +++ b/run-command.c @@ -77,16 +77,14 @@ static void notify_parent(void) static NORETURN void die_child(const char *err, va_list params) { - char msg[4096]; - int len = vsnprintf(msg, sizeof(msg), err, params); - if (len > sizeof(msg)) - len = sizeof(msg); - - write_in_full(child_err, "fatal: ", 7); - write_in_full(child_err, msg, len); - write_in_full(child_err, "\n", 1); + vwritef(child_err, "fatal: ", err, params); exit(128); } + +static void error_child(const char *err, va_list params) +{ + vwritef(child_err, "error: ", err, params); +} #endif static inline void set_cloexec(int fd) @@ -217,6 +215,7 @@ fail_pipe: set_cloexec(child_err); } set_die_routine(die_child); + set_error_routine(error_child); close(notify_pipe[0]); set_cloexec(notify_pipe[1]); -- cgit v1.2.3