From 786e67611d46cd761e1aaa73f85b62f3dda1960a Mon Sep 17 00:00:00 2001 From: Seija Date: Fri, 2 Dec 2022 17:02:58 +0000 Subject: maintenance: compare output of pthread functions for inequality with 0 The documentation for pthread_create and pthread_sigmask state that: "On success, pthread_create() returns 0; on error, it returns an error number" As such, we ought to check for an error by seeing if the output is not 0. Checking for "less than" is a mistake as the error code numbers can be greater than 0. Signed-off-by: Seija Acked-by: Jeff Hostetler Signed-off-by: Junio C Hamano --- run-command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'run-command.c') diff --git a/run-command.c b/run-command.c index 5ec3a46dcc..14040f0276 100644 --- a/run-command.c +++ b/run-command.c @@ -1054,7 +1054,7 @@ static void *run_thread(void *data) sigset_t mask; sigemptyset(&mask); sigaddset(&mask, SIGPIPE); - if (pthread_sigmask(SIG_BLOCK, &mask, NULL) < 0) { + if (pthread_sigmask(SIG_BLOCK, &mask, NULL)) { ret = error("unable to block SIGPIPE in async thread"); return (void *)ret; } -- cgit v1.2.3