From 2020451c5bcc5289b8e6f25c7092d4fdb702257a Mon Sep 17 00:00:00 2001 From: Jeff King Date: Fri, 23 Oct 2020 03:26:30 -0400 Subject: am, sequencer: stop parsing our own committer ident For the --committer-date-is-author-date option of git-am and git-rebase, we format the committer ident, then re-parse it to find the name and email, and then feed those back to fmt_ident(). We can simplify this by handling it all at the time of the fmt_ident() call. We pass in the appropriate getenv() results, and if they're not present, then our WANT_COMMITTER_IDENT flag tells fmt_ident() to fill in the appropriate value from the config. Which is exactly what git_committer_ident() was doing under the hood. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- sequencer.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'sequencer.h') diff --git a/sequencer.h b/sequencer.h index 20493a2be2..3587878e3b 100644 --- a/sequencer.h +++ b/sequencer.h @@ -50,8 +50,6 @@ struct replay_opts { int mainline; - char *committer_name; - char *committer_email; char *gpg_sign; enum commit_msg_cleanup_mode default_msg_cleanup; int explicit_cleanup; -- cgit v1.2.3