From 5f2b643e76d9a1330c1a02489c0787ca7d818633 Mon Sep 17 00:00:00 2001 From: "Randall S. Becker" Date: Fri, 19 Jun 2020 16:23:20 -0400 Subject: strbuf: remove unreferenced strbuf_write_fd method. strbuf_write_fd was only used in bugreport.c. Since that file now uses write_in_full, this method is no longer needed. In addition, strbuf_write_fd did not guard against exceeding MAX_IO_SIZE for the platform, nor provided error handling in the event of a failure if only partial data was written to the file descriptor. Since already write_in_full has this capability and is in general use, it should be used instead. The change impacts strbuf.c and strbuf.h. Signed-off-by: Randall S. Becker Signed-off-by: Junio C Hamano --- strbuf.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'strbuf.c') diff --git a/strbuf.c b/strbuf.c index f1d66c7848..4bbaff2bda 100644 --- a/strbuf.c +++ b/strbuf.c @@ -539,11 +539,6 @@ ssize_t strbuf_write(struct strbuf *sb, FILE *f) return sb->len ? fwrite(sb->buf, 1, sb->len, f) : 0; } -ssize_t strbuf_write_fd(struct strbuf *sb, int fd) -{ - return sb->len ? write(fd, sb->buf, sb->len) : 0; -} - #define STRBUF_MAXLINK (2*PATH_MAX) int strbuf_readlink(struct strbuf *sb, const char *path, size_t hint) -- cgit v1.2.3