From 554544276a604c144df45efcb060c80aa322088c Mon Sep 17 00:00:00 2001 From: Denton Liu Date: Mon, 29 Apr 2019 04:28:14 -0400 Subject: *.[ch]: remove extern from function declarations using spatch There has been a push to remove extern from function declarations. Remove some instances of "extern" for function declarations which are caught by Coccinelle. Note that Coccinelle has some difficulty with processing functions with `__attribute__` or varargs so some `extern` declarations are left behind to be dealt with in a future patch. This was the Coccinelle patch used: @@ type T; identifier f; @@ - extern T f(...); and it was run with: $ git ls-files \*.{c,h} | grep -v ^compat/ | xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place Files under `compat/` are intentionally excluded as some are directly copied from external sources and we should avoid churning them as much as possible. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- submodule-config.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'submodule-config.h') diff --git a/submodule-config.h b/submodule-config.h index 4dc9b0771c..a88ae7107f 100644 --- a/submodule-config.h +++ b/submodule-config.h @@ -30,17 +30,17 @@ struct submodule { struct submodule_cache; struct repository; -extern void submodule_cache_free(struct submodule_cache *cache); +void submodule_cache_free(struct submodule_cache *cache); -extern int parse_submodule_fetchjobs(const char *var, const char *value); -extern int parse_fetch_recurse_submodules_arg(const char *opt, const char *arg); +int parse_submodule_fetchjobs(const char *var, const char *value); +int parse_fetch_recurse_submodules_arg(const char *opt, const char *arg); struct option; -extern int option_fetch_parse_recurse_submodules(const struct option *opt, +int option_fetch_parse_recurse_submodules(const struct option *opt, const char *arg, int unset); -extern int parse_update_recurse_submodules_arg(const char *opt, const char *arg); -extern int parse_push_recurse_submodules_arg(const char *opt, const char *arg); -extern void repo_read_gitmodules(struct repository *repo); -extern void gitmodules_config_oid(const struct object_id *commit_oid); +int parse_update_recurse_submodules_arg(const char *opt, const char *arg); +int parse_push_recurse_submodules_arg(const char *opt, const char *arg); +void repo_read_gitmodules(struct repository *repo); +void gitmodules_config_oid(const struct object_id *commit_oid); const struct submodule *submodule_from_name(struct repository *r, const struct object_id *commit_or_tree, const char *name); @@ -66,7 +66,7 @@ int check_submodule_name(const char *name); * New helpers to retrieve arbitrary configuration from the '.gitmodules' file * should NOT be added. */ -extern void fetch_config_from_gitmodules(int *max_children, int *recurse_submodules); -extern void update_clone_config_from_gitmodules(int *max_jobs); +void fetch_config_from_gitmodules(int *max_children, int *recurse_submodules); +void update_clone_config_from_gitmodules(int *max_jobs); #endif /* SUBMODULE_CONFIG_H */ -- cgit v1.2.3