From b9e4d84878b5c14fd4bd6e94e4e7d9ed0fc95c69 Mon Sep 17 00:00:00 2001 From: Jeff Hostetler Date: Mon, 4 Oct 2021 22:29:03 +0000 Subject: t/perf/perf-lib.sh: remove test_times.* at the end test_perf_() Teach test_perf_() to remove the temporary test_times.* files at the end of each test. test_perf_() runs a particular GIT_PERF_REPEAT_COUNT times and creates ./test_times.[123...]. It then uses a perl script to find the minimum over "./test_times.*" (note the wildcard) and writes that time to "test-results/..result". If the repeat count is changed during the pXXXX test script, stale test_times.* files (from previous steps) may be included in the min() computation. For example: ... GIT_PERF_REPEAT_COUNT=3 \ test_perf "status" " git status " GIT_PERF_REPEAT_COUNT=1 \ test_perf "checkout other" " git checkout other " ... The time reported in the summary for "XXXX.2 checkout other" would be "min( checkout[1], status[2], status[3] )". We prevent that error by removing the test_times.* files at the end of each test. Signed-off-by: Jeff Hostetler Signed-off-by: Junio C Hamano --- t/perf/perf-lib.sh | 1 + 1 file changed, 1 insertion(+) (limited to 't/perf') diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh index f5ed092ee5..a1b5d2804d 100644 --- a/t/perf/perf-lib.sh +++ b/t/perf/perf-lib.sh @@ -230,6 +230,7 @@ test_perf_ () { test_ok_ "$1" fi "$TEST_DIRECTORY"/perf/min_time.perl test_time.* >"$base".result + rm test_time.* } test_perf () { -- cgit v1.2.3