From 3a9f0f41db87e197708f84aeb2487bc983f99c9c Mon Sep 17 00:00:00 2001 From: Pierre Habouzit Date: Sat, 26 Jan 2008 12:26:57 +0100 Subject: parse-options: catch likely typo in presense of aggregated options. If options are aggregated, and that the whole token is an exact prefix of a long option that is longer than 2 letters, reject it. This is to prevent a common typo: $ git commit -amend to get interpreted as "commit all with message 'end'". The typo check isn't performed if there is no aggregation, because the stuck form is the recommended one. If we have `-o` being a valid short option that takes an argument, and --option a long one, then we _MUST_ accept -option as "'o' option with argument 'ption'", which is our official recommended form. Signed-off-by: Pierre Habouzit Signed-off-by: Junio C Hamano --- test-parse-options.c | 1 + 1 file changed, 1 insertion(+) (limited to 'test-parse-options.c') diff --git a/test-parse-options.c b/test-parse-options.c index 4d3e2ec39e..eed8a02c65 100644 --- a/test-parse-options.c +++ b/test-parse-options.c @@ -19,6 +19,7 @@ int main(int argc, const char **argv) OPT_STRING('s', "string", &string, "string", "get a string"), OPT_STRING(0, "string2", &string, "str", "get another string"), OPT_STRING(0, "st", &string, "st", "get another string (pervert ordering)"), + OPT_STRING('o', NULL, &string, "str", "get another string"), OPT_END(), }; int i; -- cgit v1.2.3