From 4c4b7d1d3b5be12ad83d0ecfc537b40af37462c9 Mon Sep 17 00:00:00 2001 From: Lukas Fleischer Date: Tue, 14 Jun 2016 16:49:16 +0200 Subject: sideband.c: make send_sideband() return void The send_sideband() function uses write_or_die() for writing data which immediately terminates the process on errors. If no such error occurred, send_sideband() always returned the value that was passed as fourth parameter prior to this commit. This value is already known to the caller in any case, so let's turn send_sideband() into a void function instead. Signed-off-by: Lukas Fleischer Signed-off-by: Junio C Hamano --- upload-pack.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'upload-pack.c') diff --git a/upload-pack.c b/upload-pack.c index f19444df7b..f9d6410605 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -60,8 +60,10 @@ static void reset_timeout(void) static ssize_t send_client_data(int fd, const char *data, ssize_t sz) { - if (use_sideband) - return send_sideband(1, fd, data, sz, use_sideband); + if (use_sideband) { + send_sideband(1, fd, data, sz, use_sideband); + return sz; + } if (fd == 3) /* emergency quit */ fd = 2; -- cgit v1.2.3