From d43a21bdbbaf0bc286df8d8e2e29a3e9caa448e8 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Thu, 3 Dec 2020 03:09:42 -0500 Subject: upload-pack: propagate return value from object filter config callback If we encounter an error in parse_filter_object_config(), we'll complain to stderr but won't actually propagate the return value up the stack. This is unlike most of our config callbacks, which return the error to git_config() so it can die (this includes the call just below us to parse_hide_refs_config(), which can also produce errors). Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- upload-pack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'upload-pack.c') diff --git a/upload-pack.c b/upload-pack.c index 3b858eb457..1dd8afbbcb 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -1307,7 +1307,8 @@ static int upload_pack_config(const char *var, const char *value, void *cb_data) return git_config_string(&data->pack_objects_hook, var, value); } - parse_object_filter_config(var, value, data); + if (parse_object_filter_config(var, value, data) < 0) + return -1; return parse_hide_refs_config(var, value, "uploadpack"); } -- cgit v1.2.3