diff options
| author | Marzal <2069735+Marzal@users.noreply.github.com> | 2019-09-20 00:36:36 +0300 |
|---|---|---|
| committer | Marzal <2069735+Marzal@users.noreply.github.com> | 2019-09-20 00:36:36 +0300 |
| commit | 0e1e80bacf81e28b9a70ab0a997480bc3d7141f6 (patch) | |
| tree | b8b180e22711f922e6d08ccf5269f2eefbf65e6d /include/tests_authentication | |
| parent | 42ac40aad6a15c2ae354e8a274723355cb7f26d3 (diff) | |
Double quote to prevent globbing and word splitting.SC2086
Diffstat (limited to 'include/tests_authentication')
| -rw-r--r-- | include/tests_authentication | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/include/tests_authentication b/include/tests_authentication index 9838b399..fc3d05df 100644 --- a/include/tests_authentication +++ b/include/tests_authentication @@ -738,7 +738,7 @@ # Note : Every Linux based operating system seem to have different passwd # options, so we have to check the version first. if [ "${OS}" = "Linux" ]; then - if [ ${OS_REDHAT_OR_CLONE} -eq 0 ]; then + if [ "${OS_REDHAT_OR_CLONE}" -eq 0 ]; then case ${LINUX_VERSION} in "SuSE") PREQS_MET="YES" @@ -751,10 +751,10 @@ FIND2=$(passwd --all --status 2> /dev/null | ${AWKBINARY} '{ if ($2=="NP") print $1 }') ;; esac - elif [ ${OS_REDHAT_OR_CLONE} -eq 1 ]; then + elif [ "${OS_REDHAT_OR_CLONE}" -eq 1 ]; then PREQS_MET="YES" - FIND_P=$(for I in $(${AWKBINARY} -F: '{print $1}' ${ROOTDIR}etc/passwd) ; do passwd -S $I | ${AWKBINARY} '{ if ($2=="PS" && $5=="99999") print $1 }' ; done) - FIND2=$(for I in $(${AWKBINARY} -F: '{print $1}' ${ROOTDIR}etc/passwd) ; do passwd -S $I | ${AWKBINARY} '{ if ($2=="NP") print $1 }' ; done) + FIND_P=$(for I in $(${AWKBINARY} -F: '{print $1}' "${ROOTDIR}etc/passwd") ; do passwd -S "$I" | ${AWKBINARY} '{ if ($2=="PS" && $5=="99999") print $1 }' ; done) + FIND2=$(for I in $(${AWKBINARY} -F: '{print $1}' "${ROOTDIR}etc/passwd") ; do passwd -S "$I" | ${AWKBINARY} '{ if ($2=="NP") print $1 }' ; done) else LogText "Result: skipping test for this Linux version" ReportManual "AUTH-9282:01" @@ -769,7 +769,7 @@ # Test : AUTH-9282 # Description : Search password protected accounts without expire (Linux) Register --test-no AUTH-9282 --preqs-met ${PREQS_MET} --weight L --network NO --category security --description "Checking password protected account without expire date" - if [ ${SKIPTEST} -eq 0 ]; then + if [ "${SKIPTEST}" -eq 0 ]; then LogText "Test: Checking Linux version and password expire date status" if [ -z "${FIND_P}" ]; then LogText "Result: all accounts seem to have an expire date" @@ -780,7 +780,7 @@ LogText "Account without expire date: ${I}" done Display --indent 2 --text "- Accounts without expire date" --result "${STATUS_SUGGESTION}" --color YELLOW - ReportSuggestion ${TEST_NO} "When possible set expire dates for all password protected accounts" + ReportSuggestion "${TEST_NO}" "When possible set expire dates for all password protected accounts" fi fi # @@ -789,7 +789,7 @@ # Test : AUTH-9283 # Description : Search passwordless accounts Register --test-no AUTH-9283 --preqs-met ${PREQS_MET} --weight L --network NO --category security --description "Checking accounts without password" - if [ ${SKIPTEST} -eq 0 ]; then + if [ "${SKIPTEST}" -eq 0 ]; then LogText "Test: Checking passwordless accounts" if [ -z "${FIND2}" ]; then LogText "Result: all accounts seem to have a password" @@ -801,7 +801,7 @@ Report "account_without_password=${I}" done Display --indent 2 --text "- Accounts without password" --result "${STATUS_WARNING}" --color RED - ReportWarning ${TEST_NO} "Found accounts without password" + ReportWarning "${TEST_NO}" "Found accounts without password" fi fi # |