From c9fde8c2d11744cc0875bc3e5dd0abf096211755 Mon Sep 17 00:00:00 2001 From: mboelen Date: Mon, 15 Sep 2014 12:01:09 +0200 Subject: Code cleanup and small enhancements --- include/tests_memory_processes | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'include/tests_memory_processes') diff --git a/include/tests_memory_processes b/include/tests_memory_processes index 88c0cbc0..4522a185 100644 --- a/include/tests_memory_processes +++ b/include/tests_memory_processes @@ -28,7 +28,7 @@ if [ ${SKIPTEST} -eq 0 ]; then if [ -f /proc/meminfo ]; then logtext "Result: found /proc/meminfo" - Display --indent 2 --text "- Checking /proc/meminfo... " --result FOUND --color GREEN + Display --indent 2 --text "- Checking /proc/meminfo" --result FOUND --color GREEN FIND=`cat /proc/meminfo | grep "^MemTotal" | tr -s ' ' | awk '{ print $2" "$3 }'` MEMORY_SIZE=`echo ${FIND} | awk '{ print $1 }'` MEMORY_UNITS=`echo ${FIND} | awk '{ print $2 }'` @@ -48,14 +48,14 @@ if [ ${SKIPTEST} -eq 0 ]; then logtext "Test: Searching /usr/sbin/prtconf" if [ -x /usr/sbin/prtconf ]; then - Display --indent 2 --text "- Querying prtconf for installed memory..." --result DONE --color GREEN + Display --indent 2 --text "- Querying prtconf for installed memory" --result DONE --color GREEN MEMORY_SIZE=`/usr/sbin/prtconf | grep "^Memory size:" | cut -d ' ' -f3` MEMORY_UNITS=`/usr/sbin/prtconf | grep "^Memory size:" | cut -d ' ' -f4` logtext "Result: Found ${MEMORY_SIZE} ${MEMORY_UNITS} memory" report "memory_size=${MEMORY_SIZE}" report "memory_units=${MEMORY_UNITS}" else - Display --indent 2 --text "- Querying prtconf for installed memory..." --result SKIPPED --color WHITE + Display --indent 2 --text "- Querying prtconf for installed memory" --result SKIPPED --color WHITE logtext "Result: /usr/sbin/prtconf not found" fi fi @@ -75,11 +75,11 @@ fi if [ "${FIND}" = "" ]; then logtext "Result: no zombie processes found" - Display --indent 2 --text "- Searching for dead/zombie processes..." --result OK --color GREEN + Display --indent 2 --text "- Searching for dead/zombie processes" --result OK --color GREEN else logtext "Result: found one or more dead or zombie processes" logtext "Output: PIDs ${FIND}" - Display --indent 2 --text "- Searching for dead/zombie processes..." --result WARNING --color RED + Display --indent 2 --text "- Searching for dead/zombie processes" --result WARNING --color RED ReportSuggestion ${TEST_NO} "Check the output of ps for dead or zombie processes" fi fi @@ -99,12 +99,12 @@ fi if [ "${FIND}" = "" ]; then logtext "Result: No processes were waiting for IO requests to be handled first" - Display --indent 2 --text "- Searching for IO waiting processes..." --result OK --color GREEN + Display --indent 2 --text "- Searching for IO waiting processes" --result OK --color GREEN else logtext "Result: found one or more processes which were waiting to get IO requests handled first" logtext "More info: processes which show up with the status flag 'D' are often stuck, until a disk IO event finished. This can happen for example with network storage, where the connection or protocol settings are not logtext well configured." logtext "Output: PIDs ${FIND}" - Display --indent 2 --text "- Searching for IO waiting processes..." --result WARNING --color RED + Display --indent 2 --text "- Searching for IO waiting processes" --result WARNING --color RED ReportSuggestion ${TEST_NO} "Check process listing for processes waiting for IO requests" fi fi -- cgit v1.2.3