diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2021-03-01 15:44:12 +0300 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2021-09-10 17:04:26 +0300 |
| commit | c4708620f80c448b77030ce768eaa99eaba53c67 (patch) | |
| tree | 2fab601159c12046687741f5606c6cfbab1a7307 /libavutil | |
| parent | 2f3efc996a84b6a1a545b45ad00806035c0ea772 (diff) | |
avutil/timecode: Avoid fps overflow
Fixes: Integer overflow and division by 0
Fixes: poc-202102-div.mov
Found-by: 1vanChen of NSFOCUS Security Team
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit c94875471e3ba3dc396c6919ff3ec9b14539cd71)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavutil')
| -rw-r--r-- | libavutil/timecode.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libavutil/timecode.c b/libavutil/timecode.c index 76163d5553..f029f25839 100644 --- a/libavutil/timecode.c +++ b/libavutil/timecode.c @@ -96,8 +96,8 @@ char *av_timecode_make_string(const AVTimecode *tc, char *buf, int framenum) } ff = framenum % fps; ss = framenum / fps % 60; - mm = framenum / (fps*60) % 60; - hh = framenum / (fps*3600); + mm = framenum / (fps*60LL) % 60; + hh = framenum / (fps*3600LL); if (tc->flags & AV_TIMECODE_FLAG_24HOURSMAX) hh = hh % 24; snprintf(buf, AV_TIMECODE_STR_SIZE, "%s%02d:%02d:%02d%c%02d", |