From 774239be717150909219ad2c0696bfb6a50cf2cb Mon Sep 17 00:00:00 2001 From: Timothy Gu Date: Mon, 24 Feb 2014 02:19:55 +0000 Subject: ffmpeg_opt: get_preset_file_2(): fix avio_open2() return code check avio_open2() only return < 0 when error. Signed-off-by: Timothy Gu Signed-off-by: Michael Niedermayer --- ffmpeg_opt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'ffmpeg_opt.c') diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index 7b4630fb25..7bd0817c29 100644 --- a/ffmpeg_opt.c +++ b/ffmpeg_opt.c @@ -978,14 +978,14 @@ static uint8_t *get_line(AVIOContext *s) static int get_preset_file_2(const char *preset_name, const char *codec_name, AVIOContext **s) { - int i, ret = 1; + int i, ret = -1; char filename[1000]; const char *base[3] = { getenv("AVCONV_DATADIR"), getenv("HOME"), AVCONV_DATADIR, }; - for (i = 0; i < FF_ARRAY_ELEMS(base) && ret; i++) { + for (i = 0; i < FF_ARRAY_ELEMS(base) && ret < 0; i++) { if (!base[i]) continue; if (codec_name) { @@ -993,7 +993,7 @@ static int get_preset_file_2(const char *preset_name, const char *codec_name, AV i != 1 ? "" : "/.avconv", codec_name, preset_name); ret = avio_open2(s, filename, AVIO_FLAG_READ, &int_cb, NULL); } - if (ret) { + if (ret < 0) { snprintf(filename, sizeof(filename), "%s%s/%s.avpreset", base[i], i != 1 ? "" : "/.avconv", preset_name); ret = avio_open2(s, filename, AVIO_FLAG_READ, &int_cb, NULL); -- cgit v1.2.3