diff options
| author | Hans-Kristian Arntzen <post@arntzen-software.no> | 2022-03-21 13:31:51 +0300 |
|---|---|---|
| committer | Hans-Kristian Arntzen <post@arntzen-software.no> | 2022-09-14 16:48:23 +0300 |
| commit | 047959074b572e55cf6a92b67a524d56f5a0a9e2 (patch) | |
| tree | 91d80b2109958f0d0fa4175ca58cb1809e2067ef | |
| parent | 7394ab8266f99640a9397774aaf6b844f2350f93 (diff) | |
vkd3d: Add FIXME for dubious use of dsv_plane_optimal_mask.
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
| -rw-r--r-- | libs/vkd3d/state.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/libs/vkd3d/state.c b/libs/vkd3d/state.c index 13d3ad3d..199996b0 100644 --- a/libs/vkd3d/state.c +++ b/libs/vkd3d/state.c @@ -4275,6 +4275,8 @@ VkPipeline d3d12_pipeline_state_create_pipeline_variant(struct d3d12_pipeline_st if (d3d12_graphics_pipeline_state_has_unknown_dsv_format_with_test(graphics) && dsv_format) TRACE("Compiling %p with fallback DSV format %#x.\n", state, dsv_format->vk_format); + /* FIXME: This gets modified on late recompilation, could there be thread safety issues here? + * For GENERAL depth-stencil, this mask should not matter at all, but there might be edge cases for tracked DSV. */ graphics->dsv_plane_optimal_mask = d3d12_graphics_pipeline_state_get_plane_optimal_mask(graphics, dsv_format); if (key) |