From eb4791a1cdabebbf0b0d5a81a40ecc7d88924656 Mon Sep 17 00:00:00 2001 From: pwnnex Date: Wed, 22 Apr 2026 18:55:09 +0300 Subject: hysteria: also accept "hysteria2" protocol string UI stores v1 and v2 both as "hysteria" with settings.version, but inbounds that came in from imports / manual SQL can carry the literal "hysteria2" string and get silently dropped everywhere we switch on protocol. Add Hysteria2 constant + IsHysteria helper, use it in the places that gate on protocol (sub SQL, getLink, genHysteriaLink, clash buildProxy, json gen, inbound.go validation, xray AddUser). Existing "hysteria" inbounds are untouched. closes #4081 --- database/model/model.go | 14 +++++++++++++- database/model/model_test.go | 22 ++++++++++++++++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) create mode 100644 database/model/model_test.go (limited to 'database/model') diff --git a/database/model/model.go b/database/model/model.go index 5fa934c0..01654d22 100644 --- a/database/model/model.go +++ b/database/model/model.go @@ -21,9 +21,21 @@ const ( Shadowsocks Protocol = "shadowsocks" Mixed Protocol = "mixed" WireGuard Protocol = "wireguard" - Hysteria Protocol = "hysteria" + // UI stores Hysteria v1 and v2 both as "hysteria" and uses + // settings.version to discriminate. Imports from outside the panel + // can carry the literal "hysteria2" string, so IsHysteria below + // accepts both. + Hysteria Protocol = "hysteria" + Hysteria2 Protocol = "hysteria2" ) +// IsHysteria returns true for both "hysteria" and "hysteria2". +// Use instead of a bare ==model.Hysteria check: a v2 inbound stored +// with the literal v2 string would otherwise fall through (#4081). +func IsHysteria(p Protocol) bool { + return p == Hysteria || p == Hysteria2 +} + // User represents a user account in the 3x-ui panel. type User struct { Id int `json:"id" gorm:"primaryKey;autoIncrement"` diff --git a/database/model/model_test.go b/database/model/model_test.go new file mode 100644 index 00000000..d98c5157 --- /dev/null +++ b/database/model/model_test.go @@ -0,0 +1,22 @@ +package model + +import "testing" + +func TestIsHysteria(t *testing.T) { + cases := []struct { + in Protocol + want bool + }{ + {Hysteria, true}, + {Hysteria2, true}, + {VLESS, false}, + {Shadowsocks, false}, + {Protocol(""), false}, + {Protocol("hysteria3"), false}, + } + for _, c := range cases { + if got := IsHysteria(c.in); got != c.want { + t.Errorf("IsHysteria(%q) = %v, want %v", c.in, got, c.want) + } + } +} -- cgit v1.2.3