fixed download attribute (Fix #734 Fix #733 Fix #725 Fix #724)

2 files changed, 4 insertions, 2 deletions

diff --git a/controller/editorapicontroller.php b/controller/editorapicontroller.php
index b8c2c7f..b7d6819 100644
--- a/controller/editorapicontroller.php
+++ b/controller/editorapicontroller.php
@@ -364,7 +364,8 @@ class EditorApiController extends OCSController {
             if (method_exists(IShare::class, "getAttributes")) {
                 $share = empty($share) ? $fileStorage->getShare() : $share;
                 $attributes = $share->getAttributes();
-                if ($attributes !== null && !$attributes->getAttribute("permissions", "download")) {
+                $downloadAttr = isset($attributes) ? $attributes->getAttribute("permissions", "download") : null;
+                if (isset($downloadAttr) && !$downloadAttr) {
                     $canDownload = false;
                 }
             }
diff --git a/controller/editorcontroller.php b/controller/editorcontroller.php
index 92e7b60..55bd84e 100644
--- a/controller/editorcontroller.php
+++ b/controller/editorcontroller.php
@@ -1053,7 +1053,8 @@ class EditorController extends Controller {
             if (method_exists(IShare::class, "getAttributes")) {
                 $share = empty($share) ? $fileStorage->getShare() : $share;
                 $attributes = $share->getAttributes();
-                if ($attributes !== null && !$attributes->getAttribute("permissions", "download")) {
+                $downloadAttr = isset($attributes) ? $attributes->getAttribute("permissions", "download") : null;
+                if (isset($downloadAttr) && !$downloadAttr) {
                     return $this->renderError($this->trans->t("Not permitted"));
                 }
             }