diff options
| author | Ilya Shipitsin <chipitsine@gmail.com> | 2016-04-29 22:03:35 +0300 |
|---|---|---|
| committer | Ilya Shipitsin <chipitsine@gmail.com> | 2016-04-29 22:03:35 +0300 |
| commit | 556ea647e346b0f30c0f79e7117566c4d58d55b0 (patch) | |
| tree | 324eab73b1e3997683d8e932275aa7b431faa7a1 | |
| parent | 84f95447a3eb7ab79f6d820d3f96ddf5bd4d05aa (diff) | |
cppcheck issues:
[src/Cedar/Virtual.c:2389] -> [src/Cedar/Virtual.c:2398]: (warning) Either the condition 'a==0' is redundant or there is possible null pointer dereference: a.
[src/Cedar/Virtual.c:4000] -> [src/Cedar/Virtual.c:4004]: (warning) Either the condition 'n==0' is redundant or there is possible null pointer dereference: n.
[src/Cedar/Virtual.c:4203] -> [src/Cedar/Virtual.c:4207]: (warning) Either the condition 'n==0' is redundant or there is possible null pointer dereference: n.
| -rw-r--r-- | src/Cedar/Virtual.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/Cedar/Virtual.c b/src/Cedar/Virtual.c index 2ce41b02..2133e5b1 100644 --- a/src/Cedar/Virtual.c +++ b/src/Cedar/Virtual.c @@ -2386,7 +2386,6 @@ bool NnTestConnectivity(NATIVE_STACK *a, TUBE *halt_tube) UINT64 next_send_tick = 0;
UINT64 giveup_time;
IPC *ipc;
- UINT src_port = NnGenSrcPort(a->IsIpRawMode);
INTERRUPT_MANAGER *interrupt;
TUBE *tubes[3];
UINT num_tubes = 0;
@@ -2399,6 +2398,7 @@ bool NnTestConnectivity(NATIVE_STACK *a, TUBE *halt_tube) {
return false;
}
+ UINT src_port = NnGenSrcPort(a->IsIpRawMode);
Copy(&using_dns, &a->DnsServerIP, sizeof(IP));
@@ -3997,7 +3997,6 @@ bool NatTransactIcmp(VH *v, NAT_ENTRY *n) void *buf;
UINT recv_size;
BLOCK *block;
- UINT dest_port = n->DestPort;
IP dest_ip;
UINT num_ignore_errors = 0;
// Validate arguments
@@ -4005,6 +4004,7 @@ bool NatTransactIcmp(VH *v, NAT_ENTRY *n) {
return true;
}
+ UINT dest_port = n->DestPort;
if (n->DisconnectNow)
{
@@ -4200,7 +4200,6 @@ bool NatTransactUdp(VH *v, NAT_ENTRY *n) void *buf;
UINT recv_size;
BLOCK *block;
- UINT dest_port = n->DestPort;
IP dest_ip;
UINT num_ignore_errors;
// Validate arguments
@@ -4208,6 +4207,7 @@ bool NatTransactUdp(VH *v, NAT_ENTRY *n) {
return true;
}
+ UINT dest_port = n->DestPort;
if (n->DisconnectNow)
{
|