Merge pull request #12394 from Ultimaker/PP-15-enable-skin-edge-support

PP-15-enable-skin-edge-support

9 files changed, 4 insertions, 10 deletions

diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json
index c411162359..6763cbb7f2 100644
--- a/resources/definitions/fdmprinter.def.json
+++ b/resources/definitions/fdmprinter.def.json
@@ -2256,7 +2256,7 @@
                     "maximum_value": "machine_height",
                     "maximum_value_warning": "resolveOrValue('infill_sparse_thickness') * 10",
                     "type": "float",
-                    "value": "0 if infill_sparse_density > 0 else 0",
+                    "value": "0",
                     "limit_to_extruder": "infill_extruder_nr",
                     "enabled": "infill_sparse_density > 0",
                     "settable_per_mesh": true,
diff --git a/resources/definitions/ultimaker.def.json b/resources/definitions/ultimaker.def.json
index 57de199011..8c6d8c0dda 100644
--- a/resources/definitions/ultimaker.def.json
+++ b/resources/definitions/ultimaker.def.json
@@ -104,6 +104,9 @@
         "acceleration_travel": {
             "value": "acceleration_wall"
         },
+        "skin_edge_support_thickness": {
+            "value": "4 * layer_height if infill_sparse_density < 30 else 0"
+        },
         "bridge_settings_enabled": {
             "value": false
         },
diff --git a/resources/quality/ultimaker_s3/um_s3_aa0.4_PLA_VeryDraft_Print.inst.cfg b/resources/quality/ultimaker_s3/um_s3_aa0.4_PLA_VeryDraft_Print.inst.cfg
index 0ce09d5812..62a5516b2c 100644
--- a/resources/quality/ultimaker_s3/um_s3_aa0.4_PLA_VeryDraft_Print.inst.cfg
+++ b/resources/quality/ultimaker_s3/um_s3_aa0.4_PLA_VeryDraft_Print.inst.cfg
@@ -33,7 +33,6 @@ material_shrinkage_percentage_z = 100.1
 
 prime_tower_enable = False
 retraction_prime_speed = =retraction_speed
-skin_edge_support_thickness = =0.9 if infill_sparse_density < 30 else 0
 skin_overlap = 20
 top_bottom_thickness = 0.9
 
diff --git a/resources/quality/ultimaker_s3/um_s3_aa0.4_TPLA_VeryDraft_Print.inst.cfg b/resources/quality/ultimaker_s3/um_s3_aa0.4_TPLA_VeryDraft_Print.inst.cfg
index 4bf6623cf6..50206224a9 100644
--- a/resources/quality/ultimaker_s3/um_s3_aa0.4_TPLA_VeryDraft_Print.inst.cfg
+++ b/resources/quality/ultimaker_s3/um_s3_aa0.4_TPLA_VeryDraft_Print.inst.cfg
@@ -33,7 +33,6 @@ material_shrinkage_percentage_z = 100.1
 
 prime_tower_enable = False
 retraction_prime_speed = =retraction_speed
-skin_edge_support_thickness = =0.9 if infill_sparse_density < 30 else 0
 skin_overlap = 20
 top_bottom_thickness = 1.2
 
diff --git a/resources/quality/ultimaker_s5/um_s5_aa0.4_CPE_Draft_Print.inst.cfg b/resources/quality/ultimaker_s5/um_s5_aa0.4_CPE_Draft_Print.inst.cfg
index b8a6fbc38a..bdfd6aadea 100644
--- a/resources/quality/ultimaker_s5/um_s5_aa0.4_CPE_Draft_Print.inst.cfg
+++ b/resources/quality/ultimaker_s5/um_s5_aa0.4_CPE_Draft_Print.inst.cfg
@@ -17,13 +17,11 @@ material_initial_print_temperature = =material_print_temperature - 5
 material_final_print_temperature = =material_print_temperature - 10
 retraction_combing_max_distance = 50
 retraction_prime_speed = =retraction_speed
-skin_edge_support_thickness = =0.8 if infill_sparse_density < 30 else 0
 skin_overlap = 20
 speed_print = 60
 speed_layer_0 = =math.ceil(speed_print * 20 / 60)
 speed_topbottom = =math.ceil(speed_print * 35 / 60)
 speed_wall = =math.ceil(speed_print * 45 / 60)
 speed_wall_0 = =math.ceil(speed_wall * 35 / 45)
-top_thickness = =0.8 if infill_sparse_density < 30 and skin_edge_support_thickness == 0.8 else top_bottom_thickness
 infill_pattern = ='zigzag' if infill_sparse_density > 80 else 'triangles'
 speed_infill = =math.ceil(speed_print * 50 / 60)
diff --git a/resources/quality/ultimaker_s5/um_s5_aa0.4_PETG_Draft_Print.inst.cfg b/resources/quality/ultimaker_s5/um_s5_aa0.4_PETG_Draft_Print.inst.cfg
index 78eda2718b..bedfaa177a 100644
--- a/resources/quality/ultimaker_s5/um_s5_aa0.4_PETG_Draft_Print.inst.cfg
+++ b/resources/quality/ultimaker_s5/um_s5_aa0.4_PETG_Draft_Print.inst.cfg
@@ -18,14 +18,12 @@ material_final_print_temperature = =material_print_temperature - 5
 material_shrinkage_percentage_xy = 100.5
 material_shrinkage_percentage_z = 100.1
 retraction_combing_max_distance = 8
-skin_edge_support_thickness = =0.8 if infill_sparse_density < 30 else 0
 skin_overlap = 20
 speed_print = 60
 speed_layer_0 = =math.ceil(speed_print * 20 / 60)
 speed_topbottom = =math.ceil(speed_print * 35 / 60)
 speed_wall = =math.ceil(speed_print * 45 / 60)
 speed_wall_0 = =math.ceil(speed_wall * 35 / 45)
-top_thickness = =0.8 if infill_sparse_density < 30 and skin_edge_support_thickness == 0.8 else top_bottom_thickness
 infill_pattern = ='zigzag' if infill_sparse_density > 80 else 'triangles'
 speed_infill = =math.ceil(speed_print * 50 / 60)
 initial_layer_line_width_factor = 100
diff --git a/resources/quality/ultimaker_s5/um_s5_aa0.4_PLA_Draft_Print.inst.cfg b/resources/quality/ultimaker_s5/um_s5_aa0.4_PLA_Draft_Print.inst.cfg
index a9e107d887..e85891cdc8 100644
--- a/resources/quality/ultimaker_s5/um_s5_aa0.4_PLA_Draft_Print.inst.cfg
+++ b/resources/quality/ultimaker_s5/um_s5_aa0.4_PLA_Draft_Print.inst.cfg
@@ -22,7 +22,6 @@ material_shrinkage_percentage_xy = 100.2
 material_shrinkage_percentage_z = 100.1
 prime_tower_enable = False
 retraction_prime_speed = =retraction_speed
-skin_edge_support_thickness = =0.8 if infill_sparse_density < 30 else 0
 skin_overlap = 20
 speed_layer_0 = 10
 speed_topbottom = =math.ceil(speed_print * 40 / 70)
diff --git a/resources/quality/ultimaker_s5/um_s5_aa0.4_PLA_VeryDraft_Print.inst.cfg b/resources/quality/ultimaker_s5/um_s5_aa0.4_PLA_VeryDraft_Print.inst.cfg
index 5087857b86..74161daa57 100644
--- a/resources/quality/ultimaker_s5/um_s5_aa0.4_PLA_VeryDraft_Print.inst.cfg
+++ b/resources/quality/ultimaker_s5/um_s5_aa0.4_PLA_VeryDraft_Print.inst.cfg
@@ -33,7 +33,6 @@ material_shrinkage_percentage_z = 100.1
 
 prime_tower_enable = False
 retraction_prime_speed = =retraction_speed
-skin_edge_support_thickness = =0.9 if infill_sparse_density < 30 else 0
 skin_overlap = 20
 top_bottom_thickness = 0.9
 
diff --git a/resources/quality/ultimaker_s5/um_s5_aa0.4_TPLA_VeryDraft_Print.inst.cfg b/resources/quality/ultimaker_s5/um_s5_aa0.4_TPLA_VeryDraft_Print.inst.cfg
index d3637ca861..48f65ed4da 100644
--- a/resources/quality/ultimaker_s5/um_s5_aa0.4_TPLA_VeryDraft_Print.inst.cfg
+++ b/resources/quality/ultimaker_s5/um_s5_aa0.4_TPLA_VeryDraft_Print.inst.cfg
@@ -33,7 +33,6 @@ material_shrinkage_percentage_z = 100.1
 
 prime_tower_enable = False
 retraction_prime_speed = =retraction_speed
-skin_edge_support_thickness = =0.9 if infill_sparse_density < 30 else 0
 skin_overlap = 20
 top_bottom_thickness = 1.2