diff options
author | Jelle Spijker <spijker.jelle@gmail.com> | 2021-12-03 19:41:29 +0300 |
---|---|---|
committer | Jelle Spijker <spijker.jelle@gmail.com> | 2021-12-03 19:41:29 +0300 |
commit | 8400459e212214637247445260cf5eeda99ed131 (patch) | |
tree | ed141468552d47ca5ffbddacd22717eb63f2aa9e /cura/CuraPackageManager.py | |
parent | c937337324427c3c3b2d897ceea9caf838271c0e (diff) |
Use Python syntax to check if item is in collection
Als removed the check on the first loop, because we know for certain these
will already be unique values.
Contributes to: CURA-8587
Diffstat (limited to 'cura/CuraPackageManager.py')
-rw-r--r-- | cura/CuraPackageManager.py | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/cura/CuraPackageManager.py b/cura/CuraPackageManager.py index 6c62442758..98e0e592aa 100644 --- a/cura/CuraPackageManager.py +++ b/cura/CuraPackageManager.py @@ -68,24 +68,22 @@ class CuraPackageManager(PackageManager): def iterateAllLocalPackages(self) -> Generator[Dict[str, Any], None, None]: """ A generator which returns an unordered list of all the PackageModels""" - handled_packages = set() + handled_packages = {} for packages in self.getAllInstalledPackagesInfo().values(): for package_info in packages: - if not handled_packages.__contains__(package_info["package_id"]): - handled_packages.add(package_info["package_id"]) - yield package_info + handled_packages.add(package_info["package_id"]) + yield package_info # Get all to be removed package_info's. These packages are still used in the current session so the user might # still want to interact with these. for package_data in self.getPackagesToRemove().values(): - for package_data in self.getPackagesToRemove().values(): - if not handled_packages.__contains__(package_data["package_info"]["package_id"]): + if not package_data["package_info"]["package_id"] in handled_packages: handled_packages.add(package_data["package_info"]["package_id"]) yield package_data["package_info"] # Get all to be installed package_info's. Since the user might want to interact with these for package_data in self.getPackagesToInstall().values(): - if not handled_packages.__contains__(package_data["package_info"]["package_id"]): + if not package_data["package_info"]["package_id"] in handled_packages: handled_packages.add(package_data["package_info"]["package_id"]) - yield package_data["package_info"]
\ No newline at end of file + yield package_data["package_info"] |