diff options
| author | Casper Lamboo <c.lamboo@ultimaker.com> | 2022-08-22 15:48:04 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-22 15:48:04 +0300 |
| commit | 35502e45faaa003419340347e7daa7df862415b6 (patch) | |
| tree | f1e394b642de6cef6ac74d827638d8ad443c9a04 /cura/Settings | |
| parent | 12f3581337b434f26e120ab08e0bccedbe253777 (diff) | |
Apply suggestions from code review
CURA-9277
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
Diffstat (limited to 'cura/Settings')
| -rw-r--r-- | cura/Settings/AbstractMachine.py | 6 | ||||
| -rw-r--r-- | cura/Settings/CuraContainerRegistry.py | 2 | ||||
| -rw-r--r-- | cura/Settings/CuraStackBuilder.py | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/cura/Settings/AbstractMachine.py b/cura/Settings/AbstractMachine.py index d3cae76ccb..3a8dbd54ea 100644 --- a/cura/Settings/AbstractMachine.py +++ b/cura/Settings/AbstractMachine.py @@ -24,11 +24,11 @@ class AbstractMachine(GlobalStack): ## private: -abstract_machine_mime = MimeType( +_abstract_machine_mime = MimeType( name = "application/x-cura-abstract-machine", comment = "Cura Abstract Machine", suffixes = ["global.cfg"] ) -MimeTypeDatabase.addMimeType(abstract_machine_mime) -ContainerRegistry.addContainerTypeByName(AbstractMachine, "abstract_machine", abstract_machine_mime.name) +MimeTypeDatabase.addMimeType(_abstract_machine_mime) +ContainerRegistry.addContainerTypeByName(AbstractMachine, "abstract_machine", _abstract_machine_mime.name) diff --git a/cura/Settings/CuraContainerRegistry.py b/cura/Settings/CuraContainerRegistry.py index 70d03b5ddc..1a711ef919 100644 --- a/cura/Settings/CuraContainerRegistry.py +++ b/cura/Settings/CuraContainerRegistry.py @@ -108,7 +108,7 @@ class CuraContainerRegistry(ContainerRegistry): :param container_type: :type{string} Type of the container (machine, quality, ...) :param container_name: :type{string} Name to check """ - container_class = ContainerStack if container_type in "machine" else InstanceContainer + container_class = ContainerStack if "machine" in container_type else InstanceContainer return self.findContainersMetadata(container_type = container_class, id = container_name, type = container_type, ignore_case = True) or \ self.findContainersMetadata(container_type = container_class, name = container_name, type = container_type) diff --git a/cura/Settings/CuraStackBuilder.py b/cura/Settings/CuraStackBuilder.py index 6a9ae728b7..1c55026dcf 100644 --- a/cura/Settings/CuraStackBuilder.py +++ b/cura/Settings/CuraStackBuilder.py @@ -290,7 +290,7 @@ class CuraStackBuilder: case []: # It should not be possible for the definition to be missing since an abstract machine will only # be created as a result of a machine with definition_id being created. - Logger.error("w", "Definition {definition} was not found!", definition=definition_id) + Logger.error(f"Definition {definition_id} was not found!") return None case [machine_definition, *_definitions]: machine_node = container_tree.machines[machine_definition.getId()] |