diff options
author | Casper Lamboo <c.lamboo@ultimaker.com> | 2022-04-29 11:30:11 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-29 11:30:11 +0300 |
commit | 784cd2c99b69b5ab1c05f9683515f7c4f51b4482 (patch) | |
tree | 2a48f81bf7c2cf6c924be91ce345bbd53facfe83 /resources/qml | |
parent | 8bb1b0bee80ad631294223d9df93dbcd1891bdf0 (diff) |
Apply suggestions from code review
Diffstat (limited to 'resources/qml')
-rw-r--r-- | resources/qml/Preferences/Materials/MaterialsPage.qml | 2 | ||||
-rw-r--r-- | resources/qml/Preferences/ProfilesPage.qml | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/resources/qml/Preferences/Materials/MaterialsPage.qml b/resources/qml/Preferences/Materials/MaterialsPage.qml index b5d6ee464e..22f8091314 100644 --- a/resources/qml/Preferences/Materials/MaterialsPage.qml +++ b/resources/qml/Preferences/Materials/MaterialsPage.qml @@ -259,7 +259,7 @@ UM.ManagementPage currentFolder: CuraApplication.getDefaultPath("dialog_material_path") onAccepted: { - var nameFilterString = selectedNameFilter.index >= 0 ? nameFilters[selectedNameFilter.index] : nameFilters[0] + const nameFilterString = selectedNameFilter.index >= 0 ? nameFilters[selectedNameFilter.index] : nameFilters[0]; const result = Cura.ContainerManager.exportContainer(base.currentItem.root_material_id, nameFilterString, selectedFile); diff --git a/resources/qml/Preferences/ProfilesPage.qml b/resources/qml/Preferences/ProfilesPage.qml index bbc1afb825..2a7c50fe59 100644 --- a/resources/qml/Preferences/ProfilesPage.qml +++ b/resources/qml/Preferences/ProfilesPage.qml @@ -357,7 +357,7 @@ UM.ManagementPage // If nameFilters contains only 1 item, the index of selectedNameFilter will always be -1 // This fetches the nameFilter at index selectedNameFilter.index if it is positive - var nameFilterString = selectedNameFilter.index >= 0 ? nameFilters[selectedNameFilter.index] : nameFilters[0] + const nameFilterString = selectedNameFilter.index >= 0 ? nameFilters[selectedNameFilter.index] : nameFilters[0]; var result = Cura.ContainerManager.exportQualityChangesGroup(base.currentItem.quality_changes_group, selectedFile, nameFilterString); |