diff options
author | Stefan Seelmann <mail@stefan-seelmann.de> | 2021-05-02 21:21:41 +0300 |
---|---|---|
committer | Stefan Seelmann <mail@stefan-seelmann.de> | 2021-05-02 21:21:41 +0300 |
commit | 005f3f3e800c2e8490a1915660ada70998d4245a (patch) | |
tree | fac5ec096db4f1ece0e471f89881514360d207ff | |
parent | 059bb826a0f21ead68b08aeabf02e42318de817c (diff) |
Replace assertions
23 files changed, 86 insertions, 85 deletions
diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ApacheDSPluginTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ApacheDSPluginTest.java index 362ecc33f..6b627c8cb 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ApacheDSPluginTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ApacheDSPluginTest.java @@ -23,9 +23,9 @@ package org.apache.directory.studio.test.integration.ui; import static org.hamcrest.CoreMatchers.containsString; import static org.hamcrest.MatcherAssert.assertThat; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.directory.studio.connection.core.Connection; import org.apache.directory.studio.connection.core.ConnectionCorePlugin; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/BrowserTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/BrowserTest.java index a420500d6..05d110df6 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/BrowserTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/BrowserTest.java @@ -38,9 +38,9 @@ import static org.apache.directory.studio.test.integration.junit5.TestFixture.US import static org.apache.directory.studio.test.integration.junit5.TestFixture.USER3_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.USERS_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.dn; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; import java.util.List; import java.util.concurrent.atomic.AtomicInteger; @@ -110,7 +110,7 @@ public class BrowserTest extends AbstractTestBase text = searchLogsViewBot.getSearchLogsText(); int countMatchesAfter = StringUtils.countMatches( text, "#!SEARCH REQUEST" ); - assertEquals( "Expected exactly 1 search request", 1, countMatchesAfter - countMatchesBefore ); + assertEquals( 1, countMatchesAfter - countMatchesBefore, "Expected exactly 1 search request" ); assertEquals( "No modification expected", "", modificationLogsViewBot.getModificationLogsText() ); } @@ -151,7 +151,7 @@ public class BrowserTest extends AbstractTestBase // verify that only two events were fired during deletion long fireCount = fireCount1 - fireCount0; - assertEquals( "Only 2 event firings expected when deleting multiple entries.", 2, fireCount ); + assertEquals( 2, fireCount, "Only 2 event firings expected when deleting multiple entries." ); } @@ -679,7 +679,7 @@ public class BrowserTest extends AbstractTestBase browserViewBot.selectEntry( path( USER3_DN ) ); // verify that input was only set 3 times. - assertEquals( "Only 3 input changes expected.", 3, counter.get() ); + assertEquals( 3, counter.get(), "Only 3 input changes expected." ); // reset counter counter.set( 0 ); @@ -695,7 +695,7 @@ public class BrowserTest extends AbstractTestBase browserViewBot.waitUntilEntryIsSelected( USER3_DN.getRdn().getName() ); // verify that input was only set 4 times. - assertEquals( "Only 4 input changes expected.", 4, counter.get() ); + assertEquals( 4, counter.get(), "Only 4 input changes expected." ); } diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/CertificateValidationTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/CertificateValidationTest.java index e599e2da5..03e793c6f 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/CertificateValidationTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/CertificateValidationTest.java @@ -24,10 +24,10 @@ package org.apache.directory.studio.test.integration.ui; import static org.apache.directory.studio.test.integration.ui.Constants.LOCALHOST; import static org.hamcrest.CoreMatchers.containsString; import static org.hamcrest.MatcherAssert.assertThat; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNull; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertTrue; import java.io.File; import java.io.FileOutputStream; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ConnectionViewTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ConnectionViewTest.java index f115fef4e..af91b22ae 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ConnectionViewTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ConnectionViewTest.java @@ -21,7 +21,7 @@ package org.apache.directory.studio.test.integration.ui; -import static org.junit.Assert.assertEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; import java.net.URL; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/CopyEntryTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/CopyEntryTest.java index e34ffb509..7da7a451c 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/CopyEntryTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/CopyEntryTest.java @@ -29,8 +29,8 @@ import static org.apache.directory.studio.test.integration.junit5.TestFixture.SU import static org.apache.directory.studio.test.integration.junit5.TestFixture.USER1_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.USERS_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.dn; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.directory.api.ldap.model.name.Dn; import org.apache.directory.studio.connection.core.Connection; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java index 24c230778..e0badbd10 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java @@ -28,10 +28,10 @@ import static org.apache.directory.studio.test.integration.junit5.TestFixture.MU import static org.apache.directory.studio.test.integration.junit5.TestFixture.USER1_DN; import static org.hamcrest.CoreMatchers.startsWith; import static org.hamcrest.MatcherAssert.assertThat; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNull; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.commons.lang3.ArrayUtils; import org.apache.commons.lang3.RandomStringUtils; @@ -148,8 +148,8 @@ public class EntryEditorTest extends AbstractTestBase assertFalse( entryEditorBot.getAttributeValues().contains( "description: This is the final description." ) ); modificationLogsViewBot.waitForText( "delete: description\ndescription: This is the final description.\n-" ); - assertEquals( "Expected 6 modifications.", 6, - StringUtils.countMatches( modificationLogsViewBot.getModificationLogsText(), "#!RESULT OK" ) ); + assertEquals( 6, StringUtils.countMatches( modificationLogsViewBot.getModificationLogsText(), "#!RESULT OK" ), + "Expected 6 modifications." ); } @@ -235,8 +235,8 @@ public class EntryEditorTest extends AbstractTestBase .waitForText( "delete: facsimileTelephoneNumber\nfacsimileTelephoneNumber: 000000000000\n-" ); } - assertEquals( "Expected 3 modifications.", 3, - StringUtils.countMatches( modificationLogsViewBot.getModificationLogsText(), "#!RESULT OK" ) ); + assertEquals( 3, StringUtils.countMatches( modificationLogsViewBot.getModificationLogsText(), "#!RESULT OK" ), + "Expected 3 modifications." ); } @@ -329,8 +329,8 @@ public class EntryEditorTest extends AbstractTestBase dnEditorBot.clickCancelButton(); modificationLogsViewBot.waitForText( "#!RESULT OK" ); - assertEquals( "Expected 1 modification.", 1, - StringUtils.countMatches( modificationLogsViewBot.getModificationLogsText(), "#!RESULT OK" ) ); + assertEquals( 1, StringUtils.countMatches( modificationLogsViewBot.getModificationLogsText(), "#!RESULT OK" ), + "Expected 1 modification." ); } @@ -363,13 +363,13 @@ public class EntryEditorTest extends AbstractTestBase // assert pasted value visible in editor assertEquals( 24, entryEditorBot.getAttributeValues().size() ); - assertTrue( "Should contain uid=bjensen: " + entryEditorBot.getAttributeValues(), - entryEditorBot.getAttributeValues().contains( "uid: bjensen" ) ); + assertTrue( entryEditorBot.getAttributeValues().contains( "uid: bjensen" ), + "Should contain uid=bjensen: " + entryEditorBot.getAttributeValues() ); // assert pasted value was written to directory server.withAdminConnection( conn -> { Entry entry = conn.lookup( USER1_DN ); - assertTrue( "Should contain uid=bjensen: " + entry, entry.contains( "uid", "bjensen" ) ); + assertTrue( entry.contains( "uid", "bjensen" ), "Should contain uid=bjensen: " + entry ); } ); } @@ -409,10 +409,10 @@ public class EntryEditorTest extends AbstractTestBase // assert pasted values were written to directory server.withAdminConnection( conn -> { Entry entry = conn.lookup( USER1_DN ); - assertTrue( "Should contain uid=hnelson: " + entry, entry.contains( "uid", "hnelson" ) ); - assertTrue( "Should contain description: " + entry, entry.contains( "description", Characters.ALL ) ); - assertTrue( "Should contain userPassword: " + entry, entry.containsAttribute( "userPassword" ) ); - assertTrue( "Should contain jpegPhoto: " + entry, entry.containsAttribute( "jpegPhoto" ) ); + assertTrue( entry.contains( "uid", "hnelson" ), "Should contain uid=hnelson: " + entry ); + assertTrue( entry.contains( "description", Characters.ALL ), "Should contain description: " + entry ); + assertTrue( entry.containsAttribute( "userPassword" ), "Should contain userPassword: " + entry ); + assertTrue( entry.containsAttribute( "jpegPhoto" ), "Should contain jpegPhoto: " + entry ); } ); } diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ExtendedOperationsTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ExtendedOperationsTest.java index 71ccdce5e..325e6b438 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ExtendedOperationsTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ExtendedOperationsTest.java @@ -24,10 +24,10 @@ package org.apache.directory.studio.test.integration.ui; import static org.apache.directory.studio.test.integration.junit5.TestFixture.USER1_DN; import static org.hamcrest.CoreMatchers.containsString; import static org.hamcrest.MatcherAssert.assertThat; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNull; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.commons.lang3.RandomStringUtils; import org.apache.directory.studio.test.integration.junit5.LdapServerType; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/GssApiTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/GssApiTest.java index b90d2fe53..57dfa457b 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/GssApiTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/GssApiTest.java @@ -22,8 +22,8 @@ package org.apache.directory.studio.test.integration.ui; import static org.apache.directory.studio.test.integration.ui.Constants.LOCALHOST; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertNull; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; import java.io.File; import java.io.IOException; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ImportExportTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ImportExportTest.java index 41c008526..91c4f64ef 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ImportExportTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ImportExportTest.java @@ -34,9 +34,9 @@ import static org.apache.directory.studio.test.integration.junit5.TestFixture.dn import static org.hamcrest.CoreMatchers.containsString; import static org.hamcrest.CoreMatchers.not; import static org.hamcrest.MatcherAssert.assertThat; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; import java.io.File; import java.io.IOException; @@ -167,8 +167,8 @@ public class ImportExportTest extends AbstractTestBase // verify that exported DSML contains the Base64 encoded DN String content = FileUtils.readFileToString( new File( file ), StandardCharsets.UTF_8 ); - assertTrue( "DSML must contain DN with umlaut.", - content.contains( "dn=\"" + GERMAN_UMLAUT_DN.getName() + "\"" ) ); + assertTrue( content.contains( "dn=\"" + GERMAN_UMLAUT_DN.getName() + "\"" ), + "DSML must contain DN with umlaut." ); // delete entry DeleteDialogBot dialogBot = browserViewBot.openDeleteDialog(); @@ -606,7 +606,7 @@ public class ImportExportTest extends AbstractTestBase // verify that only three two events were fired between Import long fireCount = fireCount1 - fireCount0; - assertEquals( "Only 2 event firings expected when importing LDIF.", 2, fireCount ); + assertEquals( 2, fireCount, "Only 2 event firings expected when importing LDIF." ); } diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/LdifEditorTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/LdifEditorTest.java index 50e63e249..5f69391c5 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/LdifEditorTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/LdifEditorTest.java @@ -21,7 +21,7 @@ package org.apache.directory.studio.test.integration.ui; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.directory.studio.test.integration.ui.bots.LdifEditorBot; import org.apache.directory.studio.test.integration.ui.bots.NewWizardBot; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/MoveEntryTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/MoveEntryTest.java index e0b907da9..7719c3a72 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/MoveEntryTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/MoveEntryTest.java @@ -27,9 +27,9 @@ import static org.apache.directory.studio.test.integration.junit5.TestFixture.MI import static org.apache.directory.studio.test.integration.junit5.TestFixture.MISC_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.DN_WITH_ESCAPED_CHARACTERS_BACKSLASH_PREFIXED; import static org.apache.directory.studio.test.integration.junit5.TestFixture.DN_WITH_ESCAPED_CHARACTERS_HEX_PAIR_ESCAPED; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.commons.lang3.ArrayUtils; import org.apache.directory.api.ldap.model.name.Dn; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/NewConnectionWizardTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/NewConnectionWizardTest.java index 6576d8b4d..369c876c0 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/NewConnectionWizardTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/NewConnectionWizardTest.java @@ -24,11 +24,11 @@ package org.apache.directory.studio.test.integration.ui; import static org.hamcrest.CoreMatchers.anyOf; import static org.hamcrest.CoreMatchers.containsString; import static org.hamcrest.MatcherAssert.assertThat; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertNull; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertTrue; import java.lang.reflect.Method; import java.net.InetAddress; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/NewEntryWizardTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/NewEntryWizardTest.java index f45b5672e..328aa5427 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/NewEntryWizardTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/NewEntryWizardTest.java @@ -26,9 +26,9 @@ import static org.apache.directory.studio.test.integration.junit5.TestFixture.RE import static org.apache.directory.studio.test.integration.junit5.TestFixture.TARGET_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.USER1_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.dn; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.directory.studio.connection.core.Connection; import org.apache.directory.studio.connection.core.Connection.AliasDereferencingMethod; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/PreferencesTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/PreferencesTest.java index c02a85f74..60c7bee37 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/PreferencesTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/PreferencesTest.java @@ -21,9 +21,9 @@ package org.apache.directory.studio.test.integration.ui; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; import java.io.File; import java.net.URL; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/RcpAppTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/RcpAppTest.java index a926baf5c..b856742ae 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/RcpAppTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/RcpAppTest.java @@ -21,9 +21,9 @@ package org.apache.directory.studio.test.integration.ui; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.directory.studio.test.integration.ui.bots.ExportWizardBot; import org.apache.directory.studio.test.integration.ui.bots.ImportWizardBot; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ReferralDialogTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ReferralDialogTest.java index 436e8f0d7..65dcee372 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ReferralDialogTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ReferralDialogTest.java @@ -32,9 +32,9 @@ import static org.apache.directory.studio.test.integration.junit5.TestFixture.RE import static org.apache.directory.studio.test.integration.junit5.TestFixture.REFERRAL_TO_USERS_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.USER1_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.USERS_DN; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.directory.studio.connection.core.Connection; import org.apache.directory.studio.connection.core.Connection.ReferralHandlingMethod; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/RenameEntryTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/RenameEntryTest.java index 9b2a77900..f4f44df13 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/RenameEntryTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/RenameEntryTest.java @@ -27,8 +27,8 @@ import static org.apache.directory.studio.test.integration.junit5.TestFixture.MU import static org.apache.directory.studio.test.integration.junit5.TestFixture.DN_WITH_ESCAPED_CHARACTERS_BACKSLASH_PREFIXED; import static org.apache.directory.studio.test.integration.junit5.TestFixture.DN_WITH_ESCAPED_CHARACTERS_HEX_PAIR_ESCAPED; import static org.apache.directory.studio.test.integration.junit5.TestFixture.dn; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.directory.api.ldap.model.name.Ava; import org.apache.directory.api.ldap.model.name.Dn; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SchemaBrowserTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SchemaBrowserTest.java index 9afe9b849..2dae64c1f 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SchemaBrowserTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SchemaBrowserTest.java @@ -24,8 +24,8 @@ package org.apache.directory.studio.test.integration.ui; import static org.apache.directory.studio.test.integration.junit5.TestFixture.USER1_DN; import static org.hamcrest.CoreMatchers.containsString; import static org.hamcrest.MatcherAssert.assertThat; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.directory.studio.connection.core.Connection; import org.apache.directory.studio.ldapbrowser.core.BrowserCorePlugin; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SchemaEditorTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SchemaEditorTest.java index 89323d538..cc45e26cb 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SchemaEditorTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SchemaEditorTest.java @@ -24,8 +24,8 @@ package org.apache.directory.studio.test.integration.ui; import static org.hamcrest.CoreMatchers.containsString; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.MatcherAssert.assertThat; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; import java.util.List; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SearchTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SearchTest.java index e155e221e..72401697d 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SearchTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SearchTest.java @@ -33,9 +33,9 @@ import static org.apache.directory.studio.test.integration.junit5.TestFixture.SU import static org.apache.directory.studio.test.integration.junit5.TestFixture.USER1_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.USER8_DN; import static org.apache.directory.studio.test.integration.junit5.TestFixture.USERS_DN; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.apache.commons.lang3.StringUtils; import org.apache.directory.api.ldap.model.message.ModifyRequest; @@ -146,7 +146,7 @@ public class SearchTest extends AbstractTestBase // verify that only one event was fired long fireCount = fireCount1 - fireCount0; - assertEquals( "Only 1 event firings expected when running quick search.", 1, fireCount ); + assertEquals( 1, fireCount, "Only 1 event firings expected when running quick search." ); } diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SwtResourcesTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SwtResourcesTest.java index fa9f78605..d524c4e5c 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SwtResourcesTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/SwtResourcesTest.java @@ -23,8 +23,8 @@ package org.apache.directory.studio.test.integration.ui; import static org.apache.directory.studio.test.integration.junit5.TestFixture.MISC_DN; -import static org.junit.Assert.assertTrue; -import static org.junit.Assert.fail; +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.fail; import org.apache.directory.studio.test.integration.junit5.LdapServerType; import org.apache.directory.studio.test.integration.junit5.LdapServersSource; @@ -75,8 +75,9 @@ public class SwtResourcesTest extends AbstractTestBase int afterObjectCount = getSwtObjectCount(); // we expect none or only very few additional SWT objects - assertTrue( "Too many SWT resources were allocated in testSwtResourcesDelta: before=" + beforeObjectCount - + ", after=" + afterObjectCount, afterObjectCount - beforeObjectCount < 5 ); + assertTrue( afterObjectCount - beforeObjectCount < 5, + "Too many SWT resources were allocated in testSwtResourcesDelta: before=" + beforeObjectCount + + ", after=" + afterObjectCount ); } @@ -91,7 +92,7 @@ public class SwtResourcesTest extends AbstractTestBase connectionsViewBot.createTestConnection( server ); int swtObjectCount = getSwtObjectCount(); System.out.println( "### SWT resouces count: " + swtObjectCount ); - assertTrue( "Too many SWT resources were allocated: " + swtObjectCount, swtObjectCount < 1500 ); + assertTrue( swtObjectCount < 1500, "Too many SWT resources were allocated: " + swtObjectCount ); } diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ValueEditorTest.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ValueEditorTest.java index 5a4f38459..ac394d5dc 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ValueEditorTest.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/ValueEditorTest.java @@ -23,8 +23,8 @@ package org.apache.directory.studio.test.integration.ui; import static java.nio.charset.StandardCharsets.ISO_8859_1; import static java.nio.charset.StandardCharsets.UTF_8; -import static org.junit.Assert.assertArrayEquals; -import static org.junit.Assert.assertEquals; +import static org.junit.jupiter.api.Assertions.assertArrayEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; import java.nio.charset.StandardCharsets; import java.util.stream.Stream; diff --git a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/bots/utils/Assertions.java b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/bots/utils/Assertions.java index 0bbc59932..8662952d0 100644 --- a/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/bots/utils/Assertions.java +++ b/tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/bots/utils/Assertions.java @@ -20,7 +20,7 @@ package org.apache.directory.studio.test.integration.ui.bots.utils; -import static org.junit.Assert.fail; +import static org.junit.jupiter.api.Assertions.fail; import org.apache.directory.studio.connection.core.Messages; import org.apache.directory.studio.test.integration.ui.bots.BotUtils; |