diff options
| author | Jim Brandt <jbrandt@bestpractical.com> | 2022-08-22 15:46:49 +0300 |
|---|---|---|
| committer | Jim Brandt <jbrandt@bestpractical.com> | 2022-08-22 15:46:49 +0300 |
| commit | 596720497cbb805b7864d8267cef91b5eedda492 (patch) | |
| tree | 7d999f6f58a8b75af326b351482930de6e3c3276 | |
| parent | 2867592b3fd43c9127d57a1d9ac4093df20f1dd3 (diff) | |
Restore the github actions always() for slack notifications
The always() is needed for slack notifications also or
test failures are not reported. The previous setting was
removed as part of adding the conditional to report to
slack only when running in the bestpractical account
in 8f5e4915.
| -rw-r--r-- | .github/workflows/github-action.yml | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/.github/workflows/github-action.yml b/.github/workflows/github-action.yml index e13bd3fcaf..f3d514c8bd 100644 --- a/.github/workflows/github-action.yml +++ b/.github/workflows/github-action.yml @@ -44,7 +44,7 @@ jobs: export RT_GA_TEST_TIME=$(date -u -d @"$RT_GA_TEST_TIME" +"%T") echo "RT_GA_TEST_TIME=$RT_GA_TEST_TIME" >> $GITHUB_ENV - name: Post results to Slack - if: ${{ github.repository_owner == 'bestpractical' }} + if: ${{ always() && github.repository_owner == 'bestpractical' }} uses: edge/simple-slack-notify@v1.1.1 env: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_NOTIFICATIONS }} @@ -97,7 +97,7 @@ jobs: export RT_GA_TEST_TIME=$(date -u -d @"$RT_GA_TEST_TIME" +"%T") echo "RT_GA_TEST_TIME=$RT_GA_TEST_TIME" >> $GITHUB_ENV - name: Post results to Slack - if: ${{ github.repository_owner == 'bestpractical' }} + if: ${{ always() && github.repository_owner == 'bestpractical' }} uses: edge/simple-slack-notify@v1.1.1 env: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_NOTIFICATIONS }} @@ -151,7 +151,7 @@ jobs: export RT_GA_TEST_TIME=$(date -u -d @"$RT_GA_TEST_TIME" +"%T") echo "RT_GA_TEST_TIME=$RT_GA_TEST_TIME" >> $GITHUB_ENV - name: Post results to Slack - if: ${{ github.repository_owner == 'bestpractical' }} + if: ${{ always() && github.repository_owner == 'bestpractical' }} uses: edge/simple-slack-notify@v1.1.1 env: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_NOTIFICATIONS }} |