Remove attachment/filename icons from transactions5.0/remove-attachment-and-filename-icons

This commit removes the filename and attachment icons from ticket
history transactions, as well as cleanup the styling to fix the
alignment overlap in light and dark theme.

3 files changed, 8 insertions, 22 deletions

diff --git a/share/html/Elements/ShowTransactionAttachments b/share/html/Elements/ShowTransactionAttachments
index b87a516c5e..003aec5908 100644
--- a/share/html/Elements/ShowTransactionAttachments
+++ b/share/html/Elements/ShowTransactionAttachments
@@ -69,25 +69,17 @@ foreach my $message ( @{ $Attachments->{ $Parent || 0 } || [] } ) {
 <a href="<% $AttachmentPath %>/<% $Transaction->Id %>/<% $message->Id %>/<% $name | un %>" target="_blank"
 % }
 % if ( length $name ) {  # download link with filename
-% my $download_alt = loc( 'Download [_1] [_2]', $message->ContentType, $message->FriendlyContentLength );
-alt="<% $download_alt %>" data-toggle="tooltip" data-placement="bottom" data-original-title="<% $download_alt %>">
-  <span class="fas fa-paperclip fa-2x"></span>
+% my $download_tooltip = loc( 'Download [_1] [_2]', $message->ContentType, $message->FriendlyContentLength );
+data-toggle="tooltip" data-placement="bottom" data-original-title="<% $download_tooltip %>">
   <span class="downloadfilename"><% $name %></span>
 </a>
 % }
 % else {  # view source and view source headers, without filename or size
-% my $view_source_alt = loc( 'View source' );
->
-  <span class="far fa-file fa-2x" alt="<% $view_source_alt %>" data-toggle="tooltip" data-placement="bottom" data-original-title="<% $view_source_alt %>"></span>
-</a>
+% my $view_source_text = loc( 'View source' );
+><% $view_source_text %></a>
 % if ( $DownloadableHeaders && ! length $name && $message->ContentType =~ /text/  ) {
-% my $download_with_headers_alt = loc('View source with headers');
-<a href="<% $AttachmentPath %>/WithHeaders/<% $message->Id %>" target="_blank">
-  <span class="fa-stack" alt="<% $download_with_headers_alt %>" data-toggle="tooltip" data-placement="bottom" data-original-title="<% $download_with_headers_alt %>">
-    <i class="far fa-file fa-stack-2x"></i>
-    <i class="fas fa-plus fa-stack-1x"></i>
-  </span>
-</a>
+% my $download_with_headers_text = loc('with headers');
+<a href="<% $AttachmentPath %>/WithHeaders/<% $message->Id %>" target="_blank">(<% $download_with_headers_text %>)</a>
 % }
 % }
 % $m->callback(CallbackName => 'AfterDownloadLinks', ARGSRef => \%ARGS, Object => $Object, Transaction => $Transaction, Attachment => $message);
diff --git a/share/static/css/elevator-dark/main.css b/share/static/css/elevator-dark/main.css
index 7ea673931b..6e9c9ac2de 100644
--- a/share/static/css/elevator-dark/main.css
+++ b/share/static/css/elevator-dark/main.css
@@ -261,11 +261,6 @@
     background: rgba(255, 255, 255, 0) !important;
 }
 
-.darkmode .transaction table + div.downloadattachment {
-    position: relative;
-    top: 0.6em;
-}
-
 .darkmode svg.icon-bordered {
     border: solid 0.05em #717171;
 }
diff --git a/share/static/css/elevator-light/history.css b/share/static/css/elevator-light/history.css
index 296b425435..8da6188186 100644
--- a/share/static/css/elevator-light/history.css
+++ b/share/static/css/elevator-light/history.css
@@ -148,9 +148,9 @@ float: right;
 clear: both;
 font-size: 0.9em;
 text-align: right;
-background: transparent;
+background: transparent !important;
 padding: 0.5em;
-padding-top: 0.5em;
+padding-top: 0.75em;
 margin-left: 1em;
 
 border: none;
@@ -163,7 +163,6 @@ border: none;
 
 .transaction div.downloadattachment a {
   color: #aaa;
-  font-size: 0.7em;
   vertical-align: top;
 }