Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/certbot/certbot.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMads Jensen <mje@inducks.org>2022-01-10 00:50:44 +0300
committerGitHub <noreply@github.com>2022-01-10 00:50:44 +0300
commit7e5e51aeff46d5cda0ee92f64b9ba4b5058f5dd7 (patch)
treebdb0be0757d76088e7001f63f2b7a21294bafe98
parented7964b424345b5d8ad98335be8f98d5c21059a6 (diff)
Use super().__init__ instead of explicitly calling named super-class. (#9166)
* Use super().__init__ instead of explicitly calling named super-class. * Fix unittest (typo fix).
-rw-r--r--acme/acme/standalone.py15
-rw-r--r--acme/tests/standalone_test.py4
-rw-r--r--certbot-nginx/certbot_nginx/_internal/nginxparser.py2
-rw-r--r--certbot/certbot/_internal/error_handler.py3
-rw-r--r--certbot/tests/plugins/dns_common_test.py2
5 files changed, 12 insertions, 14 deletions
diff --git a/acme/acme/standalone.py b/acme/acme/standalone.py
index cd2caa221..5dfb27136 100644
--- a/acme/acme/standalone.py
+++ b/acme/acme/standalone.py
@@ -34,10 +34,9 @@ class TLSServer(socketserver.TCPServer):
else:
self.address_family = socket.AF_INET
self.certs = kwargs.pop("certs", {})
- self.method = kwargs.pop(
- "method", crypto_util._DEFAULT_SSL_METHOD)
+ self.method = kwargs.pop("method", crypto_util._DEFAULT_SSL_METHOD)
self.allow_reuse_address = kwargs.pop("allow_reuse_address", True)
- socketserver.TCPServer.__init__(self, *args, **kwargs)
+ super().__init__(*args, **kwargs)
def _wrap_sock(self) -> None:
self.socket = crypto_util.SSLSocket(
@@ -190,7 +189,7 @@ class HTTPServer(BaseHTTPServer.HTTPServer):
self.address_family = socket.AF_INET6
else:
self.address_family = socket.AF_INET
- BaseHTTPServer.HTTPServer.__init__(self, *args, **kwargs)
+ super().__init__(*args, **kwargs)
class HTTP01Server(HTTPServer, ACMEServerMixin):
@@ -198,8 +197,8 @@ class HTTP01Server(HTTPServer, ACMEServerMixin):
def __init__(self, server_address: Tuple[str, int], resources: Set[challenges.HTTP01],
ipv6: bool = False, timeout: int = 30) -> None:
- HTTPServer.__init__(
- self, server_address, HTTP01RequestHandler.partial_init(
+ super().__init__(
+ server_address, HTTP01RequestHandler.partial_init(
simple_http_resources=resources, timeout=timeout), ipv6=ipv6)
@@ -208,7 +207,7 @@ class HTTP01DualNetworkedServers(BaseDualNetworkedServers):
affect the other."""
def __init__(self, *args: Any, **kwargs: Any) -> None:
- BaseDualNetworkedServers.__init__(self, HTTP01Server, *args, **kwargs)
+ super().__init__(HTTP01Server, *args, **kwargs)
class HTTP01RequestHandler(BaseHTTPServer.BaseHTTPRequestHandler):
@@ -226,7 +225,7 @@ class HTTP01RequestHandler(BaseHTTPServer.BaseHTTPRequestHandler):
def __init__(self, *args: Any, **kwargs: Any) -> None:
self.simple_http_resources = kwargs.pop("simple_http_resources", set())
self._timeout = kwargs.pop('timeout', 30)
- BaseHTTPServer.BaseHTTPRequestHandler.__init__(self, *args, **kwargs)
+ super().__init__(*args, **kwargs)
self.server: HTTP01Server
# In parent class BaseHTTPRequestHandler, 'timeout' is a class-level property but we
diff --git a/acme/tests/standalone_test.py b/acme/tests/standalone_test.py
index e0aa5aa22..ad5751fcf 100644
--- a/acme/tests/standalone_test.py
+++ b/acme/tests/standalone_test.py
@@ -165,7 +165,6 @@ class TLSALPN01ServerTest(unittest.TestCase):
class BaseDualNetworkedServersTest(unittest.TestCase):
"""Test for acme.standalone.BaseDualNetworkedServers."""
-
class SingleProtocolServer(socketserver.TCPServer):
"""Server that only serves on a single protocol. FreeBSD has this behavior for AF_INET6."""
def __init__(self, *args, **kwargs):
@@ -175,7 +174,7 @@ class BaseDualNetworkedServersTest(unittest.TestCase):
kwargs["bind_and_activate"] = False
else:
self.address_family = socket.AF_INET
- socketserver.TCPServer.__init__(self, *args, **kwargs)
+ super().__init__(*args, **kwargs)
if ipv6:
# NB: On Windows, socket.IPPROTO_IPV6 constant may be missing.
# We use the corresponding value (41) instead.
@@ -202,7 +201,6 @@ class BaseDualNetworkedServersTest(unittest.TestCase):
self.assertEqual(em.exception.errno, EADDRINUSE)
-
def test_ports_equal(self):
from acme.standalone import BaseDualNetworkedServers
servers = BaseDualNetworkedServers(
diff --git a/certbot-nginx/certbot_nginx/_internal/nginxparser.py b/certbot-nginx/certbot_nginx/_internal/nginxparser.py
index 2aa677c38..03aa88db4 100644
--- a/certbot-nginx/certbot_nginx/_internal/nginxparser.py
+++ b/certbot-nginx/certbot_nginx/_internal/nginxparser.py
@@ -118,7 +118,7 @@ class UnspacedList(list):
# Turn self into a version of the source list that has spaces removed
# and all sub-lists also UnspacedList()ed
- list.__init__(self, list_source)
+ super().__init__(list_source)
for i, entry in reversed(list(enumerate(self))):
if isinstance(entry, list):
sublist = UnspacedList(entry)
diff --git a/certbot/certbot/_internal/error_handler.py b/certbot/certbot/_internal/error_handler.py
index 0e63d02de..24ab46d9d 100644
--- a/certbot/certbot/_internal/error_handler.py
+++ b/certbot/certbot/_internal/error_handler.py
@@ -167,6 +167,7 @@ class ErrorHandler:
logger.debug("Calling signal %s", signum)
os.kill(os.getpid(), signum)
+
class ExitHandler(ErrorHandler):
"""Context manager for running code that must be cleaned up.
@@ -175,5 +176,5 @@ class ExitHandler(ErrorHandler):
regular exit.
"""
def __init__(self, func: Callable[..., Any], *args: Any, **kwargs: Any) -> None:
- ErrorHandler.__init__(self, func, *args, **kwargs)
+ super().__init__(func, *args, **kwargs)
self.call_on_regular_exit = True
diff --git a/certbot/tests/plugins/dns_common_test.py b/certbot/tests/plugins/dns_common_test.py
index 41117f894..f68d36137 100644
--- a/certbot/tests/plugins/dns_common_test.py
+++ b/certbot/tests/plugins/dns_common_test.py
@@ -133,7 +133,7 @@ class CredentialsConfigurationTest(test_util.TempDirTestCase):
def __init__(self, *args, **kwargs):
self.reset()
- logging.Handler.__init__(self, *args, **kwargs)
+ super().__init__(*args, **kwargs)
def emit(self, record):
self.messages[record.levelname.lower()].append(record.getMessage())