Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/certbot/certbot.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdrien Ferrand <adferrand@users.noreply.github.com>2020-02-14 00:56:16 +0300
committerGitHub <noreply@github.com>2020-02-14 00:56:16 +0300
commitfc7e5e8e6060d9e0df2e704a20103d5c0f456925 (patch)
tree9e41ef3e0defa283218b97603a80e1bae5ff8613
parentbcaee66b0a06830233d0c250495410e2f46629b2 (diff)
Remove useless pylint error suppression directives (#7657)
As pylint is evolving, it improves its accuracy, and several pylint error suppression (`# pylint: disable=ERROR) added in certbot codebase months or years ago are not needed anymore to make it happy. There is a (disabled by default) pylint error to detect the useless suppressions (pylint-ception: `useless-suppression`). It is not working perfectly (it has also false-positives ...) but it is a good start to clean the codebase. This PR removes several of these useless suppressions as detected by the current pylint version we use. * Remove useless suppress * Remove useless lines
-rw-r--r--acme/acme/challenges.py2
-rw-r--r--acme/acme/client.py14
-rw-r--r--acme/acme/crypto_util.py12
-rw-r--r--acme/acme/jws.py4
-rw-r--r--acme/acme/magic_typing.py1
-rw-r--r--acme/acme/messages.py7
-rw-r--r--acme/acme/standalone.py16
-rw-r--r--certbot-apache/certbot_apache/_internal/configurator.py20
-rw-r--r--certbot-apache/certbot_apache/_internal/entrypoint.py2
-rw-r--r--certbot-apache/certbot_apache/_internal/http_01.py4
-rw-r--r--certbot-apache/certbot_apache/_internal/obj.py2
-rw-r--r--certbot-apache/certbot_apache/_internal/override_centos.py2
-rw-r--r--certbot-apache/certbot_apache/_internal/parser.py10
-rw-r--r--certbot-compatibility-test/certbot_compatibility_test/configurators/nginx/common.py2
-rw-r--r--certbot-compatibility-test/certbot_compatibility_test/test_driver.py4
-rw-r--r--certbot-compatibility-test/certbot_compatibility_test/validator.py3
-rw-r--r--certbot-dns-cloudflare/certbot_dns_cloudflare/_internal/dns_cloudflare.py2
-rw-r--r--certbot-dns-cloudxns/certbot_dns_cloudxns/_internal/dns_cloudxns.py2
-rw-r--r--certbot-dns-digitalocean/certbot_dns_digitalocean/_internal/dns_digitalocean.py2
-rw-r--r--certbot-dns-dnsimple/certbot_dns_dnsimple/_internal/dns_dnsimple.py2
-rw-r--r--certbot-dns-dnsmadeeasy/certbot_dns_dnsmadeeasy/_internal/dns_dnsmadeeasy.py2
-rw-r--r--certbot-dns-gehirn/certbot_dns_gehirn/_internal/dns_gehirn.py2
-rw-r--r--certbot-dns-google/certbot_dns_google/_internal/dns_google.py8
-rw-r--r--certbot-dns-linode/certbot_dns_linode/_internal/dns_linode.py2
-rw-r--r--certbot-dns-luadns/certbot_dns_luadns/_internal/dns_luadns.py2
-rw-r--r--certbot-dns-nsone/certbot_dns_nsone/_internal/dns_nsone.py2
-rw-r--r--certbot-dns-ovh/certbot_dns_ovh/_internal/dns_ovh.py2
-rw-r--r--certbot-dns-rfc2136/certbot_dns_rfc2136/_internal/dns_rfc2136.py2
-rw-r--r--certbot-dns-route53/certbot_dns_route53/_internal/dns_route53.py10
-rw-r--r--certbot-dns-sakuracloud/certbot_dns_sakuracloud/_internal/dns_sakuracloud.py2
-rw-r--r--certbot-nginx/certbot_nginx/_internal/configurator.py14
-rw-r--r--certbot-nginx/certbot_nginx/_internal/http_01.py2
-rw-r--r--certbot-nginx/certbot_nginx/_internal/nginxparser.py1
-rw-r--r--certbot-nginx/certbot_nginx/_internal/parser.py11
-rw-r--r--certbot-nginx/certbot_nginx/_internal/parser_obj.py2
-rw-r--r--certbot/certbot/_internal/auth_handler.py6
-rw-r--r--certbot/certbot/_internal/cert_manager.py2
-rw-r--r--certbot/certbot/_internal/cli.py8
-rw-r--r--certbot/certbot/_internal/client.py6
-rw-r--r--certbot/certbot/_internal/configuration.py18
-rw-r--r--certbot/certbot/_internal/error_handler.py10
-rw-r--r--certbot/certbot/_internal/hooks.py4
-rw-r--r--certbot/certbot/_internal/lock.py10
-rw-r--r--certbot/certbot/_internal/main.py2
-rw-r--r--certbot/certbot/_internal/plugins/disco.py5
-rw-r--r--certbot/certbot/_internal/plugins/manual.py12
-rw-r--r--certbot/certbot/_internal/plugins/null.py2
-rw-r--r--certbot/certbot/_internal/plugins/standalone.py22
-rw-r--r--certbot/certbot/_internal/plugins/webroot.py20
-rw-r--r--certbot/certbot/_internal/renewal.py2
-rw-r--r--certbot/certbot/_internal/reporter.py2
-rw-r--r--certbot/certbot/_internal/storage.py2
-rw-r--r--certbot/certbot/compat/_path.py2
-rw-r--r--certbot/certbot/compat/filesystem.py7
-rw-r--r--certbot/certbot/compat/misc.py2
-rw-r--r--certbot/certbot/crypto_util.py2
-rw-r--r--certbot/certbot/display/util.py1
-rw-r--r--certbot/certbot/interfaces.py2
-rw-r--r--certbot/certbot/ocsp.py6
-rw-r--r--certbot/certbot/plugins/common.py3
-rw-r--r--certbot/certbot/plugins/dns_common.py8
-rw-r--r--certbot/certbot/plugins/dns_common_lexicon.py6
-rw-r--r--certbot/certbot/plugins/enhancements.py6
-rw-r--r--certbot/certbot/plugins/storage.py4
-rw-r--r--certbot/certbot/reverter.py6
-rw-r--r--certbot/certbot/tests/acme_util.py3
-rw-r--r--certbot/certbot/tests/util.py2
-rw-r--r--certbot/certbot/util.py8
-rwxr-xr-xletshelp-certbot/letshelp_certbot/apache.py2
-rw-r--r--letshelp-certbot/letshelp_certbot/magic_typing.py1
-rw-r--r--letshelp-certbot/letshelp_certbot/magic_typing_test.py4
71 files changed, 183 insertions, 202 deletions
diff --git a/acme/acme/challenges.py b/acme/acme/challenges.py
index 39c8d6269..f3fb19b42 100644
--- a/acme/acme/challenges.py
+++ b/acme/acme/challenges.py
@@ -54,7 +54,7 @@ class UnrecognizedChallenge(Challenge):
object.__setattr__(self, "jobj", jobj)
def to_partial_json(self):
- return self.jobj # pylint: disable=no-member
+ return self.jobj
@classmethod
def from_json(cls, jobj):
diff --git a/acme/acme/client.py b/acme/acme/client.py
index f48ff40b2..3e03748b5 100644
--- a/acme/acme/client.py
+++ b/acme/acme/client.py
@@ -15,16 +15,16 @@ import requests
from requests.adapters import HTTPAdapter
from requests_toolbelt.adapters.source import SourceAddressAdapter
import six
-from six.moves import http_client # pylint: disable=import-error
+from six.moves import http_client
from acme import crypto_util
from acme import errors
from acme import jws
from acme import messages
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Text # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Dict
+from acme.magic_typing import List
+from acme.magic_typing import Set
+from acme.magic_typing import Text
logger = logging.getLogger(__name__)
@@ -36,7 +36,7 @@ if sys.version_info < (2, 7, 9): # pragma: no cover
try:
requests.packages.urllib3.contrib.pyopenssl.inject_into_urllib3() # type: ignore
except AttributeError:
- import urllib3.contrib.pyopenssl # pylint: disable=import-error
+ import urllib3.contrib.pyopenssl
urllib3.contrib.pyopenssl.inject_into_urllib3()
DEFAULT_NETWORK_TIMEOUT = 45
@@ -666,7 +666,7 @@ class ClientV2(ClientBase):
response = self._post(self.directory['newOrder'], order)
body = messages.Order.from_json(response.json())
authorizations = []
- for url in body.authorizations: # pylint: disable=not-an-iterable
+ for url in body.authorizations:
authorizations.append(self._authzr_from_response(self._post_as_get(url), uri=url))
return messages.OrderResource(
body=body,
diff --git a/acme/acme/crypto_util.py b/acme/acme/crypto_util.py
index 66dfc738c..dc8fedad0 100644
--- a/acme/acme/crypto_util.py
+++ b/acme/acme/crypto_util.py
@@ -11,10 +11,9 @@ from OpenSSL import crypto
from OpenSSL import SSL # type: ignore # https://github.com/python/typeshed/issues/2052
from acme import errors
-from acme.magic_typing import Callable # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Optional # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Tuple # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Union # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Callable
+from acme.magic_typing import Tuple
+from acme.magic_typing import Union
logger = logging.getLogger(__name__)
@@ -74,7 +73,7 @@ class SSLSocket(object):
class FakeConnection(object):
"""Fake OpenSSL.SSL.Connection."""
- # pylint: disable=missing-docstring
+ # pylint: disable=missing-function-docstring
def __init__(self, connection):
self._wrapped = connection
@@ -86,7 +85,7 @@ class SSLSocket(object):
# OpenSSL.SSL.Connection.shutdown doesn't accept any args
return self._wrapped.shutdown()
- def accept(self): # pylint: disable=missing-docstring
+ def accept(self): # pylint: disable=missing-function-docstring
sock, addr = self.sock.accept()
context = SSL.Context(self.method)
@@ -298,7 +297,6 @@ def dump_pyopenssl_chain(chain, filetype=crypto.FILETYPE_PEM):
def _dump_cert(cert):
if isinstance(cert, jose.ComparableX509):
- # pylint: disable=protected-access
cert = cert.wrapped
return crypto.dump_certificate(filetype, cert)
diff --git a/acme/acme/jws.py b/acme/acme/jws.py
index 894e69f3d..9128f56b3 100644
--- a/acme/acme/jws.py
+++ b/acme/acme/jws.py
@@ -15,7 +15,7 @@ class Header(jose.Header):
url = jose.Field('url', omitempty=True)
@nonce.decoder
- def nonce(value): # pylint: disable=missing-docstring,no-self-argument
+ def nonce(value): # pylint: disable=no-self-argument,missing-function-docstring
try:
return jose.decode_b64jose(value)
except jose.DeserializationError as error:
@@ -25,7 +25,7 @@ class Header(jose.Header):
class Signature(jose.Signature):
"""ACME-specific Signature. Uses ACME-specific Header for customer fields."""
- __slots__ = jose.Signature._orig_slots # pylint: disable=no-member
+ __slots__ = jose.Signature._orig_slots
# TODO: decoder/encoder should accept cls? Otherwise, subclassing
# JSONObjectWithFields is tricky...
diff --git a/acme/acme/magic_typing.py b/acme/acme/magic_typing.py
index 5a6358c69..d6b1ff056 100644
--- a/acme/acme/magic_typing.py
+++ b/acme/acme/magic_typing.py
@@ -10,7 +10,6 @@ class TypingClass(object):
try:
# mypy doesn't respect modifying sys.modules
from typing import * # pylint: disable=wildcard-import, unused-wildcard-import
- # pylint: disable=unused-import
from typing import Collection, IO # type: ignore
# pylint: enable=unused-import
except ImportError:
diff --git a/acme/acme/messages.py b/acme/acme/messages.py
index e82d12890..f8f4bfbe7 100644
--- a/acme/acme/messages.py
+++ b/acme/acme/messages.py
@@ -11,7 +11,7 @@ from acme import jws
from acme import util
try:
- from collections.abc import Hashable # pylint: disable=no-name-in-module
+ from collections.abc import Hashable
except ImportError: # pragma: no cover
from collections import Hashable
@@ -460,7 +460,6 @@ class ChallengeResource(Resource):
@property
def uri(self):
"""The URL of the challenge body."""
- # pylint: disable=function-redefined,no-member
return self.body.uri
@@ -488,7 +487,7 @@ class Authorization(ResourceBody):
wildcard = jose.Field('wildcard', omitempty=True)
@challenges.decoder
- def challenges(value): # pylint: disable=missing-docstring,no-self-argument
+ def challenges(value): # pylint: disable=no-self-argument,missing-function-docstring
return tuple(ChallengeBody.from_json(chall) for chall in value)
@property
@@ -585,7 +584,7 @@ class Order(ResourceBody):
error = jose.Field('error', omitempty=True, decoder=Error.from_json)
@identifiers.decoder
- def identifiers(value): # pylint: disable=missing-docstring,no-self-argument
+ def identifiers(value): # pylint: disable=no-self-argument,missing-function-docstring
return tuple(Identifier.from_json(identifier) for identifier in value)
class OrderResource(ResourceWithURI):
diff --git a/acme/acme/standalone.py b/acme/acme/standalone.py
index cf0da4e86..236f2c234 100644
--- a/acme/acme/standalone.py
+++ b/acme/acme/standalone.py
@@ -5,19 +5,16 @@ import logging
import socket
import threading
-from six.moves import BaseHTTPServer # type: ignore # pylint: disable=import-error
-from six.moves import http_client # pylint: disable=import-error
-from six.moves import socketserver # type: ignore # pylint: disable=import-error
+from six.moves import BaseHTTPServer # type: ignore
+from six.moves import http_client
+from six.moves import socketserver # type: ignore
from acme import challenges
from acme import crypto_util
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
logger = logging.getLogger(__name__)
-# six.moves.* | pylint: disable=no-member,attribute-defined-outside-init
-# pylint: disable=no-init
-
class TLSServer(socketserver.TCPServer):
"""Generic TLS Server."""
@@ -30,7 +27,6 @@ class TLSServer(socketserver.TCPServer):
self.address_family = socket.AF_INET
self.certs = kwargs.pop("certs", {})
self.method = kwargs.pop(
- # pylint: disable=protected-access
"method", crypto_util._DEFAULT_SSL_METHOD)
self.allow_reuse_address = kwargs.pop("allow_reuse_address", True)
socketserver.TCPServer.__init__(self, *args, **kwargs)
@@ -39,7 +35,7 @@ class TLSServer(socketserver.TCPServer):
self.socket = crypto_util.SSLSocket(
self.socket, certs=self.certs, method=self.method)
- def server_bind(self): # pylint: disable=missing-docstring
+ def server_bind(self):
self._wrap_sock()
return socketserver.TCPServer.server_bind(self)
@@ -178,7 +174,7 @@ class HTTP01RequestHandler(BaseHTTPServer.BaseHTTPRequestHandler):
self.log_message("Incoming request")
BaseHTTPServer.BaseHTTPRequestHandler.handle(self)
- def do_GET(self): # pylint: disable=invalid-name,missing-docstring
+ def do_GET(self): # pylint: disable=invalid-name,missing-function-docstring
if self.path == "/":
self.handle_index()
elif self.path.startswith("/" + challenges.HTTP01.URI_ROOT_PATH):
diff --git a/certbot-apache/certbot_apache/_internal/configurator.py b/certbot-apache/certbot_apache/_internal/configurator.py
index e9ed1f8ab..465237590 100644
--- a/certbot-apache/certbot_apache/_internal/configurator.py
+++ b/certbot-apache/certbot_apache/_internal/configurator.py
@@ -14,11 +14,11 @@ import zope.component
import zope.interface
from acme import challenges
-from acme.magic_typing import DefaultDict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Union # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import DefaultDict
+from acme.magic_typing import Dict
+from acme.magic_typing import List
+from acme.magic_typing import Set
+from acme.magic_typing import Union
from certbot import errors
from certbot import interfaces
from certbot import util
@@ -792,7 +792,7 @@ class ApacheConfigurator(common.Installer):
return util.get_filtered_names(all_names)
- def get_name_from_ip(self, addr): # pylint: disable=no-self-use
+ def get_name_from_ip(self, addr):
"""Returns a reverse dns name if available.
:param addr: IP Address
@@ -1726,7 +1726,7 @@ class ApacheConfigurator(common.Installer):
######################################################################
# Enhancements
######################################################################
- def supported_enhancements(self): # pylint: disable=no-self-use
+ def supported_enhancements(self):
"""Returns currently supported enhancements."""
return ["redirect", "ensure-http-header", "staple-ocsp"]
@@ -2292,7 +2292,7 @@ class ApacheConfigurator(common.Installer):
vhost.enabled = True
return
- def enable_mod(self, mod_name, temp=False): # pylint: disable=unused-argument
+ def enable_mod(self, mod_name, temp=False):
"""Enables module in Apache.
Both enables and reloads Apache so module is active.
@@ -2350,7 +2350,7 @@ class ApacheConfigurator(common.Installer):
error = str(err)
raise errors.MisconfigurationError(error)
- def config_test(self): # pylint: disable=no-self-use
+ def config_test(self):
"""Check the configuration of Apache for errors.
:raises .errors.MisconfigurationError: If config_test fails
@@ -2400,7 +2400,7 @@ class ApacheConfigurator(common.Installer):
###########################################################################
# Challenges Section
###########################################################################
- def get_chall_pref(self, unused_domain): # pylint: disable=no-self-use
+ def get_chall_pref(self, unused_domain):
"""Return list of challenge preferences."""
return [challenges.HTTP01]
diff --git a/certbot-apache/certbot_apache/_internal/entrypoint.py b/certbot-apache/certbot_apache/_internal/entrypoint.py
index d43094976..e31e1f4eb 100644
--- a/certbot-apache/certbot_apache/_internal/entrypoint.py
+++ b/certbot-apache/certbot_apache/_internal/entrypoint.py
@@ -1,7 +1,7 @@
""" Entry point for Apache Plugin """
# Pylint does not like disutils.version when running inside a venv.
# See: https://github.com/PyCQA/pylint/issues/73
-from distutils.version import LooseVersion # pylint: disable=no-name-in-module,import-error
+from distutils.version import LooseVersion
from certbot import util
from certbot_apache._internal import configurator
diff --git a/certbot-apache/certbot_apache/_internal/http_01.py b/certbot-apache/certbot_apache/_internal/http_01.py
index c34abc2b4..5ea0ce8ec 100644
--- a/certbot-apache/certbot_apache/_internal/http_01.py
+++ b/certbot-apache/certbot_apache/_internal/http_01.py
@@ -1,8 +1,8 @@
"""A class that performs HTTP-01 challenges for Apache"""
import logging
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
+from acme.magic_typing import Set
from certbot import errors
from certbot.compat import filesystem
from certbot.compat import os
diff --git a/certbot-apache/certbot_apache/_internal/obj.py b/certbot-apache/certbot_apache/_internal/obj.py
index 940bb6144..498766744 100644
--- a/certbot-apache/certbot_apache/_internal/obj.py
+++ b/certbot-apache/certbot_apache/_internal/obj.py
@@ -1,7 +1,7 @@
"""Module contains classes used by the Apache Configurator."""
import re
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Set
from certbot.plugins import common
diff --git a/certbot-apache/certbot_apache/_internal/override_centos.py b/certbot-apache/certbot_apache/_internal/override_centos.py
index a3ef2d760..2ab160c2f 100644
--- a/certbot-apache/certbot_apache/_internal/override_centos.py
+++ b/certbot-apache/certbot_apache/_internal/override_centos.py
@@ -4,7 +4,7 @@ import logging
import pkg_resources
import zope.interface
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
from certbot import errors
from certbot import interfaces
from certbot import util
diff --git a/certbot-apache/certbot_apache/_internal/parser.py b/certbot-apache/certbot_apache/_internal/parser.py
index aae3dc6e4..992672913 100644
--- a/certbot-apache/certbot_apache/_internal/parser.py
+++ b/certbot-apache/certbot_apache/_internal/parser.py
@@ -7,9 +7,9 @@ import sys
import six
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Dict
+from acme.magic_typing import List
+from acme.magic_typing import Set
from certbot import errors
from certbot.compat import os
from certbot_apache._internal import apache_util
@@ -321,7 +321,7 @@ class ApacheParser(object):
for mod in matches:
self.add_mod(mod.strip())
- def filter_args_num(self, matches, args): # pylint: disable=no-self-use
+ def filter_args_num(self, matches, args):
"""Filter out directives with specific number of arguments.
This function makes the assumption that all related arguments are given
@@ -715,7 +715,7 @@ class ApacheParser(object):
return get_aug_path(arg)
- def fnmatch_to_re(self, clean_fn_match): # pylint: disable=no-self-use
+ def fnmatch_to_re(self, clean_fn_match):
"""Method converts Apache's basic fnmatch to regular expression.
Assumption - Configs are assumed to be well-formed and only writable by
diff --git a/certbot-compatibility-test/certbot_compatibility_test/configurators/nginx/common.py b/certbot-compatibility-test/certbot_compatibility_test/configurators/nginx/common.py
index 3011b9823..7cb4e9722 100644
--- a/certbot-compatibility-test/certbot_compatibility_test/configurators/nginx/common.py
+++ b/certbot-compatibility-test/certbot_compatibility_test/configurators/nginx/common.py
@@ -5,7 +5,7 @@ import subprocess
import zope.interface
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Set
from certbot._internal import configuration
from certbot_compatibility_test import errors
from certbot_compatibility_test import interfaces
diff --git a/certbot-compatibility-test/certbot_compatibility_test/test_driver.py b/certbot-compatibility-test/certbot_compatibility_test/test_driver.py
index 2c3f880e0..d719f583b 100644
--- a/certbot-compatibility-test/certbot_compatibility_test/test_driver.py
+++ b/certbot-compatibility-test/certbot_compatibility_test/test_driver.py
@@ -15,8 +15,8 @@ from urllib3.util import connection
from acme import challenges
from acme import crypto_util
from acme import messages
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Tuple # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
+from acme.magic_typing import Tuple
from certbot import achallenges
from certbot import errors as le_errors
from certbot.tests import acme_util
diff --git a/certbot-compatibility-test/certbot_compatibility_test/validator.py b/certbot-compatibility-test/certbot_compatibility_test/validator.py
index 796ebbe9d..b527ce16b 100644
--- a/certbot-compatibility-test/certbot_compatibility_test/validator.py
+++ b/certbot-compatibility-test/certbot_compatibility_test/validator.py
@@ -4,7 +4,7 @@ import socket
import requests
import six
-from six.moves import xrange # pylint: disable=import-error, redefined-builtin
+from six.moves import xrange
from acme import crypto_util
from acme import errors as acme_errors
@@ -13,7 +13,6 @@ logger = logging.getLogger(__name__)
class Validator(object):
- # pylint: disable=no-self-use
"""Collection of functions to test a live webserver's configuration"""
def certificate(self, cert, name, alt_host=None, port=443):
diff --git a/certbot-dns-cloudflare/certbot_dns_cloudflare/_internal/dns_cloudflare.py b/certbot-dns-cloudflare/certbot_dns_cloudflare/_internal/dns_cloudflare.py
index 22124ac04..22dbcfa1f 100644
--- a/certbot-dns-cloudflare/certbot_dns_cloudflare/_internal/dns_cloudflare.py
+++ b/certbot-dns-cloudflare/certbot_dns_cloudflare/_internal/dns_cloudflare.py
@@ -38,7 +38,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add)
add('credentials', help='Cloudflare credentials INI file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the Cloudflare API.'
diff --git a/certbot-dns-cloudxns/certbot_dns_cloudxns/_internal/dns_cloudxns.py b/certbot-dns-cloudxns/certbot_dns_cloudxns/_internal/dns_cloudxns.py
index 2a0f12ea7..654c04c70 100644
--- a/certbot-dns-cloudxns/certbot_dns_cloudxns/_internal/dns_cloudxns.py
+++ b/certbot-dns-cloudxns/certbot_dns_cloudxns/_internal/dns_cloudxns.py
@@ -34,7 +34,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add, default_propagation_seconds=30)
add('credentials', help='CloudXNS credentials INI file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the CloudXNS API.'
diff --git a/certbot-dns-digitalocean/certbot_dns_digitalocean/_internal/dns_digitalocean.py b/certbot-dns-digitalocean/certbot_dns_digitalocean/_internal/dns_digitalocean.py
index 7f3abbe31..75e25a848 100644
--- a/certbot-dns-digitalocean/certbot_dns_digitalocean/_internal/dns_digitalocean.py
+++ b/certbot-dns-digitalocean/certbot_dns_digitalocean/_internal/dns_digitalocean.py
@@ -30,7 +30,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add)
add('credentials', help='DigitalOcean credentials INI file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the DigitalOcean API.'
diff --git a/certbot-dns-dnsimple/certbot_dns_dnsimple/_internal/dns_dnsimple.py b/certbot-dns-dnsimple/certbot_dns_dnsimple/_internal/dns_dnsimple.py
index 8c48d31e7..9f7f100d7 100644
--- a/certbot-dns-dnsimple/certbot_dns_dnsimple/_internal/dns_dnsimple.py
+++ b/certbot-dns-dnsimple/certbot_dns_dnsimple/_internal/dns_dnsimple.py
@@ -34,7 +34,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add, default_propagation_seconds=30)
add('credentials', help='DNSimple credentials INI file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the DNSimple API.'
diff --git a/certbot-dns-dnsmadeeasy/certbot_dns_dnsmadeeasy/_internal/dns_dnsmadeeasy.py b/certbot-dns-dnsmadeeasy/certbot_dns_dnsmadeeasy/_internal/dns_dnsmadeeasy.py
index ed3146dce..4a1fcffc3 100644
--- a/certbot-dns-dnsmadeeasy/certbot_dns_dnsmadeeasy/_internal/dns_dnsmadeeasy.py
+++ b/certbot-dns-dnsmadeeasy/certbot_dns_dnsmadeeasy/_internal/dns_dnsmadeeasy.py
@@ -35,7 +35,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add, default_propagation_seconds=60)
add('credentials', help='DNS Made Easy credentials INI file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the DNS Made Easy API.'
diff --git a/certbot-dns-gehirn/certbot_dns_gehirn/_internal/dns_gehirn.py b/certbot-dns-gehirn/certbot_dns_gehirn/_internal/dns_gehirn.py
index 76c0ed584..39deddae5 100644
--- a/certbot-dns-gehirn/certbot_dns_gehirn/_internal/dns_gehirn.py
+++ b/certbot-dns-gehirn/certbot_dns_gehirn/_internal/dns_gehirn.py
@@ -34,7 +34,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add, default_propagation_seconds=30)
add('credentials', help='Gehirn Infrastructure Service credentials file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the Gehirn Infrastructure Service API.'
diff --git a/certbot-dns-google/certbot_dns_google/_internal/dns_google.py b/certbot-dns-google/certbot_dns_google/_internal/dns_google.py
index 3aa910b52..4eaed1783 100644
--- a/certbot-dns-google/certbot_dns_google/_internal/dns_google.py
+++ b/certbot-dns-google/certbot_dns_google/_internal/dns_google.py
@@ -45,7 +45,7 @@ class Authenticator(dns_common.DNSAuthenticator):
'required permissions.)').format(ACCT_URL, PERMISSIONS_URL),
default=None)
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the Google Cloud DNS API.'
@@ -148,7 +148,7 @@ class _GoogleClient(object):
},
]
- changes = self.dns.changes() # changes | pylint: disable=no-member
+ changes = self.dns.changes()
try:
request = changes.create(project=self.project_id, managedZone=zone_id, body=data)
@@ -213,7 +213,7 @@ class _GoogleClient(object):
},
]
- changes = self.dns.changes() # changes | pylint: disable=no-member
+ changes = self.dns.changes()
try:
request = changes.create(project=self.project_id, managedZone=zone_id, body=data)
@@ -264,7 +264,7 @@ class _GoogleClient(object):
zone_dns_name_guesses = dns_common.base_domain_name_guesses(domain)
- mz = self.dns.managedZones() # managedZones | pylint: disable=no-member
+ mz = self.dns.managedZones()
for zone_name in zone_dns_name_guesses:
try:
request = mz.list(project=self.project_id, dnsName=zone_name + '.')
diff --git a/certbot-dns-linode/certbot_dns_linode/_internal/dns_linode.py b/certbot-dns-linode/certbot_dns_linode/_internal/dns_linode.py
index ea6046849..f7b3ec3d4 100644
--- a/certbot-dns-linode/certbot_dns_linode/_internal/dns_linode.py
+++ b/certbot-dns-linode/certbot_dns_linode/_internal/dns_linode.py
@@ -35,7 +35,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add, default_propagation_seconds=1200)
add('credentials', help='Linode credentials INI file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the Linode API.'
diff --git a/certbot-dns-luadns/certbot_dns_luadns/_internal/dns_luadns.py b/certbot-dns-luadns/certbot_dns_luadns/_internal/dns_luadns.py
index 7c18c7131..d5b499c72 100644
--- a/certbot-dns-luadns/certbot_dns_luadns/_internal/dns_luadns.py
+++ b/certbot-dns-luadns/certbot_dns_luadns/_internal/dns_luadns.py
@@ -34,7 +34,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add, default_propagation_seconds=30)
add('credentials', help='LuaDNS credentials INI file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the LuaDNS API.'
diff --git a/certbot-dns-nsone/certbot_dns_nsone/_internal/dns_nsone.py b/certbot-dns-nsone/certbot_dns_nsone/_internal/dns_nsone.py
index f5af37389..d328d80ce 100644
--- a/certbot-dns-nsone/certbot_dns_nsone/_internal/dns_nsone.py
+++ b/certbot-dns-nsone/certbot_dns_nsone/_internal/dns_nsone.py
@@ -34,7 +34,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add, default_propagation_seconds=30)
add('credentials', help='NS1 credentials file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the NS1 API.'
diff --git a/certbot-dns-ovh/certbot_dns_ovh/_internal/dns_ovh.py b/certbot-dns-ovh/certbot_dns_ovh/_internal/dns_ovh.py
index a495983f2..11ae6b8f0 100644
--- a/certbot-dns-ovh/certbot_dns_ovh/_internal/dns_ovh.py
+++ b/certbot-dns-ovh/certbot_dns_ovh/_internal/dns_ovh.py
@@ -34,7 +34,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add, default_propagation_seconds=30)
add('credentials', help='OVH credentials INI file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the OVH API.'
diff --git a/certbot-dns-rfc2136/certbot_dns_rfc2136/_internal/dns_rfc2136.py b/certbot-dns-rfc2136/certbot_dns_rfc2136/_internal/dns_rfc2136.py
index cb4d5addb..3bb4f444b 100644
--- a/certbot-dns-rfc2136/certbot_dns_rfc2136/_internal/dns_rfc2136.py
+++ b/certbot-dns-rfc2136/certbot_dns_rfc2136/_internal/dns_rfc2136.py
@@ -50,7 +50,7 @@ class Authenticator(dns_common.DNSAuthenticator):
super(Authenticator, cls).add_parser_arguments(add, default_propagation_seconds=60)
add('credentials', help='RFC 2136 credentials INI file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'RFC 2136 Dynamic Updates.'
diff --git a/certbot-dns-route53/certbot_dns_route53/_internal/dns_route53.py b/certbot-dns-route53/certbot_dns_route53/_internal/dns_route53.py
index 637558304..6250d2274 100644
--- a/certbot-dns-route53/certbot_dns_route53/_internal/dns_route53.py
+++ b/certbot-dns-route53/certbot_dns_route53/_internal/dns_route53.py
@@ -8,9 +8,9 @@ from botocore.exceptions import ClientError
from botocore.exceptions import NoCredentialsError
import zope.interface
-from acme.magic_typing import DefaultDict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import DefaultDict
+from acme.magic_typing import Dict
+from acme.magic_typing import List
from certbot import errors
from certbot import interfaces
from certbot.plugins import dns_common
@@ -41,13 +41,13 @@ class Authenticator(dns_common.DNSAuthenticator):
self.r53 = boto3.client("route53")
self._resource_records = collections.defaultdict(list) # type: DefaultDict[str, List[Dict[str, str]]]
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return "Solve a DNS01 challenge using AWS Route53"
def _setup_credentials(self):
pass
- def _perform(self, domain, validation_name, validation): # pylint: disable=missing-docstring
+ def _perform(self, domain, validation_name, validation):
pass
def perform(self, achalls):
diff --git a/certbot-dns-sakuracloud/certbot_dns_sakuracloud/_internal/dns_sakuracloud.py b/certbot-dns-sakuracloud/certbot_dns_sakuracloud/_internal/dns_sakuracloud.py
index 25042bfc6..67cfb2e97 100644
--- a/certbot-dns-sakuracloud/certbot_dns_sakuracloud/_internal/dns_sakuracloud.py
+++ b/certbot-dns-sakuracloud/certbot_dns_sakuracloud/_internal/dns_sakuracloud.py
@@ -35,7 +35,7 @@ class Authenticator(dns_common.DNSAuthenticator):
add, default_propagation_seconds=90)
add('credentials', help='Sakura Cloud credentials file.')
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return 'This plugin configures a DNS TXT record to respond to a dns-01 challenge using ' + \
'the Sakura Cloud API.'
diff --git a/certbot-nginx/certbot_nginx/_internal/configurator.py b/certbot-nginx/certbot_nginx/_internal/configurator.py
index 52d8a08bc..459950aa1 100644
--- a/certbot-nginx/certbot_nginx/_internal/configurator.py
+++ b/certbot-nginx/certbot_nginx/_internal/configurator.py
@@ -1,6 +1,6 @@
"""Nginx Configuration"""
# https://github.com/PyCQA/pylint/issues/73
-from distutils.version import LooseVersion # pylint: disable=no-name-in-module, import-error
+from distutils.version import LooseVersion
import logging
import re
import socket
@@ -14,9 +14,9 @@ import zope.interface
from acme import challenges
from acme import crypto_util as acme_crypto_util
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Dict
+from acme.magic_typing import List
+from acme.magic_typing import Set
from certbot import crypto_util
from certbot import errors
from certbot import interfaces
@@ -696,7 +696,7 @@ class NginxConfigurator(common.Installer):
##################################
# enhancement methods (IInstaller)
##################################
- def supported_enhancements(self): # pylint: disable=no-self-use
+ def supported_enhancements(self):
"""Returns currently supported enhancements."""
return ['redirect', 'ensure-http-header', 'staple-ocsp']
@@ -915,7 +915,7 @@ class NginxConfigurator(common.Installer):
"""
nginx_restart(self.conf('ctl'), self.nginx_conf)
- def config_test(self): # pylint: disable=no-self-use
+ def config_test(self):
"""Check the configuration of Nginx for errors.
:raises .errors.MisconfigurationError: If config_test fails
@@ -1090,7 +1090,7 @@ class NginxConfigurator(common.Installer):
###########################################################################
# Challenges Section for IAuthenticator
###########################################################################
- def get_chall_pref(self, unused_domain): # pylint: disable=no-self-use
+ def get_chall_pref(self, unused_domain):
"""Return list of challenge preferences."""
return [challenges.HTTP01]
diff --git a/certbot-nginx/certbot_nginx/_internal/http_01.py b/certbot-nginx/certbot_nginx/_internal/http_01.py
index 97b111576..2f6458f87 100644
--- a/certbot-nginx/certbot_nginx/_internal/http_01.py
+++ b/certbot-nginx/certbot_nginx/_internal/http_01.py
@@ -3,7 +3,7 @@
import logging
from acme import challenges
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
from certbot import errors
from certbot.compat import os
from certbot.plugins import common
diff --git a/certbot-nginx/certbot_nginx/_internal/nginxparser.py b/certbot-nginx/certbot_nginx/_internal/nginxparser.py
index 4fa1362a0..a8ac90427 100644
--- a/certbot-nginx/certbot_nginx/_internal/nginxparser.py
+++ b/certbot-nginx/certbot_nginx/_internal/nginxparser.py
@@ -20,7 +20,6 @@ import six
logger = logging.getLogger(__name__)
class RawNginxParser(object):
- # pylint: disable=expression-not-assigned
# pylint: disable=pointless-statement
"""A class that parses nginx configuration with pyparsing."""
diff --git a/certbot-nginx/certbot_nginx/_internal/parser.py b/certbot-nginx/certbot_nginx/_internal/parser.py
index edb77a1c1..f71d7c018 100644
--- a/certbot-nginx/certbot_nginx/_internal/parser.py
+++ b/certbot-nginx/certbot_nginx/_internal/parser.py
@@ -8,11 +8,11 @@ import re
import pyparsing
import six
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Tuple # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Union # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Dict
+from acme.magic_typing import List
+from acme.magic_typing import Set
+from acme.magic_typing import Tuple
+from acme.magic_typing import Union
from certbot import errors
from certbot.compat import os
from certbot_nginx._internal import nginxparser
@@ -127,7 +127,6 @@ class NginxParser(object):
return servers
def get_vhosts(self):
- # pylint: disable=cell-var-from-loop
"""Gets list of all 'virtual hosts' found in Nginx configuration.
Technically this is a misnomer because Nginx does not have virtual
hosts, it has 'server blocks'.
diff --git a/certbot-nginx/certbot_nginx/_internal/parser_obj.py b/certbot-nginx/certbot_nginx/_internal/parser_obj.py
index e03913887..61b31b2d5 100644
--- a/certbot-nginx/certbot_nginx/_internal/parser_obj.py
+++ b/certbot-nginx/certbot_nginx/_internal/parser_obj.py
@@ -6,7 +6,7 @@ import logging
import six
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
from certbot import errors
logger = logging.getLogger(__name__)
diff --git a/certbot/certbot/_internal/auth_handler.py b/certbot/certbot/_internal/auth_handler.py
index e4ad91247..7ea2a1de8 100644
--- a/certbot/certbot/_internal/auth_handler.py
+++ b/certbot/certbot/_internal/auth_handler.py
@@ -8,9 +8,9 @@ import zope.component
from acme import challenges
from acme import errors as acme_errors
from acme import messages
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Tuple # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Dict
+from acme.magic_typing import List
+from acme.magic_typing import Tuple
from certbot import achallenges
from certbot import errors
from certbot import interfaces
diff --git a/certbot/certbot/_internal/cert_manager.py b/certbot/certbot/_internal/cert_manager.py
index 298e7d269..e6cbd5c2c 100644
--- a/certbot/certbot/_internal/cert_manager.py
+++ b/certbot/certbot/_internal/cert_manager.py
@@ -7,7 +7,7 @@ import traceback
import pytz
import zope.component
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
from certbot import crypto_util
from certbot import errors
from certbot import interfaces
diff --git a/certbot/certbot/_internal/cli.py b/certbot/certbot/_internal/cli.py
index d5d498b4d..c0dbf7424 100644
--- a/certbot/certbot/_internal/cli.py
+++ b/certbot/certbot/_internal/cli.py
@@ -15,9 +15,9 @@ import zope.interface
from zope.interface import interfaces as zope_interfaces
from acme import challenges
-from acme.magic_typing import Any # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Optional # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Any
+from acme.magic_typing import Dict
+from acme.magic_typing import Optional
import certbot
from certbot import crypto_util
from certbot import errors
@@ -505,7 +505,7 @@ class HelpfulArgumentParser(object):
" and ".join(flag_default("config_files"))))
# This is the only way to turn off overly verbose config flag documentation
- self.parser._add_config_file_help = False # pylint: disable=protected-access
+ self.parser._add_config_file_help = False
# Help that are synonyms for --help subcommands
COMMANDS_TOPICS = ["command", "commands", "subcommand", "subcommands", "verbs"]
diff --git a/certbot/certbot/_internal/client.py b/certbot/certbot/_internal/client.py
index 9ce741e38..526f4200f 100644
--- a/certbot/certbot/_internal/client.py
+++ b/certbot/certbot/_internal/client.py
@@ -14,8 +14,8 @@ from acme import client as acme_client
from acme import crypto_util as acme_crypto_util
from acme import errors as acme_errors
from acme import messages
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Optional # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
+from acme.magic_typing import Optional
import certbot
from certbot import crypto_util
from certbot import errors
@@ -343,7 +343,7 @@ class Client(object):
orderr = self._get_order_and_authorizations(csr.data, self.config.allow_subset_of_names)
authzr = orderr.authorizations
- auth_domains = set(a.body.identifier.value for a in authzr) # pylint: disable=not-an-iterable
+ auth_domains = set(a.body.identifier.value for a in authzr)
successful_domains = [d for d in domains if d in auth_domains]
# allow_subset_of_names is currently disabled for wildcard
diff --git a/certbot/certbot/_internal/configuration.py b/certbot/certbot/_internal/configuration.py
index f3db207db..f1e85f9fe 100644
--- a/certbot/certbot/_internal/configuration.py
+++ b/certbot/certbot/_internal/configuration.py
@@ -65,7 +65,7 @@ class NamespaceConfig(object):
return (parsed.netloc + parsed.path).replace('/', os.path.sep)
@property
- def accounts_dir(self): # pylint: disable=missing-docstring
+ def accounts_dir(self): # pylint: disable=missing-function-docstring
return self.accounts_dir_for_server_path(self.server_path)
def accounts_dir_for_server_path(self, server_path):
@@ -75,23 +75,23 @@ class NamespaceConfig(object):
self.namespace.config_dir, constants.ACCOUNTS_DIR, server_path)
@property
- def backup_dir(self): # pylint: disable=missing-docstring
+ def backup_dir(self): # pylint: disable=missing-function-docstring
return os.path.join(self.namespace.work_dir, constants.BACKUP_DIR)
@property
- def csr_dir(self): # pylint: disable=missing-docstring
+ def csr_dir(self): # pylint: disable=missing-function-docstring
return os.path.join(self.namespace.config_dir, constants.CSR_DIR)
@property
- def in_progress_dir(self): # pylint: disable=missing-docstring
+ def in_progress_dir(self): # pylint: disable=missing-function-docstring
return os.path.join(self.namespace.work_dir, constants.IN_PROGRESS_DIR)
@property
- def key_dir(self): # pylint: disable=missing-docstring
+ def key_dir(self): # pylint: disable=missing-function-docstring
return os.path.join(self.namespace.config_dir, constants.KEY_DIR)
@property
- def temp_checkpoint_dir(self): # pylint: disable=missing-docstring
+ def temp_checkpoint_dir(self): # pylint: disable=missing-function-docstring
return os.path.join(
self.namespace.work_dir, constants.TEMP_CHECKPOINT_DIR)
@@ -102,15 +102,15 @@ class NamespaceConfig(object):
return type(self)(new_ns)
@property
- def default_archive_dir(self): # pylint: disable=missing-docstring
+ def default_archive_dir(self): # pylint: disable=missing-function-docstring
return os.path.join(self.namespace.config_dir, constants.ARCHIVE_DIR)
@property
- def live_dir(self): # pylint: disable=missing-docstring
+ def live_dir(self): # pylint: disable=missing-function-docstring
return os.path.join(self.namespace.config_dir, constants.LIVE_DIR)
@property
- def renewal_configs_dir(self): # pylint: disable=missing-docstring
+ def renewal_configs_dir(self): # pylint: disable=missing-function-docstring
return os.path.join(
self.namespace.config_dir, constants.RENEWAL_CONFIGS_DIR)
diff --git a/certbot/certbot/_internal/error_handler.py b/certbot/certbot/_internal/error_handler.py
index 5ca3cc57e..41c12eafa 100644
--- a/certbot/certbot/_internal/error_handler.py
+++ b/certbot/certbot/_internal/error_handler.py
@@ -4,11 +4,11 @@ import logging
import signal
import traceback
-from acme.magic_typing import Any # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Callable # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Union # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Any
+from acme.magic_typing import Callable
+from acme.magic_typing import Dict
+from acme.magic_typing import List
+from acme.magic_typing import Union
from certbot import errors
from certbot.compat import os
diff --git a/certbot/certbot/_internal/hooks.py b/certbot/certbot/_internal/hooks.py
index 25addd915..589c59e89 100644
--- a/certbot/certbot/_internal/hooks.py
+++ b/certbot/certbot/_internal/hooks.py
@@ -5,8 +5,8 @@ import logging
from subprocess import PIPE
from subprocess import Popen
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
+from acme.magic_typing import Set
from certbot import errors
from certbot import util
from certbot.compat import filesystem
diff --git a/certbot/certbot/_internal/lock.py b/certbot/certbot/_internal/lock.py
index 7823eaac3..8f3c28006 100644
--- a/certbot/certbot/_internal/lock.py
+++ b/certbot/certbot/_internal/lock.py
@@ -2,15 +2,15 @@
import errno
import logging
-from acme.magic_typing import Optional # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Optional
from certbot import errors
from certbot.compat import filesystem
from certbot.compat import os
try:
- import fcntl # pylint: disable=import-error
+ import fcntl
except ImportError:
- import msvcrt # pylint: disable=import-error
+ import msvcrt
POSIX_MODE = False
else:
POSIX_MODE = True
@@ -115,10 +115,10 @@ class _BaseLockMechanism(object):
"""
return self._fd is not None
- def acquire(self): # pylint: disable=missing-docstring
+ def acquire(self): # pylint: disable=missing-function-docstring
pass # pragma: no cover
- def release(self): # pylint: disable=missing-docstring
+ def release(self): # pylint: disable=missing-function-docstring
pass # pragma: no cover
diff --git a/certbot/certbot/_internal/main.py b/certbot/certbot/_internal/main.py
index 72fcfca71..8674cd151 100644
--- a/certbot/certbot/_internal/main.py
+++ b/certbot/certbot/_internal/main.py
@@ -11,7 +11,7 @@ import josepy as jose
import zope.component
from acme import errors as acme_errors
-from acme.magic_typing import Union # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Union
import certbot
from certbot import crypto_util
from certbot import errors
diff --git a/certbot/certbot/_internal/plugins/disco.py b/certbot/certbot/_internal/plugins/disco.py
index d7d6390f7..d98a4cb0c 100644
--- a/certbot/certbot/_internal/plugins/disco.py
+++ b/certbot/certbot/_internal/plugins/disco.py
@@ -8,7 +8,7 @@ import six
import zope.interface
import zope.interface.verify
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Dict
from certbot import errors
from certbot import interfaces
from certbot._internal import constants
@@ -195,14 +195,12 @@ class PluginsRegistry(Mapping):
# Pylint checks for super init, but also claims the super
# has no __init__member
- # pylint: disable=super-init-not-called
self._plugins = collections.OrderedDict(sorted(six.iteritems(plugins)))
@classmethod
def find_all(cls):
"""Find plugins using setuptools entry points."""
plugins = {} # type: Dict[str, PluginEntryPoint]
- # pylint: disable=not-callable
entry_points = itertools.chain(
pkg_resources.iter_entry_points(
constants.SETUPTOOLS_PLUGINS_ENTRY_POINT),
@@ -212,7 +210,6 @@ class PluginsRegistry(Mapping):
plugin_ep = PluginEntryPoint(entry_point)
assert plugin_ep.name not in plugins, (
"PREFIX_FREE_DISTRIBUTIONS messed up")
- # providedBy | pylint: disable=no-member
if interfaces.IPluginFactory.providedBy(plugin_ep.plugin_cls):
plugins[plugin_ep.name] = plugin_ep
else: # pragma: no cover
diff --git a/certbot/certbot/_internal/plugins/manual.py b/certbot/certbot/_internal/plugins/manual.py
index be6abaad4..3204fe1da 100644
--- a/certbot/certbot/_internal/plugins/manual.py
+++ b/certbot/certbot/_internal/plugins/manual.py
@@ -3,7 +3,7 @@ import zope.component
import zope.interface
from acme import challenges
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Dict
from certbot import achallenges # pylint: disable=unused-import
from certbot import errors
from certbot import interfaces
@@ -81,7 +81,7 @@ permitted by DNS standards.)
add('public-ip-logging-ok', action='store_true',
help='Automatically allows public IP logging (default: Ask)')
- def prepare(self): # pylint: disable=missing-docstring
+ def prepare(self): # pylint: disable=missing-function-docstring
if self.config.noninteractive_mode and not self.conf('auth-hook'):
raise errors.PluginError(
'An authentication script must be provided with --{0} when '
@@ -97,17 +97,17 @@ permitted by DNS standards.)
hook_prefix = self.option_name(name)[:-len('-hook')]
hooks.validate_hook(hook, hook_prefix)
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return (
'This plugin allows the user to customize setup for domain '
'validation challenges either through shell scripts provided by '
'the user or by performing the setup manually.')
def get_chall_pref(self, domain):
- # pylint: disable=missing-docstring,no-self-use,unused-argument
+ # pylint: disable=unused-argument,missing-function-docstring
return [challenges.HTTP01, challenges.DNS01]
- def perform(self, achalls): # pylint: disable=missing-docstring
+ def perform(self, achalls): # pylint: disable=missing-function-docstring
self._verify_ip_logging_ok()
if self.conf('auth-hook'):
perform_achall = self._perform_achall_with_script
@@ -170,7 +170,7 @@ permitted by DNS standards.)
display.notification(msg, wrap=False, force_interactive=True)
self.subsequent_any_challenge = True
- def cleanup(self, achalls): # pylint: disable=missing-docstring
+ def cleanup(self, achalls): # pylint: disable=missing-function-docstring
if self.conf('cleanup-hook'):
for achall in achalls:
env = self.env.pop(achall)
diff --git a/certbot/certbot/_internal/plugins/null.py b/certbot/certbot/_internal/plugins/null.py
index bf4615497..cf7c05a2b 100644
--- a/certbot/certbot/_internal/plugins/null.py
+++ b/certbot/certbot/_internal/plugins/null.py
@@ -18,7 +18,7 @@ class Installer(common.Plugin):
description = "Null Installer"
hidden = True
- # pylint: disable=missing-docstring,no-self-use
+ # pylint: disable=missing-function-docstring
def prepare(self):
pass # pragma: no cover
diff --git a/certbot/certbot/_internal/plugins/standalone.py b/certbot/certbot/_internal/plugins/standalone.py
index 80421299e..bbb56178c 100644
--- a/certbot/certbot/_internal/plugins/standalone.py
+++ b/certbot/certbot/_internal/plugins/standalone.py
@@ -11,12 +11,12 @@ import zope.interface
from acme import challenges
from acme import standalone as acme_standalone
-from acme.magic_typing import DefaultDict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Tuple # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import TYPE_CHECKING # pylint: disable=unused-import, no-name-in-module
-from certbot import achallenges # pylint: disable=unused-import
+from acme.magic_typing import DefaultDict
+from acme.magic_typing import Dict
+from acme.magic_typing import Set
+from acme.magic_typing import Tuple
+from acme.magic_typing import TYPE_CHECKING
+from certbot import achallenges
from certbot import errors
from certbot import interfaces
from certbot.plugins import common
@@ -139,20 +139,20 @@ class Authenticator(common.Plugin):
def add_parser_arguments(cls, add):
pass # No additional argument for the standalone plugin parser
- def more_info(self): # pylint: disable=missing-docstring
+ def more_info(self): # pylint: disable=missing-function-docstring
return("This authenticator creates its own ephemeral TCP listener "
"on the necessary port in order to respond to incoming "
"http-01 challenges from the certificate authority. Therefore, "
"it does not rely on any existing server program.")
- def prepare(self): # pylint: disable=missing-docstring
+ def prepare(self): # pylint: disable=missing-function-docstring
pass
def get_chall_pref(self, domain):
- # pylint: disable=unused-argument,missing-docstring
+ # pylint: disable=unused-argument,missing-function-docstring
return [challenges.HTTP01]
- def perform(self, achalls): # pylint: disable=missing-docstring
+ def perform(self, achalls): # pylint: disable=missing-function-docstring
return [self._try_perform_single(achall) for achall in achalls]
def _try_perform_single(self, achall):
@@ -177,7 +177,7 @@ class Authenticator(common.Plugin):
self.http_01_resources.add(resource)
return servers, response
- def cleanup(self, achalls): # pylint: disable=missing-docstring
+ def cleanup(self, achalls): # pylint: disable=missing-function-docstring
# reduce self.served and close servers if no challenges are served
for unused_servers, server_achalls in self.served.items():
for achall in achalls:
diff --git a/certbot/certbot/_internal/plugins/webroot.py b/certbot/certbot/_internal/plugins/webroot.py
index c7737e0d1..042b60656 100644
--- a/certbot/certbot/_internal/plugins/webroot.py
+++ b/certbot/certbot/_internal/plugins/webroot.py
@@ -9,11 +9,11 @@ import six
import zope.component
import zope.interface
-from acme import challenges # pylint: disable=unused-import
-from acme.magic_typing import DefaultDict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Set # pylint: disable=unused-import, no-name-in-module
+from acme import challenges
+from acme.magic_typing import DefaultDict
+from acme.magic_typing import Dict
+from acme.magic_typing import List
+from acme.magic_typing import Set
from certbot import achallenges # pylint: disable=unused-import
from certbot import errors
from certbot import interfaces
@@ -42,7 +42,7 @@ necessary validation resources to appropriate paths on the file
system. It expects that there is some other HTTP server configured
to serve all files under specified web root ({0})."""
- def more_info(self): # pylint: disable=missing-docstring,no-self-use
+ def more_info(self): # pylint: disable=missing-function-docstring
return self.MORE_INFO.format(self.conf("path"))
@classmethod
@@ -64,7 +64,7 @@ to serve all files under specified web root ({0})."""
'{"example.com":"/var/www"}.')
def get_chall_pref(self, domain): # pragma: no cover
- # pylint: disable=missing-docstring,no-self-use,unused-argument
+ # pylint: disable=unused-argument,missing-function-docstring
return [challenges.HTTP01]
def __init__(self, *args, **kwargs):
@@ -75,10 +75,10 @@ to serve all files under specified web root ({0})."""
# stack of dirs successfully created by this authenticator
self._created_dirs = [] # type: List[str]
- def prepare(self): # pylint: disable=missing-docstring
+ def prepare(self): # pylint: disable=missing-function-docstring
pass
- def perform(self, achalls): # pylint: disable=missing-docstring
+ def perform(self, achalls): # pylint: disable=missing-function-docstring
self._set_webroots(achalls)
self._create_challenge_dirs()
@@ -213,7 +213,7 @@ to serve all files under specified web root ({0})."""
self.performed[root_path].add(achall)
return response
- def cleanup(self, achalls): # pylint: disable=missing-docstring
+ def cleanup(self, achalls): # pylint: disable=missing-function-docstring
for achall in achalls:
root_path = self.full_roots.get(achall.domain, None)
if root_path is not None:
diff --git a/certbot/certbot/_internal/renewal.py b/certbot/certbot/_internal/renewal.py
index bf30404f5..fd23b0d18 100644
--- a/certbot/certbot/_internal/renewal.py
+++ b/certbot/certbot/_internal/renewal.py
@@ -13,7 +13,7 @@ import OpenSSL
import six
import zope.component
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
from certbot import crypto_util
from certbot import errors
from certbot import interfaces
diff --git a/certbot/certbot/_internal/reporter.py b/certbot/certbot/_internal/reporter.py
index 947f343d4..3b959f4e1 100644
--- a/certbot/certbot/_internal/reporter.py
+++ b/certbot/certbot/_internal/reporter.py
@@ -6,7 +6,7 @@ import logging
import sys
import textwrap
-from six.moves import queue # type: ignore # pylint: disable=import-error
+from six.moves import queue # type: ignore
import zope.interface
from certbot import interfaces
diff --git a/certbot/certbot/_internal/storage.py b/certbot/certbot/_internal/storage.py
index 964515eee..6a34355a8 100644
--- a/certbot/certbot/_internal/storage.py
+++ b/certbot/certbot/_internal/storage.py
@@ -883,7 +883,7 @@ class RenewableCert(interfaces.RenewableCert):
return crypto_util.get_names_from_cert(f.read())
def ocsp_revoked(self, version=None):
- # pylint: disable=no-self-use,unused-argument
+ # pylint: disable=unused-argument
"""Is the specified cert version revoked according to OCSP?
Also returns True if the cert version is declared as intended
diff --git a/certbot/certbot/compat/_path.py b/certbot/certbot/compat/_path.py
index 5c5fe460e..44c5e300f 100644
--- a/certbot/certbot/compat/_path.py
+++ b/certbot/certbot/compat/_path.py
@@ -9,7 +9,7 @@ from __future__ import absolute_import
# First round of wrapping: we import statically all public attributes exposed by the os.path
# module. This allows in particular to have pylint, mypy, IDEs be aware that most of os.path
# members are available in certbot.compat.path.
-from os.path import * # type: ignore # pylint: disable=wildcard-import,unused-wildcard-import,redefined-builtin,os-module-forbidden
+from os.path import * # type: ignore # pylint: disable=wildcard-import,unused-wildcard-import,os-module-forbidden
# Second round of wrapping: we import dynamically all attributes from the os.path module that have
# not yet been imported by the first round (static star import).
diff --git a/certbot/certbot/compat/filesystem.py b/certbot/certbot/compat/filesystem.py
index 65bb53f38..88c2916fa 100644
--- a/certbot/certbot/compat/filesystem.py
+++ b/certbot/certbot/compat/filesystem.py
@@ -5,12 +5,11 @@ import errno
import os # pylint: disable=os-module-forbidden
import stat
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Tuple # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Union # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
+from acme.magic_typing import Tuple # pylint: disable=unused-import
+from acme.magic_typing import Union # pylint: disable=unused-import
try:
- # pylint: disable=import-error
import ntsecuritycon
import win32security
import win32con
diff --git a/certbot/certbot/compat/misc.py b/certbot/certbot/compat/misc.py
index ffe611edb..956c56370 100644
--- a/certbot/certbot/compat/misc.py
+++ b/certbot/certbot/compat/misc.py
@@ -11,7 +11,7 @@ from certbot import errors
from certbot.compat import os
try:
- from win32com.shell import shell as shellwin32 # pylint: disable=import-error
+ from win32com.shell import shell as shellwin32
POSIX_MODE = False
except ImportError: # pragma: no cover
POSIX_MODE = True
diff --git a/certbot/certbot/crypto_util.py b/certbot/certbot/crypto_util.py
index 9aae75991..9136445bc 100644
--- a/certbot/certbot/crypto_util.py
+++ b/certbot/certbot/crypto_util.py
@@ -23,7 +23,7 @@ import six
import zope.component
from acme import crypto_util as acme_crypto_util
-from acme.magic_typing import IO # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import IO # pylint: disable=unused-import
from certbot import errors
from certbot import interfaces
from certbot import util
diff --git a/certbot/certbot/display/util.py b/certbot/certbot/display/util.py
index ba2dd4ecf..05330b1a9 100644
--- a/certbot/certbot/display/util.py
+++ b/certbot/certbot/display/util.py
@@ -334,7 +334,6 @@ class FileDisplay(object):
return self.input(message, default, cli_flag, force_interactive)
def _scrub_checklist_input(self, indices, tags):
- # pylint: disable=no-self-use
"""Validate input and transform indices to appropriate tags.
:param list indices: input
diff --git a/certbot/certbot/interfaces.py b/certbot/certbot/interfaces.py
index e96712d23..81b41d1ec 100644
--- a/certbot/certbot/interfaces.py
+++ b/certbot/certbot/interfaces.py
@@ -4,7 +4,7 @@ import abc
import six
import zope.interface
-# pylint: disable=no-self-argument,no-method-argument,no-init,inherit-non-class
+# pylint: disable=no-self-argument,no-method-argument,inherit-non-class
@six.add_metaclass(abc.ABCMeta)
diff --git a/certbot/certbot/ocsp.py b/certbot/certbot/ocsp.py
index 5c3cfdd59..6a95f26fa 100644
--- a/certbot/certbot/ocsp.py
+++ b/certbot/certbot/ocsp.py
@@ -16,8 +16,8 @@ from cryptography.hazmat.primitives import serialization
import pytz
import requests
-from acme.magic_typing import Optional # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Tuple # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Optional
+from acme.magic_typing import Tuple
from certbot import crypto_util
from certbot import errors
from certbot import util
@@ -26,7 +26,7 @@ from certbot.interfaces import RenewableCert # pylint: disable=unused-import
try:
# Only cryptography>=2.5 has ocsp module
# and signature_hash_algorithm attribute in OCSPResponse class
- from cryptography.x509 import ocsp # pylint: disable=import-error, ungrouped-imports
+ from cryptography.x509 import ocsp # pylint: disable=ungrouped-imports
getattr(ocsp.OCSPResponse, 'signature_hash_algorithm')
except (ImportError, AttributeError): # pragma: no cover
ocsp = None # type: ignore
diff --git a/certbot/certbot/plugins/common.py b/certbot/certbot/plugins/common.py
index 6fa1e76f8..7d21e6d0a 100644
--- a/certbot/certbot/plugins/common.py
+++ b/certbot/certbot/plugins/common.py
@@ -10,7 +10,7 @@ from josepy import util as jose_util
import pkg_resources
import zope.interface
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import List
from certbot import achallenges # pylint: disable=unused-import
from certbot import crypto_util
from certbot import errors
@@ -74,7 +74,6 @@ class Plugin(object):
"""
# dummy function, doesn't check if dest.startswith(self.dest_namespace)
def add(arg_name_no_prefix, *args, **kwargs):
- # pylint: disable=missing-docstring
return parser.add_argument(
"--{0}{1}".format(option_namespace(name), arg_name_no_prefix),
*args, **kwargs)
diff --git a/certbot/certbot/plugins/dns_common.py b/certbot/certbot/plugins/dns_common.py
index d31266434..245b7dc05 100644
--- a/certbot/certbot/plugins/dns_common.py
+++ b/certbot/certbot/plugins/dns_common.py
@@ -37,13 +37,13 @@ class DNSAuthenticator(common.Plugin):
help='The number of seconds to wait for DNS to propagate before asking the ACME server '
'to verify the DNS record.')
- def get_chall_pref(self, unused_domain): # pylint: disable=missing-docstring,no-self-use
+ def get_chall_pref(self, unused_domain): # pylint: disable=missing-function-docstring
return [challenges.DNS01]
- def prepare(self): # pylint: disable=missing-docstring
+ def prepare(self): # pylint: disable=missing-function-docstring
pass
- def perform(self, achalls): # pylint: disable=missing-docstring
+ def perform(self, achalls): # pylint: disable=missing-function-docstring
self._setup_credentials()
self._attempt_cleanup = True
@@ -66,7 +66,7 @@ class DNSAuthenticator(common.Plugin):
return responses
- def cleanup(self, achalls): # pylint: disable=missing-docstring
+ def cleanup(self, achalls): # pylint: disable=missing-function-docstring
if self._attempt_cleanup:
for achall in achalls:
domain = achall.domain
diff --git a/certbot/certbot/plugins/dns_common_lexicon.py b/certbot/certbot/plugins/dns_common_lexicon.py
index 3e28a291b..c3d80ca29 100644
--- a/certbot/certbot/plugins/dns_common_lexicon.py
+++ b/certbot/certbot/plugins/dns_common_lexicon.py
@@ -4,9 +4,9 @@ import logging
from requests.exceptions import HTTPError
from requests.exceptions import RequestException
-from acme.magic_typing import Any # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Union # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Any
+from acme.magic_typing import Dict
+from acme.magic_typing import Union
from certbot import errors
from certbot.plugins import dns_common
diff --git a/certbot/certbot/plugins/enhancements.py b/certbot/certbot/plugins/enhancements.py
index f8d9db7dc..be9b7933d 100644
--- a/certbot/certbot/plugins/enhancements.py
+++ b/certbot/certbot/plugins/enhancements.py
@@ -3,9 +3,9 @@ import abc
import six
-from acme.magic_typing import Any # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import List # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Any
+from acme.magic_typing import Dict
+from acme.magic_typing import List
from certbot._internal import constants
ENHANCEMENTS = ["redirect", "ensure-http-header", "ocsp-stapling"]
diff --git a/certbot/certbot/plugins/storage.py b/certbot/certbot/plugins/storage.py
index 7956295d2..fe3a97dd5 100644
--- a/certbot/certbot/plugins/storage.py
+++ b/certbot/certbot/plugins/storage.py
@@ -2,8 +2,8 @@
import json
import logging
-from acme.magic_typing import Any # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Dict # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Any
+from acme.magic_typing import Dict
from certbot import errors
from certbot.compat import filesystem
from certbot.compat import os
diff --git a/certbot/certbot/reverter.py b/certbot/certbot/reverter.py
index 47a77c80a..80ba0f599 100644
--- a/certbot/certbot/reverter.py
+++ b/certbot/certbot/reverter.py
@@ -195,7 +195,7 @@ class Reverter(object):
with open(os.path.join(cp_dir, "CHANGES_SINCE"), "a") as notes_fd:
notes_fd.write(save_notes)
- def _read_and_append(self, filepath): # pylint: disable=no-self-use
+ def _read_and_append(self, filepath):
"""Reads the file lines and returns a file obj.
Read the file returning the lines, and a pointer to the end of the file.
@@ -250,7 +250,7 @@ class Reverter(object):
raise errors.ReverterError(
"Unable to remove directory: %s" % cp_dir)
- def _run_undo_commands(self, filepath): # pylint: disable=no-self-use
+ def _run_undo_commands(self, filepath):
"""Run all commands in a file."""
# NOTE: csv module uses native strings. That is, bytes on Python 2 and
# unicode on Python 3
@@ -413,7 +413,7 @@ class Reverter(object):
"Incomplete or failed recovery for IN_PROGRESS checkpoint "
"- %s" % self.config.in_progress_dir)
- def _remove_contained_files(self, file_list): # pylint: disable=no-self-use
+ def _remove_contained_files(self, file_list):
"""Erase all files contained within file_list.
:param str file_list: file containing list of file paths to be deleted
diff --git a/certbot/certbot/tests/acme_util.py b/certbot/certbot/tests/acme_util.py
index 3d560dcbc..f4a20ea86 100644
--- a/certbot/certbot/tests/acme_util.py
+++ b/certbot/certbot/tests/acme_util.py
@@ -27,7 +27,7 @@ def gen_combos(challbs):
return tuple((i,) for i, _ in enumerate(challbs))
-def chall_to_challb(chall, status): # pylint: disable=redefined-outer-name
+def chall_to_challb(chall, status):
"""Return ChallengeBody from Challenge."""
kwargs = {
"chall": chall,
@@ -67,7 +67,6 @@ def gen_authzr(authz_status, domain, challs, statuses, combos=True):
:param bool combos: Whether or not to add combinations
"""
- # pylint: disable=redefined-outer-name
challbs = tuple(
chall_to_challb(chall, status)
for chall, status in six.moves.zip(challs, statuses)
diff --git a/certbot/certbot/tests/util.py b/certbot/certbot/tests/util.py
index a9870b0fd..8b28b1080 100644
--- a/certbot/certbot/tests/util.py
+++ b/certbot/certbot/tests/util.py
@@ -14,7 +14,7 @@ import mock
import OpenSSL
import pkg_resources
import six
-from six.moves import reload_module # pylint: disable=import-error
+from six.moves import reload_module
from certbot import interfaces
from certbot import util
diff --git a/certbot/certbot/util.py b/certbot/certbot/util.py
index 0a47cd87a..aff2952f7 100644
--- a/certbot/certbot/util.py
+++ b/certbot/certbot/util.py
@@ -5,7 +5,7 @@ import argparse
import atexit
import collections
from collections import OrderedDict
-import distutils.version # pylint: disable=import-error,no-name-in-module
+import distutils.version
import errno
import logging
import platform
@@ -17,8 +17,8 @@ import sys
import configargparse
import six
-from acme.magic_typing import Tuple # pylint: disable=unused-import, no-name-in-module
-from acme.magic_typing import Union # pylint: disable=unused-import, no-name-in-module
+from acme.magic_typing import Tuple
+from acme.magic_typing import Union
from certbot import errors
from certbot._internal import constants
from certbot._internal import lock
@@ -26,7 +26,7 @@ from certbot.compat import filesystem
from certbot.compat import os
if sys.platform.startswith('linux'):
- import distro # pylint: disable=import-error
+ import distro
_USE_DISTRO = True
else:
_USE_DISTRO = False
diff --git a/letshelp-certbot/letshelp_certbot/apache.py b/letshelp-certbot/letshelp_certbot/apache.py
index ebe4e3671..a5947399a 100755
--- a/letshelp-certbot/letshelp_certbot/apache.py
+++ b/letshelp-certbot/letshelp_certbot/apache.py
@@ -16,7 +16,7 @@ import textwrap
import six
-from letshelp_certbot.magic_typing import List # pylint: disable=unused-import, no-name-in-module
+from letshelp_certbot.magic_typing import List
_DESCRIPTION = """
Let's Help is a simple script you can run to help out the Certbot
diff --git a/letshelp-certbot/letshelp_certbot/magic_typing.py b/letshelp-certbot/letshelp_certbot/magic_typing.py
index 5a6358c69..d6b1ff056 100644
--- a/letshelp-certbot/letshelp_certbot/magic_typing.py
+++ b/letshelp-certbot/letshelp_certbot/magic_typing.py
@@ -10,7 +10,6 @@ class TypingClass(object):
try:
# mypy doesn't respect modifying sys.modules
from typing import * # pylint: disable=wildcard-import, unused-wildcard-import
- # pylint: disable=unused-import
from typing import Collection, IO # type: ignore
# pylint: enable=unused-import
except ImportError:
diff --git a/letshelp-certbot/letshelp_certbot/magic_typing_test.py b/letshelp-certbot/letshelp_certbot/magic_typing_test.py
index 200ca03b8..41bc245fa 100644
--- a/letshelp-certbot/letshelp_certbot/magic_typing_test.py
+++ b/letshelp-certbot/letshelp_certbot/magic_typing_test.py
@@ -18,7 +18,7 @@ class MagicTypingTest(unittest.TestCase):
sys.modules['typing'] = typing_class_mock
if 'letshelp_certbot.magic_typing' in sys.modules:
del sys.modules['letshelp_certbot.magic_typing'] # pragma: no cover
- from letshelp_certbot.magic_typing import Text # pylint: disable=no-name-in-module
+ from letshelp_certbot.magic_typing import Text
self.assertEqual(Text, text_mock)
del sys.modules['letshelp_certbot.magic_typing']
sys.modules['typing'] = temp_typing
@@ -31,7 +31,7 @@ class MagicTypingTest(unittest.TestCase):
sys.modules['typing'] = None
if 'letshelp_certbot.magic_typing' in sys.modules:
del sys.modules['letshelp_certbot.magic_typing'] # pragma: no cover
- from letshelp_certbot.magic_typing import Text # pylint: disable=no-name-in-module
+ from letshelp_certbot.magic_typing import Text
self.assertTrue(Text is None)
del sys.modules['letshelp_certbot.magic_typing']
sys.modules['typing'] = temp_typing