diff options
| author | Felix Lechner <felix.lechner@lease-up.com> | 2019-05-31 01:02:15 +0300 |
|---|---|---|
| committer | Brad Warren <bmw@users.noreply.github.com> | 2019-05-31 01:02:15 +0300 |
| commit | 641aba68b1c2e57a912e5edf95178cd29fd66b4b (patch) | |
| tree | 4b99ee9ec01e4d83dd627a7d51dd4712a273d02d /AUTHORS.md | |
| parent | 926c8c198cfb6158b7ad59988702c30e33f13d53 (diff) | |
Ignore editor backups when running hooks. (#7109)
* Ignore editor backups when running hooks.
When processing hooks, certbot also runs editor backups even though
such files are outdated, clearly warranted correction and may quite
possibly be defective.
That behavior could lead to unexpected breakage, and perhaps even pose
security risks---for example, if a previous script was careless with
file permissions. As an aggravating factor, the backup runs after the
corrected version and could unintentionally override a fix the user
thought was properly implemented.
This commit causes editor backup files ending in tilde (~) to be
excluded when running hooks.
Additional information can be found here:
https://github.com/certbot/certbot/issues/7107
https://community.letsencrypt.org/t/editor-backup-files-executed-as-renewal-hooks/94750
* Add unit test for hook scripts with filenames ending in tilde.
* Provide changelog entry for not running hook scripts ending in tilde.
* Add Felix Lechner to the list of contributors.
Diffstat (limited to 'AUTHORS.md')
| -rw-r--r-- | AUTHORS.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/AUTHORS.md b/AUTHORS.md index 6ee739bc0..0e8d88a4d 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -75,6 +75,7 @@ Authors * [Fabian](https://github.com/faerbit) * [Faidon Liambotis](https://github.com/paravoid) * [Fan Jiang](https://github.com/tcz001) +* [Felix Lechner](https://github.com/lechner) * [Felix Schwarz](https://github.com/FelixSchwarz) * [Felix Yan](https://github.com/felixonmars) * [Filip Ochnik](https://github.com/filipochnik) |