Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/certbot/certbot.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/acme
diff options
context:
space:
mode:
authorBrad Warren <bmw@users.noreply.github.com>2021-04-03 02:19:30 +0300
committerGitHub <noreply@github.com>2021-04-03 02:19:30 +0300
commit2622a700e0a83e0de0994c970929b624b98dad40 (patch)
tree18497c0dafc239e8dc8fe603e1e13f6e59020c40 /acme
parent06a53cb7df4a9551bf1d087bb221089d596b357a (diff)
Update a few type ignore comments (#8767)
Some are no longer needed and other's comments are out of date. For the changes to the acme nonce errors, `Exception` doesn't take kwargs. The error message about this our own classes isn't super helpful: ``` In [2]: BadNonce('nonce', 'error', foo='bar') --------------------------------------------------------------------------- TypeError Traceback (most recent call last) <ipython-input-2-54555658ef99> in <module> ----> 1 BadNonce('nonce', 'error', foo='bar') TypeError: __init__() got an unexpected keyword argument 'foo' ``` but if you try this on `Exception` which these classes inherit from, you get: ``` In [4]: Exception(foo='bar') --------------------------------------------------------------------------- TypeError Traceback (most recent call last) <ipython-input-4-028b924f74c5> in <module> ----> 1 Exception(foo='bar') TypeError: Exception() takes no keyword arguments ``` See https://github.com/python/typeshed/pull/2348 for more info. * remove outdated ignores * update locking ignore comment * don't accept kwargs
Diffstat (limited to 'acme')
-rw-r--r--acme/acme/errors.py14
1 files changed, 4 insertions, 10 deletions
diff --git a/acme/acme/errors.py b/acme/acme/errors.py
index 5ca5a4fa2..84b7704dc 100644
--- a/acme/acme/errors.py
+++ b/acme/acme/errors.py
@@ -28,13 +28,8 @@ class NonceError(ClientError):
class BadNonce(NonceError):
"""Bad nonce error."""
- def __init__(self, nonce, error, *args, **kwargs):
- # MyPy complains here that there is too many arguments for BaseException constructor.
- # This is an error fixed in typeshed, see https://github.com/python/mypy/issues/4183
- # The fix is included in MyPy>=0.740, but upgrading it would bring dozen of errors due to
- # new types definitions. So we ignore the error until the code base is fixed to match
- # with MyPy>=0.740 referential.
- super(BadNonce, self).__init__(*args, **kwargs) # type: ignore
+ def __init__(self, nonce, error, *args):
+ super(BadNonce, self).__init__(*args)
self.nonce = nonce
self.error = error
@@ -52,9 +47,8 @@ class MissingNonce(NonceError):
:ivar requests.Response ~.response: HTTP Response
"""
- def __init__(self, response, *args, **kwargs):
- # See comment in BadNonce constructor above for an explanation of type: ignore here.
- super(MissingNonce, self).__init__(*args, **kwargs) # type: ignore
+ def __init__(self, response, *args):
+ super(MissingNonce, self).__init__(*args)
self.response = response
def __str__(self):