diff options
| author | Brad Warren <bmw@users.noreply.github.com> | 2020-09-29 00:27:29 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-09-29 00:27:29 +0300 |
| commit | e066766cc97adec395d93f0644ffa20be8cb0e20 (patch) | |
| tree | 0f8f21742b97bdb81722a4b68e59d2b39053901a /certbot-dns-linode | |
| parent | be6c890874df2f9381c745fc18ef15e655d392e7 (diff) | |
Revert "Disable build isolation during snap dns plugins build (#8319)" (#8323)
This reverts commit feca125437ef1d51ed8cd31a70f45ca46b8f46d2.
Since this change landed, ARM builds for many of the DNS plugins have failed every night. See https://dev.azure.com/certbot/certbot/_build?definitionId=5 or our public Mattermost channel.
I quickly tried to fix this myself and wasn't trivially able to do so. I tried setting `SNAPCRAFT_PYTHON_VENV_ARGS: --system-site-packages` and adding `python3-wheel` as a build dependency, but it didn't work for some reason. The `python3-wheel` package didn't seem to be installed.
I still suspect something like this is the approach we should take, however, I want to fix the failing tests now so things are no longer broken in `master` and those of us on the Certbot team at EFF stop getting spammed with 54 (!!) emails about failed builds from launchpad every night.
Unfortunately, while I was working on this the queue for ARM machines on Launchpad jumped up to an estimated ~20 hour wait, but I confirmed that this fixes the problem by building on an ARM AMI using the instructions at https://github.com/certbot/certbot/blob/master/tools/snap/README.md#use-testing-and-development. If whoever reviews this would like an ARM machine to test on themselves, please let me know.
Diffstat (limited to 'certbot-dns-linode')
| -rw-r--r-- | certbot-dns-linode/snap/snapcraft.yaml | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/certbot-dns-linode/snap/snapcraft.yaml b/certbot-dns-linode/snap/snapcraft.yaml index 937ad27d5..67090b5a2 100644 --- a/certbot-dns-linode/snap/snapcraft.yaml +++ b/certbot-dns-linode/snap/snapcraft.yaml @@ -17,7 +17,6 @@ parts: snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "'[:space:]"` build-environment: - SNAP_BUILD: "True" - - PIP_NO_BUILD_ISOLATION: "no" # To build cryptography and cffi if needed build-packages: [gcc, libffi-dev, libssl-dev, python3-dev] certbot-metadata: |