Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/certbot/certbot.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorsagi <sagi@users.noreply.github.com>2015-12-11 12:26:55 +0300
committersagi <sagi@users.noreply.github.com>2015-12-11 12:26:55 +0300
commitc594a258feb1333300607308bc898019d4950608 (patch)
treedbe061a1af815ac6fea38431ed11b08371bd52e6 /letsencrypt-apache
parentb4746e555a0edc8c5450c5e833b09537620a38b0 (diff)
Change comment on possibility of redirection loops
Diffstat (limited to 'letsencrypt-apache')
-rw-r--r--letsencrypt-apache/letsencrypt_apache/configurator.py6
1 files changed, 4 insertions, 2 deletions
diff --git a/letsencrypt-apache/letsencrypt_apache/configurator.py b/letsencrypt-apache/letsencrypt_apache/configurator.py
index 67b089909..bc12a75fe 100644
--- a/letsencrypt-apache/letsencrypt_apache/configurator.py
+++ b/letsencrypt-apache/letsencrypt_apache/configurator.py
@@ -886,8 +886,10 @@ class ApacheConfigurator(augeas_configurator.AugeasConfigurator):
# Note: if code flow gets here it means we didn't find the exact
- # letsencrypt RewriteRule config for redirection. So if we find
- # another RewriteRule it may induce a loop / config mismatch.
+ # letsencrypt RewriteRule config for redirection. Finding
+ # another RewriteRule is likely to be fine in most or all cases,
+ # but redirect loops are possible in very obscure cases; see #1620
+ # for reasoning.
if self._is_rewrite_exists(general_vh):
logger.warn("Added an HTTP->HTTPS rewrite in addition to "
"other RewriteRules; you may wish to check for "