diff options
| author | Erik Rose <erik@mozilla.com> | 2016-03-04 01:09:24 +0300 |
|---|---|---|
| committer | Erik Rose <erik@mozilla.com> | 2016-03-04 02:02:38 +0300 |
| commit | 55b63fca0dad0fae439bb3e453856987e37dea81 (patch) | |
| tree | d3ac1add3967336b3d2fa0e4036843ff42a5bbc7 /letsencrypt-nginx/setup.py | |
| parent | f2390edb49b862ed82fcd0230e6bc539aa844b3d (diff) | |
Require setuptools>=1.0 in all packages that use the cryptography lib.
When pip-installing any of these packages, pip hit our permissive, any-version "setuptools" dependency first and then ignored all subsequent, more constrained ones, like cryptography's "setuptools>=1.0". See https://github.com/pypa/pip/issues/988. It thus, on a box with setuptools 0.9.8, stuck with that version. Then, at runtime, letsencrypt crashed because pkg_resources couldn't satisfy cryptography's setuptools>=1.0 requirement.
This change lets us pip-install our packages and have it work. We'll need to make sure our direct requirements (all of them) satisfy the more constrained requirements of our dependencies. Yes, it is disgusting.
Diffstat (limited to 'letsencrypt-nginx/setup.py')
| -rw-r--r-- | letsencrypt-nginx/setup.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/letsencrypt-nginx/setup.py b/letsencrypt-nginx/setup.py index 656d6e04f..e53bef059 100644 --- a/letsencrypt-nginx/setup.py +++ b/letsencrypt-nginx/setup.py @@ -12,7 +12,9 @@ install_requires = [ 'letsencrypt=={0}'.format(version), 'PyOpenSSL', 'pyparsing>=1.5.5', # Python3 support; perhaps unnecessary? - 'setuptools', # pkg_resources + # For pkg_resources. >=1.0 so pip resolves it to a version cryptography + # will tolerate; see #2599: + 'setuptools>=1.0', 'zope.interface', ] |