diff options
| author | ohemorange <ebportnoy@gmail.com> | 2020-08-07 02:32:57 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-07 02:32:57 +0300 |
| commit | 086e6c46b6f4d946df700e881980e2b06faafc77 (patch) | |
| tree | 2bd35882ff20b76950c108c3725d2b700e681dae /windows-installer | |
| parent | bc0ed3cb01c6161174994bf1fc5f4f0538970430 (diff) | |
Improve github release creation process (#8189)
* Improve github release creation process
* Comment file
* Update tools/create_github_release.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* run chmod +x on tools/create_github_release.py
* Add description of create github release method
* remove references to unnecessary azure credential
* remove unnecessary import
* Add reminders to update other file to definitions in .azure-pipelines
* Raise an error if we fail to fetch the artifact from azure
* Create github release as a draft, upload artifacts, then un-draft, for hooks to be run at the right point
* get the version number from the release
* add new packages to dev3_extras so they're installed by tools/venv3.py
* remove unnecessary import
* fun fact: tempdirs behave differently when used as a context manager
* Move comment to construct.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
Diffstat (limited to 'windows-installer')
| -rw-r--r-- | windows-installer/construct.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/windows-installer/construct.py b/windows-installer/construct.py index 4b05c926a..ee7420ed7 100644 --- a/windows-installer/construct.py +++ b/windows-installer/construct.py @@ -123,6 +123,8 @@ imp.load_dynamic('pythoncom', pcom) certbot_version = subprocess.check_output([sys.executable, '-c', 'import certbot; print(certbot.__version__)'], universal_newlines=True, cwd=certbot_pkg_path).strip() + # If we change the installer name from `certbot-beta-installer-win32.exe`, it should + # also be changed in tools/create_github_release.py with open(installer_cfg_path, 'w') as file_h: file_h.write('''\ [Application] |