diff options
author | Doug Bunting <6431421+dougbu@users.noreply.github.com> | 2022-11-10 04:10:20 +0300 |
---|---|---|
committer | Doug Bunting <6431421+dougbu@users.noreply.github.com> | 2022-11-10 04:10:20 +0300 |
commit | 8599521bacf55d7cfa7d1a1e1cd71c2745c20d9e (patch) | |
tree | 9499532e6614f0bc9391411cab214f148eba309f | |
parent | 2dea6cd6be3127d514e7ebf788c8af959b6b6cf5 (diff) |
!fixups!
- don't try internal download location in public builds
- use two targets to make Product.targets more readable
-rw-r--r-- | src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj | 3 | ||||
-rw-r--r-- | src/Installers/Windows/WindowsHostingBundle/Product.targets | 70 |
2 files changed, 31 insertions, 42 deletions
diff --git a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj index 7bcdccc746..4ad7d58e60 100644 --- a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj +++ b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj @@ -506,7 +506,8 @@ This package is an internal implementation of the .NET Core SDK and is not meant <ItemGroup> <UrisToDownload Include="https://dotnetcli.azureedge.net/dotnet/$(DotNetRuntimeDownloadPath)" /> <UrisToDownload Include="https://dotnetbuilds.azureedge.net/public/$(DotNetRuntimeDownloadPath)" /> - <UrisToDownload Include="https://dotnetbuilds.azureedge.net/internal/$(DotNetRuntimeDownloadPath)"> + <UrisToDownload Include="https://dotnetbuilds.azureedge.net/internal/$(DotNetRuntimeDownloadPath)" + Condition=" '$(DotnetRuntimeSourceFeedKey)' != '' "> <token>$(DotnetRuntimeSourceFeedKey)</token> </UrisToDownload> </ItemGroup> diff --git a/src/Installers/Windows/WindowsHostingBundle/Product.targets b/src/Installers/Windows/WindowsHostingBundle/Product.targets index fcf92fa1a1..2fe40ebe38 100644 --- a/src/Installers/Windows/WindowsHostingBundle/Product.targets +++ b/src/Installers/Windows/WindowsHostingBundle/Product.targets @@ -25,61 +25,49 @@ </RuntimeInstallers> </ItemGroup> - <Target Name="FetchDependencies" BeforeTargets="Restore;CollectPackageReferences"> + <!-- + Runs before FetchDependencies but can't be depended up because this sets up the item group that target + uses for batching. + --> + <Target Name="CollectDependencies" BeforeTargets="Restore;CollectPackageReferences"> <!-- Use the BrowserDebugHost as a sentinel for the nonshipping version for NETCoreApp. --> - <PropertyGroup> - <x64RemoteAsset>Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x64.exe</x64RemoteAsset> - <x64RemoteAssetFileName>dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x64.exe</x64RemoteAssetFileName> - <x86RemoteAsset>Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x86.exe</x86RemoteAsset> - <x86RemoteAssetFileName>dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x86.exe</x86RemoteAssetFileName> - <arm64RemoteAsset>Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-arm64.exe</arm64RemoteAsset> - <arm64RemoteAssetFileName>dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-arm64.exe</arm64RemoteAssetFileName> - </PropertyGroup> - - <MakeDir Directories="$(DepsPath)" /> - - <!-- Try various places to find the installers. It's either released (use official version), - public but un-released (use dotnetbuilds/public), or internal and unreleased (use dotnetbuilds/internal) --> - <ItemGroup> - <UrisToDownload Include="https://dotnetcli.azureedge.net/dotnet/Runtime/$(x64RemoteAsset)" /> - <UrisToDownload Include="https://dotnetbuilds.azureedge.net/public/$(x64RemoteAsset)" /> - <UrisToDownload Include="https://dotnetbuilds.azureedge.net/internal/$(x64RemoteAsset)"> - <token>$(DotnetRuntimeSourceFeedKey)</token> - </UrisToDownload> - </ItemGroup> - - <DownloadFile Condition=" ! Exists('$(DepsPath)$(x64RemoteAssetFileName)') " - Uris="@(UrisToDownload)" - DestinationPath="$(DepsPath)$(x64RemoteAssetFileName)" /> - <ItemGroup> - <UrisToDownload Remove="@(UrisToDownload)" /> - <UrisToDownload Include="https://dotnetcli.azureedge.net/dotnet/Runtime/$(x86RemoteAsset)" /> - <UrisToDownload Include="https://dotnetbuilds.azureedge.net/public/$(x86RemoteAsset)" /> - <UrisToDownload Include="https://dotnetbuilds.azureedge.net/internal/$(x86RemoteAsset)"> - <token>$(DotnetRuntimeSourceFeedKey)</token> - </UrisToDownload> + <RemoteAsset Include="$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x64.exe"> + <TargetFileName>dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x64.exe</TargetFileName> + </RemoteAsset> + <RemoteAsset Include="$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x86.exe"> + <TargetFileName>dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x86.exe</TargetFileName> + </RemoteAsset> + <RemoteAsset Include="$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-arm64.exe"> + <TargetFileName>dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-arm64.exe</TargetFileName> + </RemoteAsset> </ItemGroup> - <DownloadFile Condition=" ! Exists('$(DepsPath)$(x86RemoteAssetFileName)') " - Uris="@(UrisToDownload)" - DestinationPath="$(DepsPath)$(x86RemoteAssetFileName)" /> + <MakeDir Directories="$(DepsPath)" /> + </Target> + <Target Name="FetchDependencies" BeforeTargets="Restore;CollectPackageReferences" + Outputs="$(DepsPath)%(RemoteAsset.TargetFilename)"> + <!-- + Try various places to find the runtime. It's either released (use official version), public but + unreleased (use dotnetbuilds/public), or internal and unreleased (use dotnetbuilds/internal). + --> <ItemGroup> <UrisToDownload Remove="@(UrisToDownload)" /> - <UrisToDownload Include="https://dotnetcli.azureedge.net/dotnet/Runtime/$(arm64RemoteAsset)" /> - <UrisToDownload Include="https://dotnetbuilds.azureedge.net/public/$(arm64RemoteAsset)" /> - <UrisToDownload Include="https://dotnetbuilds.azureedge.net/internal/$(arm64RemoteAsset)"> + <UrisToDownload Include="https://dotnetcli.azureedge.net/dotnet/Runtime/%(RemoteAsset.Identity)" /> + <UrisToDownload Include="https://dotnetbuilds.azureedge.net/public/Runtime/%(RemoteAsset.Identity)" /> + <UrisToDownload Include="https://dotnetbuilds.azureedge.net/internal/Runtime/%(RemoteAsset.Identity)" + Condition=" '$(DotnetRuntimeSourceFeedKey)' != '' "> <token>$(DotnetRuntimeSourceFeedKey)</token> </UrisToDownload> </ItemGroup> - <DownloadFile Condition=" ! Exists('$(DepsPath)$(arm64RemoteAssetFileName)') " + <DownloadFile Condition=" ! Exists('$(DepsPath)%(RemoteAsset.TargetFilename)') " Uris="@(UrisToDownload)" - DestinationPath="$(DepsPath)$(arm64RemoteAssetFileName)" /> + DestinationPath="$(DepsPath)%(RemoteAsset.TargetFilename)" /> </Target> - <Target Name="ExtractPropertiesFromDotNetMsi" DependsOnTargets="FetchDependencies" BeforeTargets="BeforeBuild"> + <Target Name="ExtractPropertiesFromDotNetMsi" DependsOnTargets="CollectDependencies;FetchDependencies" BeforeTargets="BeforeBuild"> <!-- Create properties that holds the executable name. These are passed to the bundles so we can reference them as variables from inside the ExePackage authoring. --> <CreateProperty Value="%(RuntimeInstallers.Filename)%(Extension)"> |