From 1d62cf9aa5e26274bb4d1993c35ae101d27c8d54 Mon Sep 17 00:00:00 2001 From: Chris Ross Date: Tue, 1 Nov 2022 11:28:33 -0700 Subject: Remove DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER workaround (#44808) --- .azure/pipelines/ci.yml | 2 -- .azure/pipelines/jobs/default-build.yml | 6 ------ eng/tools/HelixTestRunner/TestRunner.cs | 1 - 3 files changed, 9 deletions(-) diff --git a/.azure/pipelines/ci.yml b/.azure/pipelines/ci.yml index 51f266471a..0c9ea523f7 100644 --- a/.azure/pipelines/ci.yml +++ b/.azure/pipelines/ci.yml @@ -794,8 +794,6 @@ stages: jobProperties: timeoutInMinutes: 120 variables: - # !temporary! Remove as soon as .NET SDK includes a new-enough `msbuild` to make this hack unnecessary - DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER: true # Log environment variables in binary logs to ease debugging MSBUILDLOGALLENVIRONMENTVARIABLES: true diff --git a/.azure/pipelines/jobs/default-build.yml b/.azure/pipelines/jobs/default-build.yml index c153355399..ee0110ef2c 100644 --- a/.azure/pipelines/jobs/default-build.yml +++ b/.azure/pipelines/jobs/default-build.yml @@ -251,8 +251,6 @@ jobs: COMPlus_DbgEnableMiniDump: 1 COMPlus_DbgMiniDumpName: "$(System.DefaultWorkingDirectory)/dotnet-%d.%t.core" DotNetBuildsInternalReadSasToken: $(dotnetbuilds-internal-container-read-token) - # !temporary! Remove as soon as .NET SDK includes a new-enough `msbuild` to make this hack unnecessary - DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER: true # Expand provided `env:` properties, if any. ${{ if step.env }}: ${{ step.env }} @@ -265,8 +263,6 @@ jobs: COMPlus_DbgEnableMiniDump: 1 COMPlus_DbgMiniDumpName: "$(System.DefaultWorkingDirectory)/dotnet-%d.%t.core" DotNetBuildsInternalReadSasToken: $(dotnetbuilds-internal-container-read-token) - # !temporary! Remove as soon as .NET SDK includes a new-enough `msbuild` to make this hack unnecessary - DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER: true - ${{ if ne(parameters.agentOs, 'Windows') }}: - script: $(BuildDirectory)/build.sh --ci --nobl --configuration $(BuildConfiguration) $(BuildScriptArgs) displayName: Run build.sh @@ -274,8 +270,6 @@ jobs: COMPlus_DbgEnableMiniDump: 1 COMPlus_DbgMiniDumpName: "$(System.DefaultWorkingDirectory)/dotnet-%d.%t.core" DotNetBuildsInternalReadSasToken: $(dotnetbuilds-internal-container-read-token) - # !temporary! Remove as soon as .NET SDK includes a new-enough `msbuild` to make this hack unnecessary - DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER: true - ${{ parameters.afterBuild }} diff --git a/eng/tools/HelixTestRunner/TestRunner.cs b/eng/tools/HelixTestRunner/TestRunner.cs index f25906d1e0..30285e90ee 100644 --- a/eng/tools/HelixTestRunner/TestRunner.cs +++ b/eng/tools/HelixTestRunner/TestRunner.cs @@ -36,7 +36,6 @@ public class TestRunner ProcessUtil.PrintMessage($"Set VSTEST_DUMP_PATH: {dumpPath}"); EnvironmentVariables.Add("VSTEST_DUMP_PATH", dumpPath); EnvironmentVariables.Add("DOTNET_CLI_VSTEST_TRACE", "1"); - EnvironmentVariables.Add("DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER", "1"); if (Options.InstallPlaywright) { -- cgit v1.2.3