diff options
author | Tomáš Rylek <trylek@microsoft.com> | 2020-10-11 19:54:29 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-10-11 19:54:29 +0300 |
commit | 61080834c65fe7378b764546ff1592bc93ea7e7f (patch) | |
tree | d63987ed7d0980f2280ed2b618810201bdfd15cb /.vsconfig | |
parent | 58f28f6f1ff4ae319d5c1eeb25160f90aa04857a (diff) |
Fix composite Crossgen2 runs on Windows and clean up R2R pipelines (#43261)
Some time ago I introduced a new option "crossgenframeworkonly"
in the test build scripts and I modified the CoreCLR pipeline
to use it. Turns out it was never fully functional, crossgenning
framework continued taking place in the CORE_ROOT population phase
(generatelayoutonly) and only on Windows it got duplicated in the
subsequent "crossgen framework" step. This duplication moreover
uncovered a bug in the R2RTest tool - when compiling the framework
in composite mode twice in a row, the tool was incorrectly
manipulating the composite file "framework-r2r.dll", causing an
error in the second framework crossgenning step.
I believe that it's completely logical to crossgen the framework
as part of populating CORE_ROOT. In light of this fact I have just
deleted the separate "crossgen framework" step and the corresponding
build script options. I have also fixed the described bug in R2RTest
related to repeated framework crossgenning in composite mode to
restore the invariant that framework crossgenning should be idempotent.
Thanks
Tomas
Diffstat (limited to '.vsconfig')
0 files changed, 0 insertions, 0 deletions