diff options
author | dotnet-bot <dotnet-bot@microsoft.com> | 2021-11-17 20:32:56 +0300 |
---|---|---|
committer | dotnet-bot <dotnet-bot@microsoft.com> | 2021-11-17 20:32:56 +0300 |
commit | 3a25a7f1cc446b60678ed25c9d829420d6321eba (patch) | |
tree | 2a715d21150e9c87b74e52a267faeb81f1513661 | |
parent | bfdc5e92677d896f3c96318ddffbf3b70138bb20 (diff) | |
parent | e9036b04357e8454439a0e6cf22186a0cb19e616 (diff) |
Merge in 'release/6.0' changesv6.0.1
-rw-r--r-- | eng/packaging.targets | 18 | ||||
-rw-r--r-- | src/libraries/System.DirectoryServices/Directory.Build.props | 3 | ||||
-rw-r--r-- | src/libraries/System.Text.Json/src/System.Text.Json.csproj | 2 |
3 files changed, 20 insertions, 3 deletions
diff --git a/eng/packaging.targets b/eng/packaging.targets index 72401ef6da0..9fe4b569e5f 100644 --- a/eng/packaging.targets +++ b/eng/packaging.targets @@ -39,9 +39,15 @@ <UseIntellisenseDocumentationFile Condition="'$(UseIntellisenseDocumentationFile)' == '' and Exists('$(LibIntellisenseDocumentationFilePath)')">true</UseIntellisenseDocumentationFile> </PropertyGroup> - <PropertyGroup Condition="'$(ServicingVersion)' != ''"> + <PropertyGroup Condition="'$(PreReleaseVersionLabel)' == 'servicing'"> + <!-- If no servicing version is set we need to default to 0 in order for dependency versions to + be calculated propertly, if we don't set it to 0, we would get the dependency version using the + product Patch Version --> + <ServicingVersion Condition="'$(ServicingVersion)' == ''">0</ServicingVersion> + <!-- Always update the package version in servicing. --> - <VersionPrefix>$(MajorVersion).$(MinorVersion).$(ServicingVersion)</VersionPrefix> + <Version>$(MajorVersion).$(MinorVersion).$(ServicingVersion)</Version> + <Version Condition="'$(VersionSuffix)' != ''">$(Version)-$(VersionSuffix)</Version> <_IsWindowsDesktopApp Condition="$(WindowsDesktopCoreAppLibrary.Contains('$(AssemblyName);'))">true</_IsWindowsDesktopApp> <_IsAspNetCoreApp Condition="$(AspNetCoreAppLibrary.Contains('$(AssemblyName);'))">true</_IsAspNetCoreApp> <_AssemblyInTargetingPack Condition="('$(IsNETCoreAppSrc)' == 'true' or '$(_IsAspNetCoreApp)' == 'true' or '$(_IsWindowsDesktopApp)' == 'true') and '$(TargetFrameworkIdentifier)' != '.NETFramework'">true</_AssemblyInTargetingPack> @@ -267,9 +273,15 @@ </Target> <Target Name="ValidateAssemblyVersionsInRefPack" - Condition="$(_AssemblyInTargetingPack) == 'true' and '$(PreReleaseVersionLabel)' == 'servicing'" + Condition="'$(SkipValidateAssemblyVersion)' != 'true' and '$(_AssemblyInTargetingPack)' == 'true' and '$(PreReleaseVersionLabel)' == 'servicing'" AfterTargets="CoreCompile" > <Error Condition="'$(AssemblyVersion)' != '$(LastReleasedStableAssemblyVersion)'" Text="AssemblyVersion should match last released assembly version $(LastReleasedStableAssemblyVersion)" /> </Target> + <Target Name="ValidateServicingVersionIsPropertlySet" + Condition="'$(PreReleaseVersionLabel)' == 'servicing'" + AfterTargets="GenerateNuspec"> + <Error Condition="'$(ServicingVersion)' == '0'" Text="ServicingVersion is set to 0 and it should be an increment of the patch version from the last released package." /> + </Target> + </Project> diff --git a/src/libraries/System.DirectoryServices/Directory.Build.props b/src/libraries/System.DirectoryServices/Directory.Build.props index bfa544ca6f6..0740890146a 100644 --- a/src/libraries/System.DirectoryServices/Directory.Build.props +++ b/src/libraries/System.DirectoryServices/Directory.Build.props @@ -5,6 +5,9 @@ plan on shipping a new desktop version out of band. Instead add API to a different assembly. --> <AssemblyVersion>4.0.0.0</AssemblyVersion> + <!-- Since this assembly version is pinned, we don't want to validate that it matches + the expected assembly version on the targeting pack. --> + <SkipValidateAssemblyVersion>true</SkipValidateAssemblyVersion> <StrongNameKeyId>Microsoft</StrongNameKeyId> <SupportedOSPlatforms>windows</SupportedOSPlatforms> </PropertyGroup> diff --git a/src/libraries/System.Text.Json/src/System.Text.Json.csproj b/src/libraries/System.Text.Json/src/System.Text.Json.csproj index bba18ce24ed..daff09c9802 100644 --- a/src/libraries/System.Text.Json/src/System.Text.Json.csproj +++ b/src/libraries/System.Text.Json/src/System.Text.Json.csproj @@ -9,6 +9,8 @@ <Nullable>enable</Nullable> <IncludeInternalObsoleteAttribute>true</IncludeInternalObsoleteAttribute> <IsPackable>true</IsPackable> + <GeneratePackageOnBuild>true</GeneratePackageOnBuild> + <ServicingVersion>1</ServicingVersion> <PackageDescription>Provides high-performance and low-allocating types that serialize objects to JavaScript Object Notation (JSON) text and deserialize JSON text to objects, with UTF-8 support built-in. Also provides types to read and write JSON text encoded as UTF-8, and to create an in-memory document object model (DOM), that is read-only, for random access of the JSON elements within a structured view of the data. Commonly Used Types: |