diff options
author | Viktor Hofer <viktor.hofer@microsoft.com> | 2020-12-25 05:02:42 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-12-25 05:02:42 +0300 |
commit | 4834579356655bd51b243f55c2ed2ead216a616a (patch) | |
tree | 4543ab670fe0c64674b17a64a9fa3298e02db136 | |
parent | 007f6b9d8eaca50f70261928d74651fda40387a7 (diff) |
Consolidate packaging properties (#46331)
* Consolidate packaging properties
* Remove versions.txt file from packages
The versions.txt file was added to packages to know which SHA a package
was built against. As the nuspec now contains the SHA, the versions file
isn't necessary anymore.
19 files changed, 42 insertions, 208 deletions
diff --git a/Directory.Build.props b/Directory.Build.props index 5586f4493d4..d654ceb8757 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -77,6 +77,10 @@ <LicenseUrl>https://github.com/dotnet/runtime/blob/master/LICENSE.TXT</LicenseUrl> <RuntimeIdGraphDefinitionFile>$([MSBuild]::NormalizePath('$(LibrariesProjectRoot)', 'pkg', 'Microsoft.NETCore.Platforms', 'runtime.json'))</RuntimeIdGraphDefinitionFile> <LicenseFile>$(RepoRoot)LICENSE.TXT</LicenseFile> + <PackageLicenseExpression>MIT</PackageLicenseExpression> + <Copyright>$(CopyrightNetFoundation)</Copyright> + <PackageThirdPartyNoticesFile>$(RepoRoot)THIRD-PARTY-NOTICES.TXT</PackageThirdPartyNoticesFile> + <ReleaseNotes>https://go.microsoft.com/fwlink/?LinkID=799421</ReleaseNotes> <!-- Indicates this is not an officially supported release. Release branches should set this to false. --> <!-- Keep it in sync with PRERELEASE in eng/native/configureplatform.cmake --> diff --git a/Directory.Build.targets b/Directory.Build.targets index 6b1d21054a2..e8bb87918af 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -22,6 +22,17 @@ </PropertyGroup> <!-- Packaging --> + <ItemGroup Condition="'$(IsPackable)' == 'true'"> + <!-- The sfxproj files add the license themselves. --> + <None Include="$(LicenseFile)" + PackagePath="$([System.IO.Path]::GetFileName('$(LicenseFile)'))" + Pack="true" + Condition="'$(MSBuildProjectExtension)' != '.sfxproj'" /> + <None Include="$(PackageThirdPartyNoticesFile)" + PackagePath="$([System.IO.Path]::GetFileName('$(PackageThirdPartyNoticesFile)'))" + Pack="true" /> + </ItemGroup> + <PropertyGroup> <PackageDescription Condition="'$(PackageDescription)' == '' and '$(Description)' != ''">$(Description)</PackageDescription> <RuntimePackageDisclaimer>Internal implementation package not meant for direct consumption. Please do not reference directly.</RuntimePackageDisclaimer> diff --git a/eng/Versions.props b/eng/Versions.props index 9ac80108b3a..d593adec027 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -10,9 +10,7 @@ <PreReleaseVersionIteration>1</PreReleaseVersionIteration> <!-- Set assembly version to align with major and minor version, as for the patches and revisions should be manually updated per assembly if it is serviced. --> - <!-- Changing assembly versions without changing TFM lead to broken packages. - This shoud be incremented after introducing the 6.0 TFM. --> - <AssemblyVersion>6.0.0.0</AssemblyVersion> + <AssemblyVersion>$(MajorVersion).$(MinorVersion).0.0</AssemblyVersion> <!-- Enable to remove prerelease label. --> <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion> <DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind> diff --git a/eng/packaging.props b/eng/packaging.props index 7d06318fd9d..5a2eee17fe5 100644 --- a/eng/packaging.props +++ b/eng/packaging.props @@ -1,12 +1,5 @@ <Project> <PropertyGroup> - <PackageReportDir Condition="'$(PackageReportDir)' == ''">$([MSBuild]::NormalizeDirectory('$(ArtifactsPackagesDir)', 'reports'))</PackageReportDir> - <PackageLicenseFile>$(RepoRoot)LICENSE.TXT</PackageLicenseFile> - <PackageThirdPartyNoticesFile>$(RepoRoot)THIRD-PARTY-NOTICES.TXT</PackageThirdPartyNoticesFile> - <ReleaseNotes>https://go.microsoft.com/fwlink/?LinkID=799421</ReleaseNotes> - <ProjectUrl Condition="'$(ProjectUrl)' == ''">https://github.com/dotnet/runtime</ProjectUrl> - <Copyright>$(CopyrightNetFoundation)</Copyright> - <PackageLicenseExpression>MIT</PackageLicenseExpression> <!-- defined in buildtools packaging.targets, but we need this before targets are imported --> <PackagePlatform Condition="'$(PackagePlatform)' == ''">$(Platform)</PackagePlatform> <PackagePlatform Condition="'$(PackagePlatform)' == 'amd64'">x64</PackagePlatform> @@ -17,8 +10,6 @@ <!-- We're currently not building a "live" baseline, instead we're using .NETCore 1.0 RTM stable versions as the baseline --> <SkipBaseLineCheck>true</SkipBaseLineCheck> - - <!-- by default all packages will use the same version which revs with respect to product version --> <PackageVersion Condition="'$(PackageVersion)' == ''">6.0.0</PackageVersion> <!-- major.minor.release version of the platforms package we're currently building Pre-release will be appended during build --> @@ -51,37 +42,16 @@ <Import Condition="Exists('$(PkgDir)baseline\baseline.props') and '$(MSBuildProjectExtension)' == '.pkgproj'" Project="$(PkgDir)baseline\baseline.props" /> - <PropertyGroup Condition="'$(OsEnvironment)' == 'Unix'"> - <!-- - Building packages fails for two reasons. - First, nuget doesn't like the paths in the nuspec having backslashes as directory separators. - Second, we aren't yet building pdbs, which the nuspecs specify. - --> - <SkipBuildPackages>true</SkipBuildPackages> + <PropertyGroup Condition="'$(IsPackable)' == 'true'"> + <PackageDesignerMarkerFile>$(MSBuildThisFileDirectory)useSharedDesignerContext.txt</PackageDesignerMarkerFile> </PropertyGroup> - <ItemGroup Condition="'$(MSBuildProjectExtension)' == '.pkgproj'"> - <!-- Add required legal files to packages --> - <File Condition="Exists('$(PackageLicenseFile)')" - Include="$(PackageLicenseFile)" > - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> - <File Condition="Exists('$(PackageThirdPartyNoticesFile)')" - Include="$(PackageThirdPartyNoticesFile)" > - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> - - <!-- Add version file to packages --> - <File Condition="Exists('$(VersionFileForPackages)')" - Include="$(VersionFileForPackages)"> - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> - + <ItemGroup Condition="'$(IsPackable)' == 'true'"> <!-- Add a marker to help the designer optimize & share .NET Core packages --> - <File Condition="'$(IncludeDesignerMarker)' != 'false'" - Include="$(PkgDir)useSharedDesignerContext.txt"> - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> + <None Include="$(PackageDesignerMarkerFile)" + PackagePath="$([System.IO.Path]::GetFileName('$(PackageDesignerMarkerFile)'))" + Pack="true" + Condition="'$(IncludeDesignerMarker)' != 'false'" /> <!-- Make sure that NETStandard.Library package never gets added as a dependency for .NET 4.6.1 --> <SuppressMetaPackage Include="NETStandard.Library" TargetFramework="net461" /> diff --git a/src/libraries/pkg/useSharedDesignerContext.txt b/eng/useSharedDesignerContext.txt index e69de29bb2d..e69de29bb2d 100644 --- a/src/libraries/pkg/useSharedDesignerContext.txt +++ b/eng/useSharedDesignerContext.txt diff --git a/src/coreclr/.nuget/packaging.props b/src/coreclr/.nuget/packaging.props index 8a54c66b585..3354bcf8230 100644 --- a/src/coreclr/.nuget/packaging.props +++ b/src/coreclr/.nuget/packaging.props @@ -1,14 +1,5 @@ -<?xml version="1.0" encoding="utf-8"?> <Project> - <PropertyGroup> - <PackageLicenseFile>$(CoreclrDir)/LICENSE.TXT</PackageLicenseFile> - <PackageThirdPartyNoticesFile>$(CoreclrDir)/THIRD-PARTY-NOTICES.TXT</PackageThirdPartyNoticesFile> - - <ReleaseNotes>https://go.microsoft.com/fwlink/?LinkID=799421</ReleaseNotes> - - <ProjectUrl>https://dot.net</ProjectUrl> - <!-- Defined in Packaging.targets, but we need this before targets are imported --> <PackagePlatform Condition="'$(PackagePlatform)' == ''">$(Platform)</PackagePlatform> <PackagePlatform Condition="'$(PackagePlatform)' == 'amd64'">x64</PackagePlatform> @@ -16,30 +7,19 @@ <MinOSForArch Condition="'$(PackagePlatform)' == 'arm'">win8</MinOSForArch> <MinOSForArch Condition="'$(PackagePlatform)' == 'arm64'">win10</MinOSForArch> - <PackageIndexFile>$(MSBuildThisFileDirectory)/packageIndex.json</PackageIndexFile> + <PackageIndexFile>$(MSBuildThisFileDirectory)packageIndex.json</PackageIndexFile> <!-- coreclr doesn't currently use the index so don't force it to be in sync --> <SkipIndexCheck>true</SkipIndexCheck> - <VersionTxtFile Condition="'$(VersionTxtFile)' == ''">$(ArtifactsObjDir)version.txt</VersionTxtFile> + <!-- Central place to set the versions of all nuget packages produced in the repo --> + <PackageVersion Condition="'$(PackageVersion)' == ''">6.0.0</PackageVersion> + <!-- Set the boolean below to true to generate packages with stabilized versions --> + <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion> + <StableVersion Condition="'$(StabilizePackageVersion)' == 'true' and '$(StableVersion)' == ''">$(PackageVersion)</StableVersion> </PropertyGroup> - <ItemGroup Condition="'$(MSBuildProjectExtension)' == '.pkgproj'"> - <!-- Add required legal files to packages --> - <File Condition="Exists('$(PackageLicenseFile)')" - Include="$(PackageLicenseFile)" > - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> - <File Condition="Exists('$(PackageThirdPartyNoticesFile)')" - Include="$(PackageThirdPartyNoticesFile)" > - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> - <PackageIndex Include="$(PackageIndexFile)" /> - - <!-- Add version file to packages --> - <File Include="$(VersionTxtFile)" - Condition="Exists('$(VersionTxtFile)')"> - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> + <ItemGroup> + <PackageIndex Condition="'$(MSBuildProjectExtension)' == '.pkgproj'" Include="$(PackageIndexFile)" /> </ItemGroup> </Project> diff --git a/src/coreclr/.nuget/versioning.targets b/src/coreclr/.nuget/versioning.targets index 9b5ea266a93..6c7ccd3ebc3 100644 --- a/src/coreclr/.nuget/versioning.targets +++ b/src/coreclr/.nuget/versioning.targets @@ -1,20 +1,4 @@ <Project> - <!-- Generate a version.txt file we include in our packages - The InitializeSourceControlInformationFromSourceControlManager is part of Microsoft.Build.Tasks.Git - and is responsible for setting SourceRevisionId --> - <Target Name="GenerateVersionInfoFileForPackages" - BeforeTargets="Build" - DependsOnTargets="InitializeSourceControlInformationFromSourceControlManager"> - - <Error Condition="'$(SourceRevisionId)' == ''" Text="SourceRevisionId is not set, which means the SourceLink targets are not included in the build. Those are needed to produce a correct sha for our build outputs." /> - - <MakeDir Directories="$([System.IO.Path]::GetDirectoryName($(VersionTxtFile)))" /> - <WriteLinesToFile - File="$(VersionTxtFile)" - Lines="$(SourceRevisionId)" - Overwrite="true" /> - </Target> - <!-- Update the project references with additional properties calculated during the execution phase. _InitializeAssemblyVersion is provided by Arcade. It sets the AssemblyVersion and FileVersion properties. We depend on this private Arcade target instead of the SDK-defined GetAssemblyVersion since the packaging diff --git a/src/coreclr/Directory.Build.props b/src/coreclr/Directory.Build.props index 2e05f56574b..76efd96a314 100644 --- a/src/coreclr/Directory.Build.props +++ b/src/coreclr/Directory.Build.props @@ -9,11 +9,6 @@ <Import Project="dir.common.props" /> <Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" /> - <PropertyGroup Condition="'$(CopyrightNetFoundation)' != ''"> - <Copyright>$(CopyrightNetFoundation)</Copyright> - <PackageLicenseExpression>MIT</PackageLicenseExpression> - </PropertyGroup> - <PropertyGroup> <SignAssembly Condition="'$(UsingMicrosoftNETSdk)'!='true'">false</SignAssembly> </PropertyGroup> diff --git a/src/coreclr/dir.common.props b/src/coreclr/dir.common.props index 08e71350e98..ffd190f9947 100644 --- a/src/coreclr/dir.common.props +++ b/src/coreclr/dir.common.props @@ -41,15 +41,6 @@ <PackagesBinDir>$(RuntimeBinDir).nuget\</PackagesBinDir> </PropertyGroup> - <PropertyGroup> - <!-- Central place to set the versions of all nuget packages produced in the repo --> - <PackageVersion Condition="'$(PackageVersion)' == ''">6.0.0</PackageVersion> - - <!-- Set the boolean below to true to generate packages with stabilized versions --> - <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion> - <StableVersion Condition="'$(StabilizePackageVersion)' == 'true' and '$(StableVersion)' == ''">$(PackageVersion)</StableVersion> - </PropertyGroup> - <!-- Set the kind of PDB to Portable --> <PropertyGroup> <DebugType Condition="'$(DebugType)' == ''">Portable</DebugType> diff --git a/src/installer/managed/CommonManaged.props b/src/installer/managed/CommonManaged.props index 957ee4710e2..803db57b7c9 100644 --- a/src/installer/managed/CommonManaged.props +++ b/src/installer/managed/CommonManaged.props @@ -1,6 +1,4 @@ -<?xml version="1.0" encoding="utf-8"?> -<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> - +<Project> <PropertyGroup> <IsPackable>true</IsPackable> <GeneratePackageOnBuild>true</GeneratePackageOnBuild> @@ -9,11 +7,6 @@ <TreatWarningsAsErrors>true</TreatWarningsAsErrors> <IncludeSymbols>true</IncludeSymbols> <Serviceable>true</Serviceable> - <PackageLicenseFile>LICENSE.TXT</PackageLicenseFile> - <PackageProjectUrl>https://dot.net</PackageProjectUrl> - <Authors>Microsoft</Authors> - <NugetLicenseFile>$(RepoRoot)$(PackageLicenseFile)</NugetLicenseFile> - <PackageThirdPartyNoticesFile>$(RepoRoot)THIRD-PARTY-NOTICES.TXT</PackageThirdPartyNoticesFile> <GenerateDocumentationFile>true</GenerateDocumentationFile> <!-- Managed API isn't completely documented yet. TODO: https://github.com/dotnet/core-setup/issues/5108 --> <NoWarn>$(NoWarn);CS1591</NoWarn> @@ -25,17 +18,4 @@ <SignAssembly>true</SignAssembly> <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign> </PropertyGroup> - - <!-- Add required legal files to packages --> - <ItemGroup> - <Content Condition="Exists('$(NugetLicenseFile)')" - Include="$(NugetLicenseFile)"> - <PackagePath /> - </Content> - <Content Condition="Exists('$(PackageThirdPartyNoticesFile)')" - Include="$(PackageThirdPartyNoticesFile)"> - <PackagePath /> - </Content> - </ItemGroup> - </Project> diff --git a/src/installer/pkg/Directory.Build.props b/src/installer/pkg/Directory.Build.props index 2124dbbe46f..92f5bd1ca92 100644 --- a/src/installer/pkg/Directory.Build.props +++ b/src/installer/pkg/Directory.Build.props @@ -7,12 +7,6 @@ </PropertyGroup> <PropertyGroup> - <PackageLicenseFile>$(RepoRoot)LICENSE.TXT</PackageLicenseFile> - <PackageThirdPartyNoticesFile>$(RepoRoot)THIRD-PARTY-NOTICES.TXT</PackageThirdPartyNoticesFile> - <PackageLicenseExpression>MIT</PackageLicenseExpression> - <!-- This link should be updated for each release milestone, currently this points to 1.0.0 --> - <ReleaseNotes>https://go.microsoft.com/fwlink/?LinkID=799417</ReleaseNotes> - <ProjectUrl>https://dot.net</ProjectUrl> <PackagePlatform Condition="'$(PackagePlatform)' == ''">$(Platform)</PackagePlatform> <PackagePlatform Condition="'$(PackagePlatform)' == 'amd64'">x64</PackagePlatform> diff --git a/src/installer/pkg/projects/Directory.Build.props b/src/installer/pkg/projects/Directory.Build.props index d64e7f18c1f..f34785016a3 100644 --- a/src/installer/pkg/projects/Directory.Build.props +++ b/src/installer/pkg/projects/Directory.Build.props @@ -81,18 +81,6 @@ <TargetFramework Condition="'$(TargetFramework)' == ''">$(NetCoreAppCurrent)</TargetFramework> </PropertyGroup> - <!-- Add required legal files to packages --> - <ItemGroup Condition="'$(MSBuildProjectExtension)' == '.pkgproj'"> - <File Condition="Exists('$(PackageLicenseFile)')" - Include="$(PackageLicenseFile)" > - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> - <File Condition="Exists('$(PackageThirdPartyNoticesFile)')" - Include="$(PackageThirdPartyNoticesFile)" > - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> - </ItemGroup> - <PropertyGroup> <RIDPropsFile Condition="'$(RIDPropsFile)' == ''">$(MSBuildThisFileDirectory)\netcoreappRIDs.props</RIDPropsFile> </PropertyGroup> diff --git a/src/installer/pkg/sfx/Directory.Build.props b/src/installer/pkg/sfx/Directory.Build.props index d5cbb935989..e5473445909 100644 --- a/src/installer/pkg/sfx/Directory.Build.props +++ b/src/installer/pkg/sfx/Directory.Build.props @@ -7,16 +7,6 @@ <PropertyGroup> <TargetFramework>$(NetCoreAppCurrent)</TargetFramework> - <!-- The built-in packaging targets make PackageLicenseFile and PackageLicenseExpression - mututally exclusive. Use PackageLicenseExpression if it's available. --> - <PackageLicenseFile Condition="'$(PackageLicenseExpression)' != ''"></PackageLicenseFile> - <PackageThirdPartyNoticesFile>$(RepoRoot)THIRD-PARTY-NOTICES.TXT</PackageThirdPartyNoticesFile> - <!-- This link should be updated for each release milestone, currently this points to 1.0.0 --> - <ReleaseNotes>https://go.microsoft.com/fwlink/?LinkID=799417</ReleaseNotes> - <ProjectUrl>https://dot.net</ProjectUrl> - <Authors>Microsoft</Authors> - <MinClientVersion>2.12</MinClientVersion> - <LicenseFile>$(RepoRoot)LICENSE.TXT</LicenseFile> <ProductBrandPrefix>Microsoft .NET</ProductBrandPrefix> <GenerateInstallers>true</GenerateInstallers> <GenerateVSInsertionPackages>true</GenerateVSInsertionPackages> diff --git a/src/libraries/Directory.Build.props b/src/libraries/Directory.Build.props index 9d600a0efd9..49def0855af 100644 --- a/src/libraries/Directory.Build.props +++ b/src/libraries/Directory.Build.props @@ -202,8 +202,6 @@ <MicrosoftNetCoreAppRuntimePackRidLibTfmDir>$([MSBuild]::NormalizeDirectory('$(MicrosoftNetCoreAppRuntimePackRidDir)', 'lib', '$(NetCoreAppCurrent)'))</MicrosoftNetCoreAppRuntimePackRidLibTfmDir> <MicrosoftNetCoreAppRuntimePackNativeDir>$([MSBuild]::NormalizeDirectory('$(MicrosoftNetCoreAppRuntimePackRidDir)', 'native'))</MicrosoftNetCoreAppRuntimePackNativeDir> - <VersionFileForPackages Condition="'$(VersionFileForPackages)' == ''">$(ArtifactsObjDir)version.txt</VersionFileForPackages> - <CommonPathRoot>$([MSBuild]::NormalizeDirectory('$(LibrariesProjectRoot)', 'Common'))</CommonPathRoot> <CommonPath>$([MSBuild]::NormalizeDirectory('$(CommonPathRoot)', 'src'))</CommonPath> <CommonTestPath>$([MSBuild]::NormalizeDirectory('$(CommonPathRoot)', 'tests'))</CommonTestPath> diff --git a/src/libraries/System.Collections.Immutable/pkg/System.Collections.Immutable.pkgproj b/src/libraries/System.Collections.Immutable/pkg/System.Collections.Immutable.pkgproj index 0b9a49629c1..9383884e5e8 100644 --- a/src/libraries/System.Collections.Immutable/pkg/System.Collections.Immutable.pkgproj +++ b/src/libraries/System.Collections.Immutable/pkg/System.Collections.Immutable.pkgproj @@ -1,9 +1,5 @@ <Project DefaultTargets="Build"> <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))" /> - <PropertyGroup> - <!-- we need to be supported on pre-nuget-3 platforms (Dev12, Dev11, etc) --> - <MinClientVersion>2.8.6</MinClientVersion> - </PropertyGroup> <ItemGroup> <ProjectReference Include="..\src\System.Collections.Immutable.csproj"> <SupportedFramework>net45;netcore45;netcoreapp1.0;wp8;wpa81;$(AllXamarinFrameworks)</SupportedFramework> diff --git a/src/libraries/System.Numerics.Tensors/pkg/System.Numerics.Tensors.pkgproj b/src/libraries/System.Numerics.Tensors/pkg/System.Numerics.Tensors.pkgproj index f65777171b7..b3bc61caec5 100644 --- a/src/libraries/System.Numerics.Tensors/pkg/System.Numerics.Tensors.pkgproj +++ b/src/libraries/System.Numerics.Tensors/pkg/System.Numerics.Tensors.pkgproj @@ -1,9 +1,5 @@ <Project DefaultTargets="Build"> <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))" /> - <PropertyGroup> - <!-- we need to be supported on pre-nuget-3 platforms (Dev12, Dev11, etc) --> - <MinClientVersion>2.8.6</MinClientVersion> - </PropertyGroup> <ItemGroup> <!-- We don't include the reference project for two reasons: 1. It is identical to the implementation assembly, which is very small and not a partial facade diff --git a/src/libraries/libraries-packages.proj b/src/libraries/libraries-packages.proj index 491cd148f20..2dc22f8e2d3 100644 --- a/src/libraries/libraries-packages.proj +++ b/src/libraries/libraries-packages.proj @@ -57,19 +57,6 @@ <UpdatePackageIndex PackageIndexFile="$(PackageIndexFile)" StablePackages="@(_StablePackages)" /> - - </Target> - - <!-- Generate a version text file we include in our packages --> - <Target Name="GenerateVersionFileForPackages" - BeforeTargets="Build;Pack" - DependsOnTargets="InitializeSourceControlInformationFromSourceControlManager"> - <Error Condition="'$(SourceRevisionId)' == ''" Text="SourceRevisionId is not set, which means the SourceLink targets are not included in the build. Those are needed to produce a correct sha for our build outputs." /> - - <MakeDir Directories="$([System.IO.Path]::GetDirectoryName($(VersionFileForPackages)))" /> - <WriteLinesToFile File="$(VersionFileForPackages)" - Lines="$(SourceRevisionId)" - Overwrite="true" /> </Target> <Target Name="SetAzureDevOpsVariableForBuiltPackages" diff --git a/src/mono/Directory.Build.props b/src/mono/Directory.Build.props index d8ea4765431..319ae93e9f7 100644 --- a/src/mono/Directory.Build.props +++ b/src/mono/Directory.Build.props @@ -23,15 +23,6 @@ </PropertyGroup> <PropertyGroup> - <!-- Central place to set the versions of all nuget packages produced in the repo --> - <PackageVersion Condition="'$(PackageVersion)' == ''">6.0.0</PackageVersion> - - <!-- Set the boolean below to true to generate packages with stabilized versions --> - <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion> - <StableVersion Condition="'$(StabilizePackageVersion)' == 'true' and '$(StableVersion)' == ''">$(PackageVersion)</StableVersion> - </PropertyGroup> - - <PropertyGroup> <!-- Minimum target OS version, keep in sync with src/libraries/Native/build-native.sh --> <iOSVersionMin>8.0</iOSVersionMin> <tvOSVersionMin>9.0</tvOSVersionMin> @@ -64,11 +55,6 @@ <!-- Ensure our properties are set before Arcade defines defaults --> <Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" /> - <PropertyGroup Condition="'$(CopyrightNetFoundation)' != ''"> - <Copyright>$(CopyrightNetFoundation)</Copyright> - <PackageLicenseExpression>MIT</PackageLicenseExpression> - </PropertyGroup> - <PropertyGroup> <SignAssembly Condition="'$(UsingMicrosoftNETSdk)'!='true'">false</SignAssembly> </PropertyGroup> diff --git a/src/mono/netcore/nuget/Directory.Build.props b/src/mono/netcore/nuget/Directory.Build.props index ee0a76ebb06..4630ccface1 100644 --- a/src/mono/netcore/nuget/Directory.Build.props +++ b/src/mono/netcore/nuget/Directory.Build.props @@ -1,39 +1,25 @@ <Project> <!-- Packaging projects (.pkgproj) are non-SDK-style, so they need to directly import Directory.Build.props --> - <Import Project="../../Directory.Build.props" /> - + <Import Project="..\..\Directory.Build.props" /> <Import Project="$(NuGetPackageRoot)\microsoft.dotnet.build.tasks.packaging\$(MicrosoftDotNetBuildTasksPackagingVersion)\build\Microsoft.DotNet.Build.Tasks.Packaging.props" /> <PropertyGroup> - <PackageLicenseFile>$(CoreclrDir)/LICENSE.TXT</PackageLicenseFile> - - <ReleaseNotes>https://go.microsoft.com/fwlink/?LinkID=799421</ReleaseNotes> - - <ProjectUrl>https://dot.net</ProjectUrl> - - <PackageIndexFile>$(MSBuildThisFileDirectory)/packageIndex.json</PackageIndexFile> + <PackageIndexFile>$(MSBuildThisFileDirectory)packageIndex.json</PackageIndexFile> <PackagePlatform>AnyCPU</PackagePlatform> <!-- mono doesn't currently use the index so don't force it to be in sync --> <SkipIndexCheck>true</SkipIndexCheck> - - <VersionTxtFile Condition="'$(VersionTxtFile)' == ''">$(ArtifactsObjDir)version.txt</VersionTxtFile> + + <!-- Central place to set the versions of all nuget packages produced in the repo --> + <PackageVersion Condition="'$(PackageVersion)' == ''">6.0.0</PackageVersion> + <!-- Set the boolean below to true to generate packages with stabilized versions --> + <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion> + <StableVersion Condition="'$(StabilizePackageVersion)' == 'true' and '$(StableVersion)' == ''">$(PackageVersion)</StableVersion> </PropertyGroup> - <ItemGroup Condition="'$(MSBuildProjectExtension)' == '.pkgproj'"> - <!-- Add required legal files to packages --> - <File Condition="Exists('$(PackageLicenseFile)')" - Include="$(PackageLicenseFile)" > - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> - <PackageIndex Include="$(PackageIndexFile)" /> - - <!-- Add version file to packages --> - <File Include="$(VersionTxtFile)" - Condition="Exists('$(VersionTxtFile)')"> - <SkipPackageFileCheck>true</SkipPackageFileCheck> - </File> + <ItemGroup> + <PackageIndex Condition="'$(MSBuildProjectExtension)' == '.pkgproj'" Include="$(PackageIndexFile)" /> </ItemGroup> </Project> |